[jira] [Commented] (PROTON-1604) Windows C++ prefers std::endl to newlines

2017-10-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189048#comment-16189048
 ] 

ASF subversion and git services commented on PROTON-1604:
-

Commit 95ee34e3873d90c5c9cf774452d2b10ea81f in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=95ee34e ]

PROTON-1604: undo most of 0bed410 if readability or performance impacted, as 
per sage advice from astitcher


> Windows C++ prefers std::endl to newlines
> -
>
> Key: PROTON-1604
> URL: https://issues.apache.org/jira/browse/PROTON-1604
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.18.0
> Environment: Visual Studio
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: proton-c-0.18.0
>
>
> Using C newline escaped char sequence can result in mysteriously missing 
> output.
> Use std::endl instead of \\n.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1604) Windows C++ prefers std::endl to newlines

2017-10-02 Thread Andrew Stitcher (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188059#comment-16188059
 ] 

Andrew Stitcher commented on PROTON-1604:
-

Instead of blithely changing all "\n" character sequences it would make more 
sense to only replace the ones that actually need flushing.

OR

Probably better to just add std::flush in places where missing output is a 
problem.

Also note that std::cerr flushes automatically in any case so doesn't need 
std::endl, only std::cout would need std::endl.

> Windows C++ prefers std::endl to newlines
> -
>
> Key: PROTON-1604
> URL: https://issues.apache.org/jira/browse/PROTON-1604
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.18.0
> Environment: Visual Studio
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: proton-c-0.18.0
>
>
> Using C newline escaped char sequence can result in mysteriously missing 
> output.
> Use std::endl instead of \\n.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1604) Windows C++ prefers std::endl to newlines

2017-09-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187241#comment-16187241
 ] 

ASF subversion and git services commented on PROTON-1604:
-

Commit 0bed4109e73a0b664a65b09eced98f1ce8d00354 in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0bed410 ]

PROTON-1604: replace C++ newlines with std::endl in output strings


> Windows C++ prefers std::endl to newlines
> -
>
> Key: PROTON-1604
> URL: https://issues.apache.org/jira/browse/PROTON-1604
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.18.0
> Environment: Visual Studio
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: proton-c-0.18.0
>
>
> Using C newline escaped char sequence can result in mysteriously missing 
> output.
> Use std::endl instead of \\n.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org