[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631970#comment-16631970 ] Alan Conway commented on PROTON-1703: - Un-assigning myself and linking this as "is contained by" to the master deprecation clean-up Jira PROTON-1943. Should be reviewed at the next release where we consider removing deprecated features. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533865#comment-16533865 ] Alan Conway commented on PROTON-1703: - I think the deprecated macros and comments are sufficient for marking the source code, but I like Robbie's suggestion of a master Jira. In this case the fix was made and reverted, so having a link to the Jira gives us the fix to be re-applied. When we get to a breaking release we can check both the linked Jiras and the source code to make sure we fix everything with maximum information. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533855#comment-16533855 ] ASF subversion and git services commented on PROTON-1703: - Commit ea315ff04bd91418aa9755e91370a97cca6bb61f in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ea315ff ] PROTON-1703: [cpp] deprecated macro for receiver::auto_settle Was deprecated in comment only, added deprecation warning macro. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533687#comment-16533687 ] Robbie Gemmell commented on PROTON-1703: I'd say there should be JIRAs (like this one) for any such outstanding change needing made, and they could all be linked to another JIRA used to actually perform the major version change. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533607#comment-16533607 ] Justin Ross commented on PROTON-1703: - [~aconway], I think we should review everything that's deprecated when we make a major-version jump. That said, it wouldn't hurt to have some in-source marker for a PLANNED-ABI-BREAK or something similar that we could search for. Alan, side note, this one seems like a good candidate to use the deprecation macro (the one with the warning), since no one should be using it. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532921#comment-16532921 ] Alan Conway commented on PROTON-1703: - [~jr...@redhat.com] do we have a strategy to track bugs like this that are waiting for a binary-incompat release? It's unlikely to get attention at the right moment if it's just sitting at the low-priority end of my to-do list. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327188#comment-16327188 ] Robbie Gemmell commented on PROTON-1703: Note that the change was made then reverted to avoid API+ABI change in the 0.19.0 release for such a trivial item when there weren't any other such changes. JIRA reopened in case a suitable opportunity presents itself later that it can be included along with other changes. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313394#comment-16313394 ] ASF subversion and git services commented on PROTON-1703: - Commit b9f9402598171602ed7d3c6f7dd410906d1d0684 in qpid-proton's branch refs/heads/go1 from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b9f9402 ] Revert PROTON-1703: [cpp] Remove auto_settle from receiver_options Reverted the change for binary compatibility but deprecated auto_settle since it is a no-op on receiver. To remove at next major revision. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297280#comment-16297280 ] ASF subversion and git services commented on PROTON-1703: - Commit b9f9402598171602ed7d3c6f7dd410906d1d0684 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b9f9402 ] Revert PROTON-1703: [cpp] Remove auto_settle from receiver_options Reverted the change for binary compatibility but deprecated auto_settle since it is a no-op on receiver. To remove at next major revision. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.18.1 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: proton-c-0.19.0 > > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272697#comment-16272697 ] ASF subversion and git services commented on PROTON-1703: - Commit d5069e1250b50ec3dc7205a9fa0cb1b33bb1b1c8 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d5069e1 ] PROTON-1703: [cpp] Remove auto_settle from receiver_options auto_settle is a sender-only option, the receiver equivalent is auto_accept It is only used at messaging_adapter.cpp#L172, which applies only to senders. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.18.1 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: proton-c-0.19.0 > > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
