[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532009#comment-16532009 ] ASF subversion and git services commented on PROTON-1771: - Commit 1764c4d0cd27dce88df2db8e468f1e2f97054e5f in qpid-proton's branch refs/heads/go1 from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1764c4d ] PROTON-1771: [c] threaderciser.supp added bogus NSS races > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532008#comment-16532008 ] ASF subversion and git services commented on PROTON-1771: - Commit 3206378b0149c903f0507fc6429ae899e38f2368 in qpid-proton's branch refs/heads/go1 from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3206378 ] PROTON-1771: [c] fix race conditions in threaderciser.c Was incorrectly calling pn_connection_close() from non-handler threads. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487317#comment-16487317 ] Robbie Gemmell commented on PROTON-1771: [~aconway], withi 0.23.0 going out soon/now, this Jira should be resolved, and a new JIRA created against 0.24.0 for any additional work. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478008#comment-16478008 ] ASF subversion and git services commented on PROTON-1771: - Commit 1764c4d0cd27dce88df2db8e468f1e2f97054e5f in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1764c4d ] PROTON-1771: [c] threaderciser.supp added bogus NSS races > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477940#comment-16477940 ] ASF subversion and git services commented on PROTON-1771: - Commit 3206378b0149c903f0507fc6429ae899e38f2368 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3206378 ] PROTON-1771: [c] fix race conditions in threaderciser.c Was incorrectly calling pn_connection_close() from non-handler threads. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468169#comment-16468169 ] ASF subversion and git services commented on PROTON-1771: - Commit 94dfe1bf033f7d4b9183bbad75b1801d688a300d in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=94dfe1b ] PROTON-1771: [c] add -close-connnect, -cancel-timeout to threaderciser Also added -no-xxx flags to disable selected actions > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439749#comment-16439749 ] ASF subversion and git services commented on PROTON-1771: - Commit fc1df0551947c357e9fa0bf9da4b836c5a97c11f in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fc1df05 ] Revert "PROTON-1771: [c] locking around epoll_extended_t" This reverts commit 188ce28066df8f5e965fb63593f419f49c950760. The fix caused hangs due to mutex deadlocks. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436289#comment-16436289 ] ASF subversion and git services commented on PROTON-1771: - Commit 3e2f9b5f8164a6720740b49b72af6471b1081df9 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3e2f9b5 ] PROTON-1771: [c] add missing lock around wake_if_inactive Fixes a race condition discovered by threaderciser.c > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436290#comment-16436290 ] ASF subversion and git services commented on PROTON-1771: - Commit 188ce28066df8f5e965fb63593f419f49c950760 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=188ce28 ] PROTON-1771: [c] locking around epoll_extended_t Add locking for epoll_extended_t structure to fix race conditions revealed by threaderciser.c We pass pointers to this struct between threads via epoll, and epoll does not guarantee that memory writes by one thread will be visible in the next thread that gets the pointer. Since helgrind reports the races, it suggests that epoll is not acting as a memory barrier in practice either. These mutexes will not be contended so they are not expensive. We could use an acquire/release memory barrier, but an un-contended mutex is basically exactly that, and is portable. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor
[ https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436288#comment-16436288 ] ASF subversion and git services commented on PROTON-1771: - Commit 8a4fac69fa8442351bb763c4835fc706a273 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8a4fac6 ] PROTON-1771: [c] threaderciser thread race test for C proactor Take random actions in multiple threads, try to provoke race conditions under helgrind or other race checker. Actions can be enabled or disabled on command line to simplify the test. threaderciser.supp has supressions for race conditions detected on Linux with the epoll proactor. > [c-proactor] multi-thread race test for proactor > > > Key: PROTON-1771 > URL: https://issues.apache.org/jira/browse/PROTON-1771 > Project: Qpid Proton > Issue Type: Test > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.23.0 > > > Crate a new test exe that runs for a (configurable, default short) period of > time, with a single proactor acted on by multiple proactor and user threads. > Run > with helgrind or tsan to detect races. > Exercise potentially racy APIs concurrently: > - making, accepting and closing (from both ends) a connection. > - pn_connection_wake > - pn_proactor_release_connection > - re-use of released pn_connection_t on a new connection > - timeout > - concurrent with some normal use: sending/receiving messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
