[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123856#comment-17123856 ] ASF subversion and git services commented on PROTON-1800: - Commit 65a5d9e837cf8de3024e7039dc7f5f2175d13461 in qpid-proton's branch refs/heads/master from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=65a5d9e ] PROTON-1800: issue not completely fixed, ignore the failing test (#253) > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123855#comment-17123855 ] ASF GitHub Bot commented on PROTON-1800: jiridanek merged pull request #253: URL: https://github.com/apache/qpid-proton/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123465#comment-17123465 ] ASF GitHub Bot commented on PROTON-1800: codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/qpid-proton/pull/253#issuecomment-637360331 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/b34bbea0e34901b8e25b1c74715fcc5a5229ad65&el=desc) will **increase** coverage by `0.00%`. > The diff coverage is `81.81%`. [](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #253 +/- ## === Coverage 83.09% 83.09% === Files 339 339 Lines 4136241368+6 === + Hits3436834373+5 - Misses 6994 6995+1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5) | `91.20% <81.81%> (-1.30%)` | :arrow_down: | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.54% <0.00%> (-0.17%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.21% <0.00%> (-0.06%)` | :arrow_down: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.61% <0.00%> (+0.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=footer). Last update [b34bbea...032094a](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123464#comment-17123464 ] ASF GitHub Bot commented on PROTON-1800: codecov-commenter commented on pull request #253: URL: https://github.com/apache/qpid-proton/pull/253#issuecomment-637360331 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/b34bbea0e34901b8e25b1c74715fcc5a5229ad65&el=desc) will **increase** coverage by `0.00%`. > The diff coverage is `81.81%`. [](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #253 +/- ## === Coverage 83.09% 83.09% === Files 339 339 Lines 4136241368+6 === + Hits3436834373+5 - Misses 6994 6995+1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5) | `91.20% <81.81%> (-1.30%)` | :arrow_down: | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.54% <0.00%> (-0.17%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.21% <0.00%> (-0.06%)` | :arrow_down: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.61% <0.00%> (+0.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=footer). Last update [b34bbea...032094a](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123348#comment-17123348 ] ASF GitHub Bot commented on PROTON-1800: astitcher edited a comment on pull request #253: URL: https://github.com/apache/qpid-proton/pull/253#issuecomment-637272942 I think the name of the new decorator is too general. How about something like "skipOnFailure" or perhaps "ignoreFailure"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123347#comment-17123347 ] ASF GitHub Bot commented on PROTON-1800: astitcher commented on pull request #253: URL: https://github.com/apache/qpid-proton/pull/253#issuecomment-637272942 I think the name of the new decorator is too general. How about something like "skipOnFailure"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120204#comment-17120204 ] ASF GitHub Bot commented on PROTON-1800: jiridanek opened a new pull request #253: URL: https://github.com/apache/qpid-proton/pull/253 @astitcher this implements the decorator you suggested to skip test if `AssertionError`s occurred. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Assignee: Jiri Daněk >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[
https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118841#comment-17118841
]
Jiri Daněk commented on PROTON-1800:
Test added, It used to pass for me so far, everywhere, but today I saw it fail
on an Ubuntu system.
{noformat}
==
FAIL: test_sync_request_response_blocking_connection_no_object_leaks
(test_PROTON_1800_syncrequestresponse_fd_leak.Proton1800Test)
--
Traceback (most recent call last):
File
"/foo/proton/python/tests/integration/test_PROTON_1800_syncrequestresponse_fd_leak.py",
line 135, in test_sync_request_response_blocking_connection_no_object_leaks
client.connection.close()
File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
self.gen.next()
File
"/foo/proton/python/tests/integration/test_PROTON_1800_syncrequestresponse_fd_leak.py",
line 61, in no_fd_leaks
test.assertEqual(0, delta, "Found {0} new fd(s) after the
test".format(delta))
AssertionError: Found 1 new fd(s) after the test
{noformat}
Note that the test is wrongly named, it is looking for fd leaks, not object
leaks.
CC [~kpvdr], I was wrong about this one. I thought it is for a different issue
which was partially fixed.
> BlockingConnection descriptor leak
> --
>
> Key: PROTON-1800
> URL: https://issues.apache.org/jira/browse/PROTON-1800
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.21.0
>Reporter: Andy Smith
>Assignee: Jiri Daněk
>Priority: Major
> Labels: leak, workaround
> Fix For: proton-c-future
>
> Attachments: sync_client.py
>
>
> Modified collectd python plugin from using persistent connection to
> connection per read. Following change, detected descriptor leak.
> Attached modification to sync_client.py exhibits the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078559#comment-17078559 ] Jiri Daněk commented on PROTON-1800: Looks to me to be fixed since 0.28.0. I'll add a test. > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Priority: Major > Labels: leak, workaround > Fix For: proton-c-future > > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1800) BlockingConnection descriptor leak
[ https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425053#comment-16425053 ] Cliff Jansen commented on PROTON-1800: -- As a workaround, adding client.receiver = None in the finally clause works for me. > BlockingConnection descriptor leak > -- > > Key: PROTON-1800 > URL: https://issues.apache.org/jira/browse/PROTON-1800 > Project: Qpid Proton > Issue Type: Bug >Affects Versions: proton-c-0.21.0 >Reporter: Andy Smith >Priority: Major > Attachments: sync_client.py > > > Modified collectd python plugin from using persistent connection to > connection per read. Following change, detected descriptor leak. > Attached modification to sync_client.py exhibits the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
