[jira] [Commented] (PROTON-2238) qpid-proton doesn't build with OpenSSL 3.0.0
[
https://issues.apache.org/jira/browse/PROTON-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156285#comment-17156285
]
ASF GitHub Bot commented on PROTON-2238:
jiridanek closed pull request #257:
URL: https://github.com/apache/qpid-proton/pull/257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qpid-proton doesn't build with OpenSSL 3.0.0
>
>
> Key: PROTON-2238
> URL: https://issues.apache.org/jira/browse/PROTON-2238
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Vitezslav Cizek
>Priority: Minor
>
> OpenSSL 3.0.0 deprecates {{SSL_CTX_load_verify_locations}}.
> As {{-Werror}} is turned on by default, the warning causes a build failure:
> {noformat}
> qpid-proton-0.31.0/c/src/ssl/openssl.c:722:3: error:
> 'SSL_CTX_load_verify_locations' is deprecated
> [-Werror=deprecated-declarations]
> 722 | if (SSL_CTX_load_verify_locations( domain->ctx, file, dir ) != 1) {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2238) qpid-proton doesn't build with OpenSSL 3.0.0
[
https://issues.apache.org/jira/browse/PROTON-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125619#comment-17125619
]
Vitezslav Cizek commented on PROTON-2238:
-
The deprecation of SSL_CTX_load_verify_locations has been recently reverted in
[https://github.com/openssl/openssl/commit/c7f837cfcc5b2e5cd8eeeff82e0245323f206d02.]
So the changes in pull request #257 are no longer necessary for now, but might
be useful in the future though.
> qpid-proton doesn't build with OpenSSL 3.0.0
>
>
> Key: PROTON-2238
> URL: https://issues.apache.org/jira/browse/PROTON-2238
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Vitezslav Cizek
>Priority: Minor
>
> OpenSSL 3.0.0 deprecates {{}}{{SSL_CTX_load_verify_locations.}}
> As -Werror is turned on by default, the warning causes a build failure:
> qpid-proton-0.31.0/c/src/ssl/openssl.c:722:3: error:
> 'SSL_CTX_load_verify_locations' is deprecated
> [-Werror=deprecated-declarations]
> 722 | if (SSL_CTX_load_verify_locations( domain->ctx, file, dir ) != 1) {
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2238) qpid-proton doesn't build with OpenSSL 3.0.0
[
https://issues.apache.org/jira/browse/PROTON-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125229#comment-17125229
]
ASF GitHub Bot commented on PROTON-2238:
codecov-commenter edited a comment on pull request #257:
URL: https://github.com/apache/qpid-proton/pull/257#issuecomment-638394000
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=h1)
Report
> Merging
[#257](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461&el=desc)
will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=tree)
```diff
@@Coverage Diff @@
## master #257 +/- ##
==
+ Coverage 83.05% 83.14% +0.09%
==
Files 338 339 +1
Lines 4143141520 +89
==
+ Hits3441034522 +112
+ Misses 7021 6998 -23
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==)
| `84.35% <ø> (ø)` | |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.21% <0.00%> (-0.06%)` | :arrow_down: |
|
[ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=)
| `95.55% <0.00%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `82.25% <0.00%> (+0.99%)` | :arrow_up: |
|
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
| `96.10% <0.00%> (+3.89%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=footer).
Last update
[65a5d9e...ffaf970](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qpid-proton doesn't build with OpenSSL 3.0.0
>
>
> Key: PROTON-2238
> URL: https://issues.apache.org/jira/browse/PROTON-2238
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Vitezslav Cizek
>Priority: Minor
>
> OpenSSL 3.0.0 deprecates {{}}{{SSL_CTX_load_verify_locations.}}
> As -Werror is turned on by default, the warning causes a build failure:
> qpid-proton-0.31.0/c/src/ssl/openssl.c:722:3: error:
> 'SSL_CTX_load_verify_locations' is deprecated
> [-Werror=deprecated-declarations]
> 722 | if (SSL_CTX_load_verify_locations( domain->ctx, file, dir ) != 1) {
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2238) qpid-proton doesn't build with OpenSSL 3.0.0
[
https://issues.apache.org/jira/browse/PROTON-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125228#comment-17125228
]
ASF GitHub Bot commented on PROTON-2238:
codecov-commenter commented on pull request #257:
URL: https://github.com/apache/qpid-proton/pull/257#issuecomment-638394000
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=h1)
Report
> Merging
[#257](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461&el=desc)
will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=tree)
```diff
@@Coverage Diff @@
## master #257 +/- ##
==
+ Coverage 83.05% 83.14% +0.09%
==
Files 338 339 +1
Lines 4143141520 +89
==
+ Hits3441034522 +112
+ Misses 7021 6998 -23
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==)
| `84.35% <ø> (ø)` | |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.21% <0.00%> (-0.06%)` | :arrow_down: |
|
[ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=)
| `95.55% <0.00%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `82.25% <0.00%> (+0.99%)` | :arrow_up: |
|
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/257/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
| `96.10% <0.00%> (+3.89%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=footer).
Last update
[65a5d9e...ffaf970](https://codecov.io/gh/apache/qpid-proton/pull/257?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qpid-proton doesn't build with OpenSSL 3.0.0
>
>
> Key: PROTON-2238
> URL: https://issues.apache.org/jira/browse/PROTON-2238
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Vitezslav Cizek
>Priority: Minor
>
> OpenSSL 3.0.0 deprecates {{}}{{SSL_CTX_load_verify_locations.}}
> As -Werror is turned on by default, the warning causes a build failure:
> qpid-proton-0.31.0/c/src/ssl/openssl.c:722:3: error:
> 'SSL_CTX_load_verify_locations' is deprecated
> [-Werror=deprecated-declarations]
> 722 | if (SSL_CTX_load_verify_locations( domain->ctx, file, dir ) != 1) {
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2238) qpid-proton doesn't build with OpenSSL 3.0.0
[
https://issues.apache.org/jira/browse/PROTON-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125166#comment-17125166
]
ASF GitHub Bot commented on PROTON-2238:
ciz opened a new pull request #257:
URL: https://github.com/apache/qpid-proton/pull/257
Use SSL_CTX_load_verify_dir and SSL_CTX_load_verify_file instead of
SSL_CTX_load_verify_locations when compiling with openssl >= 3.0.0.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qpid-proton doesn't build with OpenSSL 3.0.0
>
>
> Key: PROTON-2238
> URL: https://issues.apache.org/jira/browse/PROTON-2238
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Vitezslav Cizek
>Priority: Minor
>
> OpenSSL 3.0.0 deprecates {{}}{{SSL_CTX_load_verify_locations.}}
> As -Werror is turned on by default, the warning causes a build failure:
> qpid-proton-0.31.0/c/src/ssl/openssl.c:722:3: error:
> 'SSL_CTX_load_verify_locations' is deprecated
> [-Werror=deprecated-declarations]
> 722 | if (SSL_CTX_load_verify_locations( domain->ctx, file, dir ) != 1) {
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
