[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597112#comment-17597112 ] ASF GitHub Bot commented on PROTON-2347: gemmellr commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1230083642 Theres some other general updates I'll do before releasing, probably late this week or next week (release process takes at least a few days). Note it will be with the other change referenced, not this one, per previous comment. > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.10 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Assignee: Robbie Gemmell >Priority: Minor > Fix For: proton-j-0.34.0 > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585605#comment-17585605 ] ASF GitHub Bot commented on PROTON-2347: RamIoTMalhotra commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1228884085 @gemmellr when can we expect a release for this change? > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.10 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Assignee: Robbie Gemmell >Priority: Minor > Fix For: proton-j-0.34.0 > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584394#comment-17584394 ] ASF GitHub Bot commented on PROTON-2347: BenD10 commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1226036217 Awesome I can see it main now, thank you very much @gemmellr! > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.10 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Assignee: Robbie Gemmell >Priority: Minor > Fix For: proton-j-0.34.0 > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584392#comment-17584392 ] ASF GitHub Bot commented on PROTON-2347: BenD10 closed pull request #43: PROTON-2347 Prevent leak when IOException is encountered URL: https://github.com/apache/qpid-proton-j/pull/43 > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.10 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Assignee: Robbie Gemmell >Priority: Minor > Fix For: proton-j-0.34.0 > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584332#comment-17584332 ] ASF GitHub Bot commented on PROTON-2347: gemmellr commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1225918692 The reactor free() looks wrong since it may have other connections. There was another related change in #38 other folks already seem to be using, I have applied it. > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584330#comment-17584330 ] ASF subversion and git services commented on PROTON-2347: - Commit 7071772619d8bc596b30b01cc7816118abc9e598 in qpid-proton-j's branch refs/heads/main from Einar Bergseth [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=70717726 ] PROTON-2347: Fix leakage of socket handles when soketChannel.connect() fails with an Exception (socketChannel.close() is not called.) This closes #38 > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583838#comment-17583838 ] ASF GitHub Bot commented on PROTON-2347: BenD10 commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1224830720 Hi @gemmellr, I'm hopeful you can take a look at this whenever you have a chance. Thanks in advance! > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583822#comment-17583822 ] ASF GitHub Bot commented on PROTON-2347: BenD10 opened a new pull request, #43: URL: https://github.com/apache/qpid-proton-j/pull/43 https://issues.apache.org/jira/browse/PROTON-2347 When an IOException is thrown, the SocketChannel was not properly cleaned up which caused a file descriptor leak. To confirm the fix, I used the reproducer available in the above JIRA and monitored open file handles. Using 0.33.10: ``` ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:14 PM EDT 60086 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:17 PM EDT 85005 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:21 PM EDT 116822 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:27 PM EDT 155766 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:33 PM EDT 209201 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:41 PM EDT 275748 ``` With the fix on 0.34.0-SNAPSHOT ``` ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:23 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:26 PM EDT 40 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:32 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:47 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:54 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:41:01 PM EDT 44 ``` > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303671#comment-17303671 ] Tim Taylor commented on PROTON-2347: My apologies for the duplicate issues that I filed. The Jira GUI displayed some odd exceptions when I tried to file the first few issues, so I thought they weren't created. > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org