[jira] [Commented] (PROTON-2448) Implement a dumping AMQP values without using pn_data_t
[ https://issues.apache.org/jira/browse/PROTON-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464655#comment-17464655 ] ASF subversion and git services commented on PROTON-2448: - Commit 8a289c78f7ca24849369d508577f913ff307a7ca in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=8a289c7 ] PROTON-2448: Fix the frame trace not to dump null fields in described lists > Implement a dumping AMQP values without using pn_data_t > --- > > Key: PROTON-2448 > URL: https://issues.apache.org/jira/browse/PROTON-2448 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > Printing AMQP values is widely used in proton especially for frame tracing. > It is massively inefficient because it relies on there being an existing > pn_data_t structure which represents the AMQP value. > In the upcoming work to remove pn_data_t use from (nearly all of ) the > critical path of proton-c there will no longer be such a pn_data_t that > represents the received or transmitted frame. So we need new code to dump the > AMQP values. Luckily the new AMQP consume code provides a simple skeleton > which makes this fairly straightforward. > This new code can now produce text dumps of AMQP frames/values direct form > the bytes encoding the frames with no intermediate step. This allows the use > if this code in th elowest level send and receive code of the AMQP engine. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2448) Implement a dumping AMQP values without using pn_data_t
[ https://issues.apache.org/jira/browse/PROTON-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459474#comment-17459474 ] ASF subversion and git services commented on PROTON-2448: - Commit 89082f1eb4c1ca16407bc0a612b3b439868a2749 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=89082f1 ] PROTON-2476: Restore truncation behaviour for transfer frame traces The logging changes that came with PROTON-2448 had the side effect of no longer truncating the message payloads that came along with transfer frames. This meant that these trace lines could get extremely long if applications were sending long messages and could also take a very long time to allocate memory and format the string. > Implement a dumping AMQP values without using pn_data_t > --- > > Key: PROTON-2448 > URL: https://issues.apache.org/jira/browse/PROTON-2448 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > Printing AMQP values is widely used in proton especially for frame tracing. > It is massively inefficient because it relies on there being an existing > pn_data_t structure which represents the AMQP value. > In the upcoming work to remove pn_data_t use from (nearly all of ) the > critical path of proton-c there will no longer be such a pn_data_t that > represents the received or transmitted frame. So we need new code to dump the > AMQP values. Luckily the new AMQP consume code provides a simple skeleton > which makes this fairly straightforward. > This new code can now produce text dumps of AMQP frames/values direct form > the bytes encoding the frames with no intermediate step. This allows the use > if this code in th elowest level send and receive code of the AMQP engine. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
