[jira] [Commented] (QPID-4164) Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup
[ https://issues.apache.org/jira/browse/QPID-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424884#comment-13424884 ] Justin Ross commented on QPID-4164: --- Reviewed by Keith, Philip, and Robbie. Approved for 0.18. > Management moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been loaded from the store at Broker startup > --- > > Key: QPID-4164 > URL: https://issues.apache.org/jira/browse/QPID-4164 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker BDB Store, Java Management : > JMX Console >Affects Versions: 0.16, 0.18 >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Critical > Fix For: 0.19 > > Attachments: > QPID-4164-MaxDeliveryCountTest-should-restart-broker-after-enqueue.patch > > > The JMX moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been recovered from the store at Broker startup. > The Broker permanently loses the message's payload. > If an operator subsequently tries to view the problematic message with the > Management interfaces, a Broker thread will be put into an infinite loop and > this will require a Broker restart. > This problem does not affect messages sent during the lifetime of the > Broker's execution (they can be moved or copied as normal). The existence of > messages with lost payload within the Broker does not affect the flight of > other messages through the Broker. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4164) Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup
[ https://issues.apache.org/jira/browse/QPID-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424868#comment-13424868 ] Keith Wall commented on QPID-4164: -- Hi Phil, no comments on your patch. It has been applied to trunk. > Management moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been loaded from the store at Broker startup > --- > > Key: QPID-4164 > URL: https://issues.apache.org/jira/browse/QPID-4164 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker BDB Store, Java Management : > JMX Console >Affects Versions: 0.16, 0.18 >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Critical > Fix For: 0.19 > > Attachments: > QPID-4164-MaxDeliveryCountTest-should-restart-broker-after-enqueue.patch > > > The JMX moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been recovered from the store at Broker startup. > The Broker permanently loses the message's payload. > If an operator subsequently tries to view the problematic message with the > Management interfaces, a Broker thread will be put into an infinite loop and > this will require a Broker restart. > This problem does not affect messages sent during the lifetime of the > Broker's execution (they can be moved or copied as normal). The existence of > messages with lost payload within the Broker does not affect the flight of > other messages through the Broker. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4164) Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup
[ https://issues.apache.org/jira/browse/QPID-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424326#comment-13424326 ] Keith Wall commented on QPID-4164: -- Hi Robbie, I reviewed your change of 27/Jul/12 11:28. No comments. I agree these commits should be part of 0.18. > Management moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been loaded from the store at Broker startup > --- > > Key: QPID-4164 > URL: https://issues.apache.org/jira/browse/QPID-4164 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker BDB Store, Java Management : > JMX Console >Affects Versions: 0.16, 0.18 >Reporter: Keith Wall >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.19 > > Attachments: > QPID-4164-MaxDeliveryCountTest-should-restart-broker-after-enqueue.patch > > > The JMX moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been recovered from the store at Broker startup. > The Broker permanently loses the message's payload. > If an operator subsequently tries to view the problematic message with the > Management interfaces, a Broker thread will be put into an infinite loop and > this will require a Broker restart. > This problem does not affect messages sent during the lifetime of the > Broker's execution (they can be moved or copied as normal). The existence of > messages with lost payload within the Broker does not affect the flight of > other messages through the Broker. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4164) Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup
[ https://issues.apache.org/jira/browse/QPID-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423805#comment-13423805 ] Robbie Gemmell commented on QPID-4164: -- The changes look good to me except one small thing: in the Derby store it used to only keep the hard reference to the metadata if it still needed to be persisted whereas after the change it always does it, so recovered messages will always hard reference the metadata. I have restored the previous behaviour to the Derby store and added the same behaviour to the BDB store, allowing the SoftReference to release the data the same way it can for new messages arriving off the wire (if memory pressure demands it). Can you review my changes? (I would personally consider this to be a 0.18 blocker) > Management moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been loaded from the store at Broker startup > --- > > Key: QPID-4164 > URL: https://issues.apache.org/jira/browse/QPID-4164 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker BDB Store, Java Management : > JMX Console >Affects Versions: 0.16, 0.18 >Reporter: Keith Wall >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.19 > > > The JMX moveMessage/copyMessage functions fail to properly move/copy the > message if the message has been recovered from the store at Broker startup. > The Broker permanently loses the message's payload. > If an operator subsequently tries to view the problematic message with the > Management interfaces, a Broker thread will be put into an infinite loop and > this will require a Broker restart. > This problem does not affect messages sent during the lifetime of the > Broker's execution (they can be moved or copied as normal). The existence of > messages with lost payload within the Broker does not affect the flight of > other messages through the Broker. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
