[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-12-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246677#comment-14246677
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1645667 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1645667 ]

QPID-6125: [Java Broker] Fix test broken by my previous commit

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-12-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246624#comment-14246624
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1645645 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1645645 ]

QPID-6125: [Java Broker] Consistently quote queue/exchange names in error 
messages sent back over the wire

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-11-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200218#comment-14200218
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1637118 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1637118 ]

QPID-6125: [Java Broker] Partial revert so that closeConnection will once again 
await for an already closing connection to become closed

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181084#comment-14181084
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633756 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633756 ]

QPID-6125 : temporary hack to deal with issue causing tests to fail when broker 
close occurs before message.release()

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180452#comment-14180452
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633706 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633706 ]

QPID-6125 : only send close frame if not already closing

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180285#comment-14180285
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633671 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633671 ]

QPID-6125 : make coalescing committer commit on stop if environment still viable

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179847#comment-14179847
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633604 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633604 ]

QPID-6125 : make _virtualHost volatile

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179761#comment-14179761
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633579 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633579 ]

QPID-6125 : only log store exceptions that occur against a vhost which is no 
longer AVAILABLE

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177467#comment-14177467
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633230 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633230 ]

QPID-6125 : correct the behaviour of exchange declare where the exchange 
already exists

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177288#comment-14177288
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633199 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633199 ]

QPID-6125 : force flush after receiving frame

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177031#comment-14177031
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633177 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633177 ]

QPID-6125 : ensure exchange-ok is sent promptly

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176734#comment-14176734
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1633082 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1633082 ]

QPID-6125 : ignore headers and bodies when the channel is closed

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-10-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175091#comment-14175091
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1632583 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1632583 ]

QPID-6125 : [Java Broker] AMQP 0-8/9/9-1 protocol handler refactoring

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6125) [Java] Refactor AMQP 0-8/0-9/0-9-1 Support

2014-09-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151107#comment-14151107
 ] 

ASF subversion and git services commented on QPID-6125:
---

Commit 1628068 from [~godfrer] in branch 
'qpid/branches/QPID-6125-ProtocolRefactoring'
[ https://svn.apache.org/r1628068 ]

QPID-6125 : create branch for refactoring work

> [Java] Refactor AMQP 0-8/0-9/0-9-1 Support
> --
>
> Key: QPID-6125
> URL: https://issues.apache.org/jira/browse/QPID-6125
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Client, Java Common
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> The current AMQP 0-8/9/9-1 codec and protocol handling classes contain much 
> duplication between the various flavours of AMQP 0-x and also work 
> differently to the other protocols by using a "handler" class for each 
> method, rather than having the method invoked on a connection or session 
> object.
> Now that no more versions extending the 0-8 line can be expected, we can tidy 
> up this code, remove the duplications and migrate to a more common approach 
> of invoking the methods on a connection object 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org