[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211703#comment-15211703 ] ASF subversion and git services commented on QPID-7033: --- Commit 1736560 from [~k-wall] in branch 'java/branches/6.0.x' [ https://svn.apache.org/r1736560 ] QPID-7033: [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed Should have been part of previous commit. Merged with command: svn merge -c 1732452,1732461,1732812^/qpid/java/trunk > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall >Assignee: Alex Rudyy > Fix For: qpid-java-6.0.2, qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211677#comment-15211677 ] ASF subversion and git services commented on QPID-7033: --- Commit 1736551 from [~k-wall] in branch 'java/branches/6.0.x' [ https://svn.apache.org/r1736551 ] QPID-7033: [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed Merged with command: svn merge -c 1732184,1732452,1732461,1732812^/qpid/java/trunk > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall >Assignee: Alex Rudyy > Fix For: qpid-java-6.0.2, qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171223#comment-15171223 ] ASF subversion and git services commented on QPID-7033: --- Commit 1732812 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1732812 ] QPID-7033: CPPExcludes - exclude ProtocolNegotiationTest.testNoConnectionOpenSent_BrokerClosesConnection, CPP broker does not timeout connections in the same way as the Java one. > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall >Assignee: Alex Rudyy > Fix For: qpid-java-6.0.2, qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169169#comment-15169169 ] Alex Rudyy commented on QPID-7033: -- The changes look good. We should port them into 6.0.x branch > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall > Fix For: qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168876#comment-15168876 ] ASF subversion and git services commented on QPID-7033: --- Commit 1732461 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1732461 ] QPID-7033: [Java Broker] Refactored to use a listener rather than special casing SlowConnectionOpenTicker and avoided the zeroing scheduledTime during doWork algorithm. * Should have been part of commit 1732452 > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall > Fix For: qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168815#comment-15168815 ] ASF subversion and git services commented on QPID-7033: --- Commit 1732452 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1732452 ] QPID-7033: [Java Broker] Refactored to use a listener rather than special casing SlowConnectionOpenTicker and avoided the zeroing scheduledTime during doWork algorithm. > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall > Fix For: qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[ https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163284#comment-15163284 ] ASF subversion and git services commented on QPID-7033: --- Commit 1732184 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1732184 ] QPID-7033: [Java Broker] Change IO tickers use scheduled time when considering if it is time to 'tick' > [Java Broker] Busy IO thread pools may cause client connections to be > unfairly closed > - > > Key: QPID-7033 > URL: https://issues.apache.org/jira/browse/QPID-7033 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.0.1 >Reporter: Keith Wall > Fix For: qpid-java-6.1 > > Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch > > > The Broker installs connection tickers to guard against a new connection that > sends no bytes or sends bytes too slowly. If the ticker expires, the > connection is closed with a {{CON-1003 : Closed due to inactivity}} message. > However, currently a side effect of the Selector Thread's algorithm will mean > that a connection that whilst ready for read but cannot be scheduled on an IO > Pool sufficiently quickly enough will also be closed. This is unfair. > This problem will mean that establishing connections to a busy broker may be > unreliable. Also a retry effect on the client may exacerbate the situation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org