[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-04-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232040#comment-15232040
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1738232 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1738232 ]

QPID-7156: [Java Broker] Fix racey test 
BrokerClosesClientConnectionTest#testClientCloseOnVirtualHostStop

svn merge -c 1738231 ^/qpid/java/trunk

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-04-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232037#comment-15232037
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1738231 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1738231 ]

QPID-7156: [Java Broker] Fix racey test 
BrokerClosesClientConnectionTest#testClientCloseOnVirtualHostStop

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213969#comment-15213969
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1736843 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1736843 ]

QPID-7156: Exclude new test from CPP Profile

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213922#comment-15213922
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1736838 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1736838 ]

QPID-7156: Exclude new test from CPP Profile

Correct typo in excluded name in rev. 1736751

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213460#comment-15213460
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1736751 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1736751 ]

QPID-7156: Exclude new test from CPP Profile

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211780#comment-15211780
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1736566 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1736566 ]

QPID-7156: [Java Broker] Stop new connections from being established while 
virtual host is stopping.

Manually backported from trunk:

svn merge -c 1736478   ^/qpid/java/trunk

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210646#comment-15210646
 ] 

ASF subversion and git services commented on QPID-7156:
---

Commit 1736478 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1736478 ]

QPID-7156: [Java Broker] Stop new connections from being established while 
virtual host is stopping.

Work by Lorenz Quack and me

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping

2016-03-20 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203539#comment-15203539
 ] 

Keith Wall commented on QPID-7156:
--


I think {{AbstractVirtualHost#registerConnectionAsync()}} needs to ensure the 
state of virtualhost is ACTIVE before registering the connection/assigning the 
new scheduler.  If the virtualhost is already in an non-ACTIVE state, the 
method should close the connection (closeAsync) and return its future.  This is 
thread safe because all model operations on the virtualhost (including the 
registering of connections and the stopping of the virtualhost) take place on 
the single vhost executor thread. We need a supporting system test too.

> Possible Java Broker crash if connection is formed whilst virtualhost is 
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is 
> stopped as a new connection is formed.   In the unlucky case, the task to 
> associate the connection with the virtualhost gets executed after the virtual 
> host's network connection scheduler is shutdown.  This leads to a NPE. The 
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) - 
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
>  ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463) 
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org