[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-11-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628459#comment-15628459
 ] 

ASF subversion and git services commented on QPID-7469:
---

Commit 1767625 from [~godfrer] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767625 ]

QPID-7469 : Merged from trunk with command svn merge -c 176,1767514 
^/qpid/java/trunk .

> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>Assignee: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-11-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625831#comment-15625831
 ] 

ASF subversion and git services commented on QPID-7469:
---

Commit 1767514 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r1767514 ]

QPID-7469 : fix regex

> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>Assignee: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-11-01 Thread Lorenz Quack (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625684#comment-15625684
 ] 

Lorenz Quack commented on QPID-7469:


* The regexp in {{AbstractVirtualHost#publishMessage:746}} is missing the a 
{{.*}} at the end.
* Do we want to add tests for this?

The rest looks good to me. 

> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>Assignee: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-10-28 Thread Keith Wall (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615029#comment-15615029
 ] 

Keith Wall commented on QPID-7469:
--

For inclusion in 6.1

> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>Assignee: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608208#comment-15608208
 ] 

ASF subversion and git services commented on QPID-7469:
---

Commit 176 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r176 ]

QPID-7469 : Add content transfer encoding to managable message, validate this 
and mime type

> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7469) [Java Broker] Improve VirtualHost#publishMessage

2016-10-26 Thread Alex Rudyy (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607970#comment-15607970
 ] 

Alex Rudyy commented on QPID-7469:
--

We need to add field  ContentTransferEncoding into ManagableMessage to indicate 
whether message body is base64-encoded or not.
ContentTransferEncoding can be set to the following values:
base64 - body is encoded with base64
identity - body is not encoded; no transformation is needed. Default.

ContentTransferEncoding is case insensitive.

Depending from ContentTransferEncoding  and MimeType the following should 
happen:

Mime type make sense only when json body is a string.

* If mime type is set and body is not a string we should reject the message.
* If json body is a string:
** when transfer encoding is not set and mime type is not text/* then reject 
the message
*** if charset is in mime type we need to reject the message
** if transfer encoding is base64 we base64 decode, otherwise treat is as string

Note, we can get byte array via amqp management


> [Java Broker] Improve VirtualHost#publishMessage
> 
>
> Key: QPID-7469
> URL: https://issues.apache.org/jira/browse/QPID-7469
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: qpid-java-6.1
>Reporter: Lorenz Quack
>
> * When the POST request to VirtualHost#publishMessage does not contain a body 
> there is a ServerError
> * When the mimeType is set the message content is always interpreted as 
> base64.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org