[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194684#comment-16194684 ] ASF subversion and git services commented on QPID-7531: --- Commit 826ff456c9bd48c37a01935d81b1b719f4cd27d1 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=826ff45 ] QPID-7531: [Java Broker, AMQP 1.0] Remove or update TODOs > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194386#comment-16194386 ] ASF subversion and git services commented on QPID-7531: --- Commit 37b1a71aef67ef9043e64ea6766020fd47943112 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=37b1a71 ] QPID-7531: [Java Broker, AMQP 1.0] Improve error message > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193484#comment-16193484 ] ASF subversion and git services commented on QPID-7531: --- Commit 634eb6a90f221eced9e3ff971846a574de8f87ad in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=634eb6a ] QPID-7531: [Java Broker] Add more transaction tests to AMQP 1.0 protocol tests > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193481#comment-16193481 ] ASF subversion and git services commented on QPID-7531: --- Commit 876ddd6dd04246a0a2605ef709081f44d42661d1 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=876ddd6 ] QPID-7531: [Java Broker, AMQP 1.0] Improve error handling when receiving unknown a transaction-id. > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193485#comment-16193485 ] ASF subversion and git services commented on QPID-7531: --- Commit 6a7633d0ba1361a69f8249fffb72a23d8ceb7fc0 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=6a7633d ] QPID-7531: [Java Broker, AMQP 1.0] Allow receiving of Transfers on semi-detached links but end the session if link is errored > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193483#comment-16193483 ] ASF subversion and git services commented on QPID-7531: --- Commit a963d54d1df8e0a8de0b0b6e7189e56ebe5fd32a in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a963d54 ] QPID-7531: [Java Broker] add JIRA references to TODOs > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193488#comment-16193488 ] ASF subversion and git services commented on QPID-7531: --- Commit 016279faac0cd0feb2a1208b3ae2bf6d5edadcfb in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=016279f ] QPID-7531: [Java Broker, AMQP 1.0] Improve links recovering > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193486#comment-16193486 ] ASF subversion and git services commented on QPID-7531: --- Commit c1dabe6810300e57824148a5a28e4eca1702907c in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c1dabe6 ] QPID-7531: [Java Broker, AMQP 1.0] Improve reported error conditions > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193489#comment-16193489 ] ASF subversion and git services commented on QPID-7531: --- Commit 2736b3b7d5faed6ea51b8e08e650ca40162e3072 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=2736b3b ] QPID-7531: [Java Broker, AMQP 1.0] Ensure consumer target is closed on detaching of sending link endpoint > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193490#comment-16193490 ] ASF subversion and git services commented on QPID-7531: --- Commit fb93bae6368dffce01b6e0261617c9b3ce6c48fe in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=fb93bae ] QPID-7531: [Java Broker, AMQP 1.0] Improve reporting of error condition on link attachments > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184181#comment-16184181 ] ASF subversion and git services commented on QPID-7531: --- Commit 2632d13e9888facfa619c75c754801ea1556ec23 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=2632d13 ] QPID-7531: [Java Broker, AMQP 1.0] Fix detection of GZIP compression in Message Conversion for AMQP 1.0 > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184184#comment-16184184 ] ASF subversion and git services commented on QPID-7531: --- Commit 1b60342670f158e1d9e2c8350934f47184d9c99e in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=1b60342 ] QPID-7531: [Java Broker, AMQP 1.0] Defensive guard against NPE > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184178#comment-16184178 ] ASF subversion and git services commented on QPID-7531: --- Commit 16caf69050feb337e8d42b014fc1d85d9c735f5b in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=16caf69 ] QPID-7531: [Java Broker, AMQP 1.0] Prevent possible NullPointerException in dynamic source creation > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184183#comment-16184183 ] ASF subversion and git services commented on QPID-7531: --- Commit a352423fa50aa59e34d9c5c551dbd8261b0e1135 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a352423 ] QPID-7531: [Java Broker, AMQP 1.0] Tidy up imports and redundant type declarations > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184182#comment-16184182 ] ASF subversion and git services commented on QPID-7531: --- Commit d84509a0d4182c4264c987ab62f7dfea874a9aa9 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=d84509a ] QPID-7531: [Java Broker, AMQP 1.0] Fix String format arguments in error message. > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184177#comment-16184177 ] ASF subversion and git services commented on QPID-7531: --- Commit 56cf7b8a90cd6f6c6a13b27c52c721abf5578419 in qpid-broker-j's branch refs/heads/master from [~lorenz.quack] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=56cf7b8 ] QPID-7531: [Java Broker, AMQP 1.0] Refactor LazyConstructors in various DescribedTypeConstructors > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code. This must > include improvements to the performative constructors that currently swallow > incorrectly composed performative (i.e. they swallow ClassCastExceptions). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068076#comment-16068076 ] ASF subversion and git services commented on QPID-7531: --- Commit 498ba2cfb3db9b3cdaca17d34cf80edc8cd0d588 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=498ba2c ] QPID-7531: Remove unused payload for AMQP 1.0 performatives > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842797#comment-15842797 ] ASF subversion and git services commented on QPID-7531: --- Commit 1780552 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1780552 ] QPID-7531: [AMQP1.0] If there are no free channels, don't register the session > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-7.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798879#comment-15798879 ] Keith Wall commented on QPID-7531: -- There are approximately 250 TODOs in the AMQP 1.0 protocol module. Many are related to error handling within the described type constructors (unexpected values, class cast exceptions etc). Others relate to the handling of unexpected states. > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-7.0 > > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781231#comment-15781231 ] ASF subversion and git services commented on QPID-7531: --- Commit 1776190 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1776190 ] QPID-7531: [Java Broker] [AMQP 1.0] Prevent possibility of NPE during peer initiated connection close > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7531) [Java Broker] Tidy up AMQP 1.0 implementation
[ https://issues.apache.org/jira/browse/QPID-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679525#comment-15679525 ] ASF subversion and git services commented on QPID-7531: --- Commit 1770505 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1770505 ] QPID-7531 : Improve AMQP 1.0 implementation > [Java Broker] Tidy up AMQP 1.0 implementation > - > > Key: QPID-7531 > URL: https://issues.apache.org/jira/browse/QPID-7531 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey > > The initial implementation of AMQP 1.0 in the broker came about through > importing initial prototyping code used in the creation of the protocol > standard and grafting it into the broker code. > Since this is now the only place the libraries are used we can tidy up the > joins between the initial AMQP implementation and the broker. We should also > look to remove (implement) TODOs and generally improve the code -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
