[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943091#comment-15943091 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788903 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788903 ] QPID-7622: Rename broker parent pom into 'qpid-broker-parent' > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943090#comment-15943090 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788902 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788902 ] QPID-7622: Remove script qpid-jaddr > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943089#comment-15943089 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788901 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788901 ] QPID-7622: Move AMQPFilterTypes into package 'org.apache.qpid.server.filter' and tidy up imports > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943088#comment-15943088 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788900 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788900 ] QPID-7622: Tidy up 0-10 after separation > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943087#comment-15943087 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788899 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788899 ] QPID-7622: Remove .*Super.* methods introduced by 0-10 separation work > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943083#comment-15943083 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788898 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1788898 ] QPID-7622: Remove empty folders > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940616#comment-15940616 ] Alex Rudyy commented on QPID-7622: -- Keith, I reviewed commits made as part of this JIRA and here are my review comments: * Broker code comments ** I think it make sense to remove {{org.apache.qpid.messaging.util.JAddr}}, some of the classes {{JAddr}} depends on like {{PyPrint}}, and bash script {{qpid-jaddr}}. Nobody really using this and it looks to me that it was added for testing purposes to test ADDRESS syntax parsing. ** Redundant import of {{org.apache.qpid.server.bytebuffer.ByteBufferRef}} in {{NonPooledByteBufferRef}} ** Redundant import of {{org.apache.qpid.server.bytebuffer.QpidByteBuffer}} in {{QpidByteBufferOutputStream}} ** It looks like {{org.apache.qpid.server.common.AMQPFilterTypes}} belongs to package {{org.apache.qpid.server.filter}} ** Unsused constant {{org.apache.qpid.server.common.ServerPropertyNames#QPID_TEMPORARY_QUEUE_PREFIX}}. The constant can be removed. The remaining constants in {{ServerPropertyNames}} can be moved into {{CommonProperties}} and {{ServerPropertyNames}} class can be removed. Constants from {{ConnectionStartProperties}} can be moved into {{CommonProperties}} as well. If {{ServerPropertyNames}} and {{ConnectionStartProperties}} are merged into {{CommonProperties}} packages {{org.apache.qpid.server.common}} and {{org.apache.qpid.server.properties}} can be removed. Potentially {{CommonProperties}} can be renamed into {{BrokerPropertyNames}}. ** Redundant import of {{import java.util.Iterator}} in {{ServerInputHandler}} ** {{ServerConnection}} *** {{org.apache.qpid.server.protocol.v0_10.ServerConnection#resume}} is not used. *** {{org.apache.qpid.server.protocol.v0_10.ServerConnection#getLocalAddress}} is not used. *** {{org.apache.qpid.server.protocol.v0_10.ServerConnection#_port}} field is redundant. Port can be taken from {{AMQPConnection_0_10#getPort()}}. *** {{org.apache.qpid.server.protocol.v0_10.ServerConnection#getRemoteContainerName}} can be deleted as it is only called from {{AMQPConnection_0_10Impl#getRemoteContainerName}} and {{AMQPConnection_0_10Impl}} already has it set as clientId. Thus {{this.getClinetId()}} can be called instead. *** Redundunt casts to {{ServerConnectionDelegate}} and {{ServerSession}} in multiple places. *** Synchronization on {{#lock}} looks redundant to me. Should we remove it and make member variables volatile and replace such multi-thread unsafe classes like {{HashMap}} with {{ConcurrentHashMap}}? *** Intrinsic lock synchronization in method {{#registerSession}} also looks reduntant. *** Intrinsic lock synchronization in methods {{#block}} and {{#unblock}} look unnecessary, as a caller {{AbstractVirtualHost}} synchronizes on its own {{#_connections}} field in methods {{AbstractVirtualHost#block}} and {{AbstractVirtualHost#unblock}} but we might need to modify {{AbstractVirtualHost#registerConnectionAsync}} to synchronize on {{#_connections}} as well when connection is registered. ** {{ServerConnectionDelegate}} *** org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#writerIdle is not used *** org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#getClientProperties is not used. *** org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#getClientVersion is not used. *** org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#getClientProduct is not used. *** org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#getRemoteProcessPid is not used. *** Invocation of org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate#getClientId can be deleted. Only ServerConnection calls it in ServerConnection#getRemoteContainerName() but the latter is not required. See comments above. *** A lot of redundant casts to ServerConnection. *** @Override annotation is missed on methods #control, #command, #error, #handle, connectionOpen. *** It seems ServerConnectionDelegate does not bring much but makes code more convoluted. Would it make sense to merge ServerConnectionDelegate into ServerConnection? If not, i would move implementations of methods connectionOpen, connectionClose, etc into ServerConnection and make delegate simply call corresponding ServerConnection methods. IMHO, that would make code more cleaner. The cyclic dependencies between these 2 classes look weird. ** {{AMQPConnection_0_10Impl}} *** org.apache.qpid.server.protocol.v0_10.AMQPConnection_0_10Impl#getRemoteContainerName can call internally getClientId instead of calling ServerConnection#getRemoteContainerName() as both return the same value as they set from "clientName" connectionStart property. Method ServerConnection#getRemoteContainerName() can be deleted. ** {{SessionListenr}} *** {{org.apache.qpid.server.protocol.v0_10.SessionListener}}/{{ServerSession$Defaul
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936122#comment-15936122 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788092 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1788092 ] QPID-7622: Remove accidentally committed velocity.timestamp > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934958#comment-15934958 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788012 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1788012 ] QPID-7622: [0-10] Fix method ordering in ServerConnectionDelegate/ServerSession. No functional change. > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934941#comment-15934941 ] ASF subversion and git services commented on QPID-7622: --- Commit 1788011 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1788011 ] QPID-7622: [Java System Tests] Tidy up AMQException assertions after broker/client separation > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902112#comment-15902112 ] ASF subversion and git services commented on QPID-7622: --- Commit 1786087 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1786087 ] QPID-7622: [Java Broker] [0-8] Move binding url parser classes to the 0-8 plugin module > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902111#comment-15902111 ] ASF subversion and git services commented on QPID-7622: --- Commit 1786086 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1786086 ] QPID-7622: [Java Broker] [0-10] Move 0-10 protocol classes to the 0-10 plugin module > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-client-0-x-6.3.0, qpid-java-broker-7.0.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888612#comment-15888612 ] Keith Wall commented on QPID-7622: -- Current state Client: # The refactoring of QPID-7532 introduce an API change in AMQException. Some tests in the systests module make assertions about the error code. The API change required an ugly workaround (AbstractACLTestCase#assertAMQException) so they remain compatible with both qpid-client-6.1.1 and qpid-client-6.3.0-SNAPSHOT. To keep things simple, we might consider rolling back the client changes so that compatibility is maintained. # AmqpManagementTest don't run with the qpid-client-6.1.1. There is currently an ugly version based exclusion in the test. I suspect the client changes made by QPID-7533 were required to allow the client to process the special management addresses. * Eliminate module qpid-jms-amqp-0-x-test-utils * Transport code generation * LICENSE/README updates Broker: * The AMQP 1.0 protocol layer uses BBDecoder (0-10) and TypedBytesContentReader (0-8) * Move 0-10 protocol code from broker-core => 0-10 plugin. * LICENSE/README updates * Transport code generation > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881072#comment-15881072 ] ASF subversion and git services commented on QPID-7622: --- Commit 1784197 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1784197 ] QPID-7622: [Java Broker] [0-10] Move 0-10 protocol and associated classes to v0_10 specific package > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875441#comment-15875441 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783835 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783835 ] QPID-7622: [Java Broker] [0-8..0-91] Move most 0-8..0-91 protocol specific classes into protocol plugin > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875438#comment-15875438 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783832 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783832 ] QPID-7622: [Java Broker] [0-10] Remove dead waiter and client failover hooks from ServerSession > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875439#comment-15875439 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783833 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783833 ] QPID-7622: [Java Broker] [0-10] Remove dead waiter code from ServerConnection > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871384#comment-15871384 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783342 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783342 ] QPID-7622: [Java Broker] [0-10] Collasped ServerConnection, SessionSession etc using inline refactoring Methods in the base classes that were overridden and invoked using super.method() are renamed methodSuper() > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870172#comment-15870172 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783242 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783242 ] QPID-7622: [Java Broker] [0-10] Remove redundant overrides and unused methods > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870171#comment-15870171 ] ASF subversion and git services commented on QPID-7622: --- Commit 1783241 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1783241 ] QPID-7622: [Java Broker] [0-10] Move Connection, Session and associated classes to 0-10 plugin > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867487#comment-15867487 ] Keith Wall commented on QPID-7622: -- The following commits were intended for this JIRA: Commit 1782442 from Keith Wall in branch 'java/trunk' [ https://svn.apache.org/r1782442 ] QPID-7603: [Java Broker] Use Maven dependencyManagement to properly control dependency versions even when POM nesting is deep jira-bot ASF subversion and git services added a comment - 2 days ago Commit 1782895 from Keith Wall in branch 'java/trunk' [ https://svn.apache.org/r1782895 ] QPID-7603: [Java Broker] Remove client transport, client threading, and configuration/properties jira-bot ASF subversion and git services added a comment - 2 days ago Commit 1782896 from Keith Wall in branch 'java/trunk' [ https://svn.apache.org/r1782896 ] QPID-7603: Skip AmqpManagementTest tests properly when run with pre 6.3.x Qpid JMS Client 0-x > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857830#comment-15857830 ] Keith Wall commented on QPID-7622: -- Outstanding items - this list is not complete. Client * The refactoring of QPID-7532 introduce an API change in AMQException. Some tests in the systests module make assertions about the error code. The API change required an ugly workaround (AbstractACLTestCase#assertAMQException) so they remain compatible with both qpid-client-6.1.1 and qpid-client-6.3.0-SNAPSHOT. * AmqpManagementTest don't run with the qpid-client-6.1.1. There is currently an ugly version based exclusion in the test. I suspect the client changes made by QPID-7533 were required to allow the client to process the special management addresses. Broker: * Client transport stack needs to be removed. * Client SASL related classes * 0-10 Connection pulls in many client classes such as ClientProperties. Connection will need to be refactored so that its old 'client' responsibilities are removed. * Would like to move the 0-8/0-10 protocol classes from broker-core to the appropriate plugins. The following stands in the way ** DTX registry and friends are currently in terms of 0-10 protocol objects ** The AMQP 1.0 protocol layer uses BBDecoder (0-10) and TypedBytesContentReader (0-8) > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856657#comment-15856657 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782067 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1782067 ] QPID-7622: Correct test dependency in JCA module > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856641#comment-15856641 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782062 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1782062 ] QPID-7622: Move client version from 7.0.0-SNAPSHOT to 6.3.0-SNAPSHOT > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856597#comment-15856597 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782057 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1782057 ] QPID-7622: Correct maven parentage of the example module, fix generation of docbook > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856587#comment-15856587 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782055 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1782055 ] QPID-7622: Correct maven parentage of the JCA modules > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856551#comment-15856551 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782053 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1782053 ] QPID-7622: Forgot the new client parent POM > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856510#comment-15856510 ] ASF subversion and git services commented on QPID-7622: --- Commit 1782048 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1782048 ] QPID-7622: [Java Broker/0-x JMS Client] Separate Broker / Client; eliminate common For this initial commit: * new root for 0-x client established qpid-jms-amqp-0-x with new parent POM * client, jca and docs svn moved to qpid-jms-amqp-0-x * common code svn copied to qpid-jms-amqp-0-x (package unchanged) * common coded svn moved to broker-core (package refactored to o.a.q.server.*) * POMs manually fixed up * No elimination of client-only code from broker yet , or vice versa > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853273#comment-15853273 ] ASF subversion and git services commented on QPID-7622: --- Commit 1781783 from [~k-wall] in branch 'x/trunk' [ https://svn.apache.org/r1781783 ] QPID-7622: [Qpid JMS 0-x Client] New empty subversion home for the 0-x client > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code > used by many modules such as BindingURL whose copy shall live in broker-core. > * Code that the 0-x client requires will be copied into the client module. > The package names will be unchanged. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. > The structure of trunk qpid-jms-0-x will look like: > - qpid-jms-0-x > + client >+ example > + jaa > + example > + ra > + docs > + jms-client-0-10 > + jms-client-0-8 > There will need to be a new parent POM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7622) Separate Qpid Broker for Java and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837725#comment-15837725 ] Keith Wall commented on QPID-7622: -- We need to remember qpidversion.properties. Both Broker and Client both load this file from the classpath. At very least we need to ensure that they reference unique resources. > Separate Qpid Broker for Java and 0-x JMS Client in source tree > --- > > Key: QPID-7622 > URL: https://issues.apache.org/jira/browse/QPID-7622 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Reporter: Keith Wall > Fix For: qpid-java-7.0 > > > As discussed here: > http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html > The proposal is to move the code and documentation that comprises the 0-x > client to its own SVN root: > https://svn.apache.org/repos/asf/qpid/qpid-jms-amqp-0-x > The Java Broker and integration tests suites will remain at: > https://svn.apache.org/repos/asf/qpid/qpid-java > Maven dependencies will be used to pull in the appropriate 0-x client for > integration testing purposes (as we already do with the Qpid JMS Client). > The {{qpid-common}} module (and maven release artefact) will be eliminated. > * Classes that the Broker requires will be moved into the class hierarchy of > the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} > e.g. {{org/apache/qpid/server/protocol/vx_y}}.* > * Code that the 0-x client requires will be moved into the class hierarchy of > the client {{org/apache/qpid/client}}. > This will allow the Broker and 0-x Client to co-exist in the same JVM without > class loading collision. Class movements will be organised in such a way to > preserve SVN history. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org