[jira] [Commented] (QPID-7629) Use CMake "SYSTEM" keyword when including headers
[ https://issues.apache.org/jira/browse/QPID-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938232#comment-15938232 ] Justin Ross commented on QPID-7629: --- [~chris.richardson], I talked to Andrew, and we agreed to restore this change. > Use CMake "SYSTEM" keyword when including headers > - > > Key: QPID-7629 > URL: https://issues.apache.org/jira/browse/QPID-7629 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Affects Versions: qpid-cpp-1.36.0 >Reporter: Chris Richardson >Assignee: Justin Ross > Labels: patch > Fix For: qpid-cpp-1.37.0 > > Attachments: 1.36.0-system-includes.patch > > > See attached patch which applies this change to the NSS and SASL include > directories. The patch does not affect the included headers from perl, > python, ruby, boost or qpid-proton since it is probably not necessary to > consider those dependencies. > This change would prevent -Werror being applied to code in header files > included from dependent libraries, which can cause failures such as: > [ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o > In file included from /usr/include/nss/ssl.h:18:0, > from > /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30: > /usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list > [-Werror=pedantic] > ssl_sig_rsa_pkcs1_sha1md5 = 0x10101, > ^ > cc1plus: all warnings being treated as errors -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7629) Use CMake "SYSTEM" keyword when including headers
[ https://issues.apache.org/jira/browse/QPID-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938227#comment-15938227 ] ASF subversion and git services commented on QPID-7629: --- Commit f04bc169f11c99be50399341905186b3405a3130 in qpid-cpp's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=f04bc16 ] QPID-7629: Use the CMake SYSTEM keyword when including headers for nss and sasl > Use CMake "SYSTEM" keyword when including headers > - > > Key: QPID-7629 > URL: https://issues.apache.org/jira/browse/QPID-7629 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Affects Versions: qpid-cpp-1.36.0 >Reporter: Chris Richardson >Assignee: Justin Ross > Labels: patch > Fix For: qpid-cpp-1.38.0 > > Attachments: 1.36.0-system-includes.patch > > > See attached patch which applies this change to the NSS and SASL include > directories. The patch does not affect the included headers from perl, > python, ruby, boost or qpid-proton since it is probably not necessary to > consider those dependencies. > This change would prevent -Werror being applied to code in header files > included from dependent libraries, which can cause failures such as: > [ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o > In file included from /usr/include/nss/ssl.h:18:0, > from > /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30: > /usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list > [-Werror=pedantic] > ssl_sig_rsa_pkcs1_sha1md5 = 0x10101, > ^ > cc1plus: all warnings being treated as errors -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7629) Use CMake "SYSTEM" keyword when including headers
[ https://issues.apache.org/jira/browse/QPID-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936224#comment-15936224 ] ASF subversion and git services commented on QPID-7629: --- Commit 93dfd397bcf2cdf425a162d93c0c4a09b0ba5522 in qpid-cpp's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=93dfd39 ] QPID-7629: Revert the use of SYSTEM for now; there is a concern that it will impact portability > Use CMake "SYSTEM" keyword when including headers > - > > Key: QPID-7629 > URL: https://issues.apache.org/jira/browse/QPID-7629 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Affects Versions: qpid-cpp-1.36.0 >Reporter: Chris Richardson >Assignee: Justin Ross > Labels: patch > Fix For: qpid-cpp-1.37.0 > > Attachments: 1.36.0-system-includes.patch > > > See attached patch which applies this change to the NSS and SASL include > directories. The patch does not affect the included headers from perl, > python, ruby, boost or qpid-proton since it is probably not necessary to > consider those dependencies. > This change would prevent -Werror being applied to code in header files > included from dependent libraries, which can cause failures such as: > [ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o > In file included from /usr/include/nss/ssl.h:18:0, > from > /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30: > /usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list > [-Werror=pedantic] > ssl_sig_rsa_pkcs1_sha1md5 = 0x10101, > ^ > cc1plus: all warnings being treated as errors -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7629) Use CMake "SYSTEM" keyword when including headers
[ https://issues.apache.org/jira/browse/QPID-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906227#comment-15906227 ] ASF subversion and git services commented on QPID-7629: --- Commit 2ee9f79ed9371a7858e150c96a87fe051782afa7 in qpid-cpp's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=2ee9f79 ] QPID-7629: Update build metadata for compiler and library changes - Use CMake "SYSTEM" keyword when including headers for nss and sasl - Set C++ standard for gcc to gnu++03 to avoid the torrent of auto_ptr warnings on recend fedoras Thanks to Chris Richardson for the patch! > Use CMake "SYSTEM" keyword when including headers > - > > Key: QPID-7629 > URL: https://issues.apache.org/jira/browse/QPID-7629 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Affects Versions: qpid-cpp-1.36.0 >Reporter: Chris Richardson >Assignee: Justin Ross > Fix For: qpid-cpp-1.37.0 > > Attachments: 1.36.0-system-includes.patch > > > See attached patch which applies this change to the NSS and SASL include > directories. The patch does not affect the included headers from perl, > python, ruby, boost or qpid-proton since it is probably not necessary to > consider those dependencies. > This change would prevent -Werror being applied to code in header files > included from dependent libraries, which can cause failures such as: > [ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o > In file included from /usr/include/nss/ssl.h:18:0, > from > /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30: > /usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list > [-Werror=pedantic] > ssl_sig_rsa_pkcs1_sha1md5 = 0x10101, > ^ > cc1plus: all warnings being treated as errors -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
