[jira] [Commented] (QPID-8186) Incorrect exception handling fails to build on GCC 8
[
https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996594#comment-16996594
]
ASF GitHub Bot commented on QPID-8186:
--
chrisrichardson77 commented on pull request #14: QPID-8186 Use const ref when
catching exceptions
URL: https://github.com/apache/qpid-cpp/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect exception handling fails to build on GCC 8
>
>
> Key: QPID-8186
> URL: https://issues.apache.org/jira/browse/QPID-8186
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object
> src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
> In member function ‘bool qpid::sys::SocketAddress::isComparable(const
> qpid::sys::SocketAddress&) const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
>
>
> these "catch (Exception)" statements would better be const ref, which would
> also fix the build failure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8186) Incorrect exception handling fails to build on GCC 8
[
https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658400#comment-16658400
]
ASF GitHub Bot commented on QPID-8186:
--
Github user ssorj commented on the issue:
https://github.com/apache/qpid-cpp/pull/14
Commited at
https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895
> Incorrect exception handling fails to build on GCC 8
>
>
> Key: QPID-8186
> URL: https://issues.apache.org/jira/browse/QPID-8186
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Assignee: Justin Ross
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object
> src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
> In member function ‘bool qpid::sys::SocketAddress::isComparable(const
> qpid::sys::SocketAddress&) const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
>
>
> these "catch (Exception)" statements would better be const ref, which would
> also fix the build failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8186) Incorrect exception handling fails to build on GCC 8
[
https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473539#comment-16473539
]
ASF subversion and git services commented on QPID-8186:
---
Commit 8b09d246f2529ea59809cac743e55af3920b4895 in qpid-cpp's branch
refs/heads/master from [~chris.richardson]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=8b09d24 ]
QPID-8186 Use const ref when catching exceptions
> Incorrect exception handling fails to build on GCC 8
>
>
> Key: QPID-8186
> URL: https://issues.apache.org/jira/browse/QPID-8186
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object
> src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
> In member function ‘bool qpid::sys::SocketAddress::isComparable(const
> qpid::sys::SocketAddress&) const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
>
>
> these "catch (Exception)" statements would better be const ref, which would
> also fix the build failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8186) Incorrect exception handling fails to build on GCC 8
[
https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470330#comment-16470330
]
ASF GitHub Bot commented on QPID-8186:
--
GitHub user chrisrichardson77 opened a pull request:
https://github.com/apache/qpid-cpp/pull/14
QPID-8186 Use const ref when catching exceptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fourceu/qpid-cpp QPID-8186
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-cpp/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
commit 53e456c7f88a37e392649ebd0230b182a0879c6e
Author: Chris Richardson
Date: 2018-05-10T09:45:42Z
QPID-8186 Use const ref when catching exceptions
> Incorrect exception handling fails to build on GCC 8
>
>
> Key: QPID-8186
> URL: https://issues.apache.org/jira/browse/QPID-8186
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
>Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
>Reporter: Chris Richardson
>Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object
> src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
> In member function ‘bool qpid::sys::SocketAddress::isComparable(const
> qpid::sys::SocketAddress&) const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^
>
>
> these "catch (Exception)" statements would better be const ref, which would
> also fix the build failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
