[jira] [Commented] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-19 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620556#comment-16620556
 ] 

ASF subversion and git services commented on QPID-8231:
---

Commit 3cc87eedbf2debe16d58dcd1157fd647f398afb3 in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3cc87ee ]

QPID-8231: [Broker-J] Do not allow setting empty string as value of queue 
attributes 'messageGroupKeyOverride' and 'messageGroupDefaultGroup'

(cherry picked from commit cad240e1b4f6fad50d9d24eb49691f84601977b5)


> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
>

[jira] [Commented] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-10 Thread Keith Wall (JIRA) 


[ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609806#comment-16609806
 ] 

Keith Wall commented on QPID-8231:
--

Looks reasonable to me.

> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249)
>   at java.security.AccessController.doPrivileged(Native Method)
>

[jira] [Commented] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-09 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608597#comment-16608597
 ] 

ASF subversion and git services commented on QPID-8231:
---

Commit cad240e1b4f6fad50d9d24eb49691f84601977b5 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cad240e ]

QPID-8231: [Broker-J] Do not allow setting empty string as value of queue 
attributes 'messageGroupKeyOverride' and 'messageGroupDefaultGroup'


> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
>