[jira] [Commented] (QPIDIT-61) Condense common code from the Python tests into a test module.
[ https://issues.apache.org/jira/browse/QPIDIT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382331#comment-16382331 ] ASF subversion and git services commented on QPIDIT-61: --- Commit 4b1c194aaa0053025943b01a117bbd87319796e6 in qpid-interop-test's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-interop-test.git;h=4b1c194 ] QPIDIT-61: This is more of a renaming of modules so that all common libs have a name starting with qit_. This makes it easier to see the common lib modules in a file list. > Condense common code from the Python tests into a test module. > -- > > Key: QPIDIT-61 > URL: https://issues.apache.org/jira/browse/QPIDIT-61 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task > Components: AMQP Large Content Test, AMQP Types Test, JMS Headers > and Properties Test, JMS Message Test >Affects Versions: 0.1.0 >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Minor > Fix For: 0.2.0 > > > Each test was written independently of the others. While this is a quick way > to start, it has not lead to a lot of duplicated code and common patterns. It > would help maintenance and readability of the code if the common bits were > placed into a test library. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-61) Condense common code from the Python tests into a test module.
[ https://issues.apache.org/jira/browse/QPIDIT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366342#comment-16366342 ] ASF subversion and git services commented on QPIDIT-61: --- Commit e20ae3c8b29a0af816d55238beff688c2700d62d in qpid-interop-test's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-interop-test.git;h=e20ae3c ] QPIDIT-61: Fixed error in jms_hdrs_props_test Python Sender shim, which contained an invalid import which was not changed to match the newly refactored modules. > Condense common code from the Python tests into a test module. > -- > > Key: QPIDIT-61 > URL: https://issues.apache.org/jira/browse/QPIDIT-61 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task > Components: AMQP Large Content Test, AMQP Types Test, JMS Headers > and Properties Test, JMS Message Test >Affects Versions: 0.1.0 >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Minor > Fix For: 0.2.0 > > > Each test was written independently of the others. While this is a quick way > to start, it has not lead to a lot of duplicated code and common patterns. It > would help maintenance and readability of the code if the common bits were > placed into a test library. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-61) Condense common code from the Python tests into a test module.
[
https://issues.apache.org/jira/browse/QPIDIT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341274#comment-16341274
]
Kim van der Riet commented on QPIDIT-61:
The above commit did some major refactoring in the (currently) 4 tests. A new
module {{qit_common}} was created, and the following were placed into it which
is common between the test classes:
{{QitTestTypeMap}} which was previously in module test_type_map, is a parent
class for the test values used in a test;
{{QitCommonTestOptions}} contains the command-line options common to all tests;
{{QitTestCase}} contains the abstract parent class for all QIT test cases. It
adds methods which record the time taken for each test case;
{{QitTest}} is the abstract base class for the test itself. It handles common
pre-test tasks such as creating the shim map, creating the argparse object,
modifying the shim map if needed depending on the options selected, and
detecting the broker connection properties to identify the broker.
{{QitJmsTest}} is a specialized version of {{QitTest}} which also sets up a
Java classpath and handles shims which are embedded in a jar.
> Condense common code from the Python tests into a test module.
> --
>
> Key: QPIDIT-61
> URL: https://issues.apache.org/jira/browse/QPIDIT-61
> Project: Apache QPID Interoperability Test Suite
> Issue Type: Task
> Components: AMQP Large Content Test, AMQP Types Test, JMS Headers
> and Properties Test, JMS Message Test
>Affects Versions: 0.1.0
>Reporter: Kim van der Riet
>Assignee: Kim van der Riet
>Priority: Minor
>
> Each test was written independently of the others. While this is a quick way
> to start, it has not lead to a lot of duplicated code and common patterns. It
> would help maintenance and readability of the code if the common bits were
> placed into a test library.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-61) Condense common code from the Python tests into a test module.
[
https://issues.apache.org/jira/browse/QPIDIT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341263#comment-16341263
]
Kim van der Riet commented on QPIDIT-61:
Commit 58a8b9ae47cecfc9cb9370ded292be0bc9ec3ffe in qpid-interop-test's branch
refs/heads/master from [~kpvdr]
[ [https://git-wip-us.apache.org/repos/asf?p=qpid-interop-test.git;h=58a8b9a] ]
QPIDIT-93: Added xUnit logging by using {{--xunit-log}} parameter; Refactoring
of test classes, added {{qpid_interop_test.run_all}} which runs all tests
> Condense common code from the Python tests into a test module.
> --
>
> Key: QPIDIT-61
> URL: https://issues.apache.org/jira/browse/QPIDIT-61
> Project: Apache QPID Interoperability Test Suite
> Issue Type: Task
> Components: AMQP Large Content Test, AMQP Types Test, JMS Headers
> and Properties Test, JMS Message Test
>Affects Versions: 0.1.0
>Reporter: Kim van der Riet
>Assignee: Kim van der Riet
>Priority: Minor
>
> Each test was written independently of the others. While this is a quick way
> to start, it has not lead to a lot of duplicated code and common patterns. It
> would help maintenance and readability of the code if the common bits were
> placed into a test library.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
