[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Status: Ready To Review (was: In Progress) > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch > > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-3569: Attachment: 0001-QPID-3569-Refactor-TransactionTimeout.patch I reviewed all the code changes and it all looks good to me. I'm attaching a modified patch that just adds some missing @Override annotations and fixes minor formatting. I think this patch can be committed. > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Philip Harvey > Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch > > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Attachment: 0001-QPID-3569-Refactor-TransactionTimeout.patch > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch > > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Attachment: 0001-QPID-3569-Refactor-TransactionTimeout.patch > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch, > 0001-QPID-3569-Refactor-TransactionTimeout.patch > > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Attachment: 0001-QPID-3569-Refactor-TransactionTimeout.patch > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch > > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Description: The Transaction Timeout feature of the Java Broker relies heavily on system tests. It would be better if its implementation were refactored to allow more of its functionality to be tested by unit tests and a reduced number of system tests. was: The Transaction Timeout feature of the Java Broker relies heavily on system tests. It would be better if its implementation were refactored to allow more of its functionality to be tested by unit tests and a reduced number of system tests. Another motivation for this change it that TransactionTimeoutTest is still sporadically failing on CI (probably contributing more than 50% of the fails we see on Jenkins) and creates much noise. This change will aim to resolve this problem at the same time. > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-3569) Refactor TransactionTimeout
[ https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3569: - Summary: Refactor TransactionTimeout (was: Refactor TransactionTimeout and avoid sporadic test fails on slower CI hosts) > Refactor TransactionTimeout > --- > > Key: QPID-3569 > URL: https://issues.apache.org/jira/browse/QPID-3569 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > > The Transaction Timeout feature of the Java Broker relies heavily on system > tests. It would be better if its implementation were refactored to allow > more of its functionality to be tested by unit tests and a reduced number of > system tests. > Another motivation for this change it that TransactionTimeoutTest is still > sporadically failing on CI (probably contributing more than 50% of the fails > we see on Jenkins) and creates much noise. This change will aim to resolve > this problem at the same time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
