[jira] Commented: (QPID-1875) Can't create durable queues that use amq.topic due to error in BindingURLParser.
[ https://issues.apache.org/jira/browse/QPID-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797294#action_12797294 ] Rajith Attapattu commented on QPID-1875: Martin I cannot recall who added the option either. We may have to dig through the svn logs. I have provided a fix at rev r779651 on Qpid trunk. > Can't create durable queues that use amq.topic due to error in > BindingURLParser. > > > Key: QPID-1875 > URL: https://issues.apache.org/jira/browse/QPID-1875 > Project: Qpid > Issue Type: Bug > Components: Java Client >Reporter: Rajith Attapattu >Assignee: Rajith Attapattu >Priority: Minor > Fix For: 0.6 > > > In BindingURLParser, process options method, line 420 has the following error > queueName = _bindingURL.getOption(BindingURL.OPTION_CLIENTID + ":" + > BindingURL.OPTION_SUBSCRIPTION); > This results in the queue name being null and the subsequent queue-declare > failing. It should be corrected to the following > queueName = _bindingURL.getOption(BindingURL.OPTION_CLIENTID + ":" + > BindingURL.OPTION_SUBSCRIPTION); > However I am not sure if forcing a particular pattern for the queue name and > treating it as a durable subscription if the exchange is amq.topic and queue > is durable is correct either. This will create confusion as when they tried > to work with this queue using mgt-tools or connect with other non java > clients, it may not be obvious that the queue name was generated in this > case. > The users should have the freedom to define a queue name of their choice. > There is a clear path to create durable subscriptions in the JMS API. So I > don't think we need to force it in the jndi.properties format. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-1875) Can't create durable queues that use amq.topic due to error in BindingURLParser.
[ https://issues.apache.org/jira/browse/QPID-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714012#action_12714012 ] Martin Ritchie commented on QPID-1875: -- Rajith, do you know why this option was added? It wasn't in the original parser for the BindingURL. I think the parser should do just that parse. If there is some meaning to be applied then the AMQBindingURL object should enforce that. > Can't create durable queues that use amq.topic due to error in > BindingURLParser. > > > Key: QPID-1875 > URL: https://issues.apache.org/jira/browse/QPID-1875 > Project: Qpid > Issue Type: Bug > Components: Java Client >Reporter: Rajith Attapattu >Assignee: Rajith Attapattu >Priority: Minor > Fix For: 0.6 > > > In BindingURLParser, process options method, line 420 has the following error > queueName = _bindingURL.getOption(BindingURL.OPTION_CLIENTID + ":" + > BindingURL.OPTION_SUBSCRIPTION); > This results in the queue name being null and the subsequent queue-declare > failing. It should be corrected to the following > queueName = _bindingURL.getOption(BindingURL.OPTION_CLIENTID + ":" + > BindingURL.OPTION_SUBSCRIPTION); > However I am not sure if forcing a particular pattern for the queue name and > treating it as a durable subscription if the exchange is amq.topic and queue > is durable is correct either. This will create confusion as when they tried > to work with this queue using mgt-tools or connect with other non java > clients, it may not be obvious that the queue name was generated in this > case. > The users should have the freedom to define a queue name of their choice. > There is a clear path to create durable subscriptions in the JMS API. So I > don't think we need to force it in the jndi.properties format. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
