[jira] Commented: (QPID-2154) New Network IO Layer has doesn't appear to clean up connections on connection close.

2009-10-27 Thread Aidan Skinner (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770754#action_12770754
 ] 

Aidan Skinner commented on QPID-2154:
-

I can't see any way for the connection to be added twice, I think it's more 
likely that the _virtualHost is null, which I guess is possible, if unlikely. 

It might be better to make this a little less fragile by storing a pointer to 
the connectionRegistry itself in setVirtualHost.

Is this happening regularly, or was it a once off? 

 New Network IO Layer has doesn't appear to clean up connections on connection 
 close.
 

 Key: QPID-2154
 URL: https://issues.apache.org/jira/browse/QPID-2154
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Martin Ritchie
Assignee: Aidan Skinner
 Fix For: 0.6

 Attachments: MessageDisappearTail.txt


 The new AMQProtocolEngine appears does not appear to reliably clear the 
 ConnectionRegistry when closing connections.
 The Missing test run over the weekend genereated 25GB of log which appears to 
 be the Broker stuck in the ConnectionRegistry.close() loop. This would 
 suggest that the new IO layer is not correctly notifying and/or removing the 
 closed connection from the ConnectionRegistry.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Commented: (QPID-2154) New Network IO Layer has doesn't appear to clean up connections on connection close.

2009-10-19 Thread Martin Ritchie (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767281#action_12767281
 ] 

Martin Ritchie commented on QPID-2154:
--

After taking a heap dump. Out of the many(15) virtualhosts that we have 
created! (Something else to address with our InVM testing)
There is only one virtualhost that has eny AMQProtocolEngines. This  Engine is 
marked _closed=true, so wlll never remove from the _registry.
Questions:
 - The only place _closed is set true is AFTER the ConnectionRegistry remove..  
so was it added twice?
 - If it wasn't added twice then why was it not removed.

 New Network IO Layer has doesn't appear to clean up connections on connection 
 close.
 

 Key: QPID-2154
 URL: https://issues.apache.org/jira/browse/QPID-2154
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Martin Ritchie
 Fix For: 0.6

 Attachments: MessageDisappearTail.txt


 The new AMQProtocolEngine appears does not appear to reliably clear the 
 ConnectionRegistry when closing connections.
 The Missing test run over the weekend genereated 25GB of log which appears to 
 be the Broker stuck in the ConnectionRegistry.close() loop. This would 
 suggest that the new IO layer is not correctly notifying and/or removing the 
 closed connection from the ConnectionRegistry.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org