[jira] Updated: (QPID-1530) [JMX Console] AbstractAction handleException always prints throwable stacktrace
[ https://issues.apache.org/jira/browse/QPID-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack updated QPID-1530: --- Fix Version/s: Eclipse MC M5 Affects Version/s: (was: M4) (was: M3) Sscoping items for early 2009 release of Java Eclipse Mgt Console > [JMX Console] AbstractAction handleException always prints throwable > stacktrace > --- > > Key: QPID-1530 > URL: https://issues.apache.org/jira/browse/QPID-1530 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Reporter: Martin Ritchie >Assignee: Aidan Skinner > Fix For: Eclipse MC M5 > > Attachments: QPID-1530_12dec2008.patch > > > Summary: > handleException (AbstractAction:L:77) always prints the stackTrace of the > Throwable that it receives as well as displaying an error dialog to the user. > This behaviour is undesirable for exceptions such as connection failures. > The only stackTraces that should be printed are due to programming failures > such as incorrect handingling of data from the broker. > The IOException thrown from JMXServerRegistry due to a incorrect > username/password, for example, does not need to printed out. The dialog box > to the user is sufficient. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1530) [JMX Console] AbstractAction handleException always prints throwable stacktrace
[ https://issues.apache.org/jira/browse/QPID-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Ritchie updated QPID-1530: - Status: Ready To Review (was: In Progress) > [JMX Console] AbstractAction handleException always prints throwable > stacktrace > --- > > Key: QPID-1530 > URL: https://issues.apache.org/jira/browse/QPID-1530 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Affects Versions: M3, M4 >Reporter: Martin Ritchie >Assignee: Martin Ritchie > Attachments: QPID-1530_12dec2008.patch > > > Summary: > handleException (AbstractAction:L:77) always prints the stackTrace of the > Throwable that it receives as well as displaying an error dialog to the user. > This behaviour is undesirable for exceptions such as connection failures. > The only stackTraces that should be printed are due to programming failures > such as incorrect handingling of data from the broker. > The IOException thrown from JMXServerRegistry due to a incorrect > username/password, for example, does not need to printed out. The dialog box > to the user is sufficient. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1530) [JMX Console] AbstractAction handleException always prints throwable stacktrace
[ https://issues.apache.org/jira/browse/QPID-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1530: - Attachment: QPID-1530_12dec2008.patch I attach QPID-1530_12dec2008.patch which corrects this behaviour by moving the stacktrace printout to the end of the handler method, then handling known cases and returning before this point without printing the stacktrace. The behaviour is now to catch known IOExceptions (try to connect to a server which has no JMX server running) and SecurityExceptions (incorrect use details) and display appropriate dialogues before returning, or to use the message/causes from other types of exception to build a dialogue and provide a stacktrace output. > [JMX Console] AbstractAction handleException always prints throwable > stacktrace > --- > > Key: QPID-1530 > URL: https://issues.apache.org/jira/browse/QPID-1530 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Affects Versions: M3, M4 >Reporter: Martin Ritchie > Attachments: QPID-1530_12dec2008.patch > > > Summary: > handleException (AbstractAction:L:77) always prints the stackTrace of the > Throwable that it receives as well as displaying an error dialog to the user. > This behaviour is undesirable for exceptions such as connection failures. > The only stackTraces that should be printed are due to programming failures > such as incorrect handingling of data from the broker. > The IOException thrown from JMXServerRegistry due to a incorrect > username/password, for example, does not need to printed out. The dialog box > to the user is sufficient. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
