[jira] [Updated] (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated QPID-1766: -- Assignee: (was: Andrew Stitcher) Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, Makefile.patch, chenta.diff, message_selector_pytest.patch, prime_number.diff, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip, selector_new.diff, selector_patch_20090922.diff, selector_pytest.diff I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-1766: -- Assignee: Andrew Stitcher Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Assignee: Andrew Stitcher Attachments: chenta.diff, Makefile.patch, Makefile.patch, message_selector_pytest.patch, prime_number.diff, selector_broker.patch, selector_client.patch, selector_client.patch, selector.diff, selector.diff, selector_example.zip, selector_new.diff, selector.patch, selector.patch, selector_patch_20090922.diff, selector_pytest.diff I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: prime_number.diff Here is an example that use selector to get the prime number between 1~100 Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: chenta.diff, Makefile.patch, Makefile.patch, message_selector_pytest.patch, prime_number.diff, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip, selector_new.diff, selector_pytest.diff I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: selector_patch_20090922.diff I forgot the add the header files before creating the new patch. Actually I didn't use any new algorithm, I just follow the original algorithm (the one before apply the selector patch), and change a little implemetation detail. So I think it won't be a problem. What do you mean by wrap-around the sequence number? It will be helpful if you could provide an example. If I update the position property of consumer, it will be troublesome to requeue the message. Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: chenta.diff, Makefile.patch, Makefile.patch, message_selector_pytest.patch, prime_number.diff, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip, selector_new.diff, selector_patch_20090922.diff, selector_pytest.diff I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: selector_pytest.diff Add unit tests for selector to python testing framework. I added two unit tests: 1. test_message_selector Filter the message by header and xml content. 2. test_message_selector_not_acquired Filter the message by header and xml content in browsing mode. Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: chenta.diff, Makefile.patch, Makefile.patch, message_selector_pytest.patch, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip, selector_new.diff, selector_pytest.diff I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: message_selector_pytest.patch Add python example for testing. The testing program combined four different kinds of subscribers: 1. regular subscriber using direct exchange 2. regular subscriber using direct exchange in browse mode 3. subscriber using message selector 4. subscriber using message selector in browse mode Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, Makefile.patch, message_selector_pytest.patch, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: selector.diff Fix the segmentation fault. The declaration order of XQilla and selectorQuery is wrong. XQilla should be declared before selectorQuery, because the selectorQuery should be destruct before XQilla. It is the reason we got segmentation fault when destructing the ConsumerImpl. Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, Makefile.patch, selector.diff, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Trieloff updated QPID-1766: Attachment: selector.diff Patch of refactor into XML plugin Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, Makefile.patch, selector.diff, selector.patch, selector.patch, selector_broker.patch, selector_client.patch, selector_client.patch, selector_example.zip I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: selector_example.zip Here is the example for message selector Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, selector.patch, selector_client.patch, selector_example.zip I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1766) Implemention of selector using Xquery
[ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenta lee updated QPID-1766: - Attachment: selector.patch Thank you Gordan, I fixed the locking bug. And Carl mention me that I still use popAnddequeue in Queue::consumNextMessage. I also fixed this. I found out that the field Message msg in Queue::seek function is unnecessary. Because I already pass an iterator into it. So I did some modification. However, I am curious about why do we need another message variable in popAndDequeue. Can't we just dequeue it first and then pop the message? Because I am not sure if store-dequeue will modify the queue so I did the same way in earseAndDequeue. Implemention of selector using Xquery - Key: QPID-1766 URL: https://issues.apache.org/jira/browse/QPID-1766 Project: Qpid Issue Type: Improvement Components: C++ Broker, C++ Client Environment: Linux Reporter: chenta lee Attachments: Makefile.patch, selector.patch, selector.patch, selector_client.patch, selector_example.zip I implemented the message selector for C++ broker and client using Xquery. I will attach an example later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
By the way, I really like this. Let me know when its good to go, and I'll test it and commit it. (Unless someone objects.) Jonathan - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
Gordon Sim wrote: Jonathan Robie wrote: Let me know when its good to go, and I'll test it and commit it. (Unless someone objects.) As stated in my comment on the Jira I think the xerces/xqilla dependencies need to be managed better for this. Ideally it would form a plugin, but at the very least we need to make sure that configure checks for the dependencies and disables this feature if they are not present. I had offered to help Chanta get it into a plug-in once he has the other items done. regards Carl. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
Carl Trieloff wrote: Gordon Sim wrote: Jonathan Robie wrote: Let me know when its good to go, and I'll test it and commit it. (Unless someone objects.) As stated in my comment on the Jira I think the xerces/xqilla dependencies need to be managed better for this. Ideally it would form a plugin, but at the very least we need to make sure that configure checks for the dependencies and disables this feature if they are not present. I had offered to help Chanta get it into a plug-in once he has the other items done. Excellent! - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
chenta lee wrote:
Thank you!!Your explanation is very helpful! I will modify the code ASAP.
BTW, I didn't handle the type parser very well. Currently I can only handle
string and integer type. I am thinking maybe we can use the types defined in
FieldValue to create a map and register the corresponding type handler to
it. How do you think about that?
Yes, I'm afraid I don't handle the incoming data types terribly well
myself.
You may have noticed this comment in my source:
if (args) {
FieldTable::ValueMap::const_iterator v = args-begin();
for(; v != args-end(); ++v) {
// ### TODO: Do types properly
The right thing to do is to check the AMQP type here and convert to the
appropriate XQuery type. I'll do that to my source now and let you know
when I'm done ...
Jonathan
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
Message selector is a popular and essential feature for MQ(ActiveMQ already implemented it). I am not sure if they can patent it. Chenta On Sun, Mar 22, 2009 at 4:18 AM, James Mansion ja...@mansionfamily.plus.com wrote: chenta lee (JIRA) wrote: [ https://issues.apache.org/jira/browse/QPID-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] Is this the stuff that Red Hat is trying to patent? James - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
2009/3/22 chenta lee che...@gmail.com: Message selector is a popular and essential feature for MQ(ActiveMQ already implemented it). I am not sure if they can patent it. Can you be a bit more explicit about what you mean? Are you referring the JMS selectors but with semantics that enable the use of xquery on message content, rather than the SQL-like syntax on message headers (as defined in the JMS specification)? Also by MQ are you referring to IBM MQ? IBM MQ does not as far as I am aware implement xquery selectors as described above. RG - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
Yes, what I mean is the concept of message selector, not how we implement it. And Xquery is mush more powerful than SQL-92 syntax.By MQ, I refer to Message Queue instead of a particular message queue project. I am a little confused about how could my patches related to patent issue? Chenta On Sun, Mar 22, 2009 at 9:10 PM, Robert Greig robert.j.gr...@gmail.comwrote: 2009/3/22 chenta lee che...@gmail.com: Message selector is a popular and essential feature for MQ(ActiveMQ already implemented it). I am not sure if they can patent it. Can you be a bit more explicit about what you mean? Are you referring the JMS selectors but with semantics that enable the use of xquery on message content, rather than the SQL-like syntax on message headers (as defined in the JMS specification)? Also by MQ are you referring to IBM MQ? IBM MQ does not as far as I am aware implement xquery selectors as described above. RG - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Updated: (QPID-1766) Implemention of selector using Xquery
Robert Greig wrote: 2009/3/22 chenta lee che...@gmail.com: Yes, what I mean is the concept of message selector, not how we implement it. And Xquery is mush more powerful than SQL-92 syntax.By MQ, I refer to Message Queue instead of a particular message queue project. OK. xquery may be semantically richer but the JMS message selector functionality operates on message headers not message bodies. Selecting on headers will be hugely faster than on the body. There are clear use cases for both. I know Jonathan has updated the XML exchange to not parse the body if the Query only specifies headers. We should do that here too. I am a little confused about how could my patches related to patent issue? I am not sure of the details of exactly what Red Hat has patented (I have not read the patent text myself). However the Red Hat people are on this mailing list so I am sure they will be able to clarify. From what I have read, the patent covers an AMQP exchange that implements xquery which is not what you are describing. no, it isn't related at all. The piece that it covered has already been provided under a license grant to the ASF (XML Exchange), and will be feely licensed to anyone that uses AMQP if it is ever granted. regards, Carl.
