Re: Review Request 27038: Conflict over 'anonymous-namespace'::empty in Windows ivec and qpid broker modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27038/#review57854 --- Ship it! Since it's only used in two places you could also get rid of the constant entirely and just use a literal "string()" but if this works, go for it. - Alan Conway On Oct. 22, 2014, 2:44 p.m., Chug Rolke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27038/ > --- > > (Updated Oct. 22, 2014, 2:44 p.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, and Gordon Sim. > > > Bugs: QPID-6178 > https://issues.apache.org/jira/browse/QPID-6178 > > > Repository: qpid > > > Description > --- > > This conflict not noticed until Boost 1.55 triggered a new include file chain. > > The proposed fix is a trivial rename from empty to EMPTY. > > > Diffs > - > > trunk/qpid/cpp/src/CMakeLists.txt 1633627 > trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1633627 > trunk/qpid/cpp/src/qpid/broker/MessageAdapter.cpp 1633627 > > Diff: https://reviews.apache.org/r/27038/diff/ > > > Testing > --- > > Compiles with other Visual Studio versions (2010, 2012, 2013) and gcc (but > with boost 1.53) > > > Thanks, > > Chug Rolke > >
Re: Review Request 27038: Conflict over 'anonymous-namespace'::empty in Windows ivec and qpid broker modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27038/#review57847 --- Ship it! Ship It! - Gordon Sim On Oct. 22, 2014, 2:44 p.m., Chug Rolke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27038/ > --- > > (Updated Oct. 22, 2014, 2:44 p.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, and Gordon Sim. > > > Bugs: QPID-6178 > https://issues.apache.org/jira/browse/QPID-6178 > > > Repository: qpid > > > Description > --- > > This conflict not noticed until Boost 1.55 triggered a new include file chain. > > The proposed fix is a trivial rename from empty to EMPTY. > > > Diffs > - > > trunk/qpid/cpp/src/CMakeLists.txt 1633627 > trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1633627 > trunk/qpid/cpp/src/qpid/broker/MessageAdapter.cpp 1633627 > > Diff: https://reviews.apache.org/r/27038/diff/ > > > Testing > --- > > Compiles with other Visual Studio versions (2010, 2012, 2013) and gcc (but > with boost 1.53) > > > Thanks, > > Chug Rolke > >
Re: Review Request 27038: Conflict over 'anonymous-namespace'::empty in Windows ivec and qpid broker modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27038/#review57803 --- Ship it! Ship It! - Andrew Stitcher On Oct. 22, 2014, 2:44 p.m., Chug Rolke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27038/ > --- > > (Updated Oct. 22, 2014, 2:44 p.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, and Gordon Sim. > > > Bugs: QPID-6178 > https://issues.apache.org/jira/browse/QPID-6178 > > > Repository: qpid > > > Description > --- > > This conflict not noticed until Boost 1.55 triggered a new include file chain. > > The proposed fix is a trivial rename from empty to EMPTY. > > > Diffs > - > > trunk/qpid/cpp/src/CMakeLists.txt 1633627 > trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1633627 > trunk/qpid/cpp/src/qpid/broker/MessageAdapter.cpp 1633627 > > Diff: https://reviews.apache.org/r/27038/diff/ > > > Testing > --- > > Compiles with other Visual Studio versions (2010, 2012, 2013) and gcc (but > with boost 1.53) > > > Thanks, > > Chug Rolke > >
