Re: Review Request 12515: Tests for the swigged python client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12515/#review23149 --- Ship it! There are a couple of functions (getSource, getTarget) that do not conform with our normal python style (get_source, get_target). Not sure if this is an oversight or is forced on us by some pre-existing code. /trunk/qpid/cpp/bindings/qpid/python/python.i https://reviews.apache.org/r/12515/#comment47001 Stlye: should be get_source. /trunk/qpid/cpp/bindings/qpid/python/python.i https://reviews.apache.org/r/12515/#comment47002 Style: get_target - Alan Conway On July 12, 2013, 3:36 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12515/ --- (Updated July 12, 2013, 3:36 p.m.) Review request for qpid, Alan Conway, Justin Ross, Darryl Pierce, Rafael Schloming, and Ted Ross. Bugs: QPID-4988 https://issues.apache.org/jira/browse/QPID-4988 Repository: qpid Description --- Adds runs of some of the python tests over the swigged client. Also adds some new tests for AMQP 1.0. Diffs - /trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1502193 /trunk/qpid/cpp/bindings/qpid/python/python.i 1502193 /trunk/qpid/cpp/src/Makefile.am 1502193 /trunk/qpid/cpp/src/amqp.cmake 1502193 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1502193 /trunk/qpid/cpp/src/tests/Makefile.am 1502193 /trunk/qpid/cpp/src/tests/failing-amqp0-10-python-tests PRE-CREATION /trunk/qpid/cpp/src/tests/swig_python_tests PRE-CREATION /trunk/qpid/cpp/src/tests/test_env.sh.in 1502193 /trunk/qpid/python/qpid/tests/messaging/__init__.py 1502193 /trunk/qpid/python/qpid/tests/messaging/implementation.py PRE-CREATION /trunk/qpid/python/qpid/tests/messaging/message.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/lvq.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/priority.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/stats.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/__init__.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/general.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/legacy_exchanges.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/selector.py PRE-CREATION Diff: https://reviews.apache.org/r/12515/diff/ Testing --- cmake (make make test) and autotools (make check) pass Thanks, Gordon Sim
Review Request 12515: Tests for the swigged python client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12515/ --- Review request for qpid, Alan Conway, Justin Ross, Darryl Pierce, Rafael Schloming, and Ted Ross. Bugs: QPID-4988 https://issues.apache.org/jira/browse/QPID-4988 Repository: qpid Description --- Adds runs of some of the python tests over the swigged client. Also adds some new tests for AMQP 1.0. Diffs - /trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1502193 /trunk/qpid/cpp/bindings/qpid/python/python.i 1502193 /trunk/qpid/cpp/src/Makefile.am 1502193 /trunk/qpid/cpp/src/amqp.cmake 1502193 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1502193 /trunk/qpid/cpp/src/tests/Makefile.am 1502193 /trunk/qpid/cpp/src/tests/failing-amqp0-10-python-tests PRE-CREATION /trunk/qpid/cpp/src/tests/swig_python_tests PRE-CREATION /trunk/qpid/cpp/src/tests/test_env.sh.in 1502193 /trunk/qpid/python/qpid/tests/messaging/__init__.py 1502193 /trunk/qpid/python/qpid/tests/messaging/implementation.py PRE-CREATION /trunk/qpid/python/qpid/tests/messaging/message.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/lvq.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/priority.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/stats.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/__init__.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/general.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/legacy_exchanges.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/selector.py PRE-CREATION Diff: https://reviews.apache.org/r/12515/diff/ Testing --- cmake (make make test) and autotools (make check) pass Thanks, Gordon Sim
Re: Review Request 12515: Tests for the swigged python client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12515/#review23096 --- Ship it! Ship It! - Darryl Pierce On July 12, 2013, 3:36 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12515/ --- (Updated July 12, 2013, 3:36 p.m.) Review request for qpid, Alan Conway, Justin Ross, Darryl Pierce, Rafael Schloming, and Ted Ross. Bugs: QPID-4988 https://issues.apache.org/jira/browse/QPID-4988 Repository: qpid Description --- Adds runs of some of the python tests over the swigged client. Also adds some new tests for AMQP 1.0. Diffs - /trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1502193 /trunk/qpid/cpp/bindings/qpid/python/python.i 1502193 /trunk/qpid/cpp/src/Makefile.am 1502193 /trunk/qpid/cpp/src/amqp.cmake 1502193 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1502193 /trunk/qpid/cpp/src/tests/Makefile.am 1502193 /trunk/qpid/cpp/src/tests/failing-amqp0-10-python-tests PRE-CREATION /trunk/qpid/cpp/src/tests/swig_python_tests PRE-CREATION /trunk/qpid/cpp/src/tests/test_env.sh.in 1502193 /trunk/qpid/python/qpid/tests/messaging/__init__.py 1502193 /trunk/qpid/python/qpid/tests/messaging/implementation.py PRE-CREATION /trunk/qpid/python/qpid/tests/messaging/message.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/lvq.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/priority.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/stats.py 1502193 /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/__init__.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/general.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/legacy_exchanges.py PRE-CREATION /trunk/qpid/tests/src/py/qpid_tests/broker_1_0/selector.py PRE-CREATION Diff: https://reviews.apache.org/r/12515/diff/ Testing --- cmake (make make test) and autotools (make check) pass Thanks, Gordon Sim
