Re: Review Request 41800: C++ broker and client to support TLS1.1 and TLS1.2

2016-01-04 Thread Kenneth Giusti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41800/#review112577
---

Ship it!


Ship It!

- Kenneth Giusti


On Dec. 30, 2015, 2:16 p.m., Pavel Moravec wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41800/
> ---
> 
> (Updated Dec. 30, 2015, 2:16 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Kenneth Giusti.
> 
> 
> Bugs: QPID-6966
> https://issues.apache.org/jira/browse/QPID-6966
> 
> 
> Repository: qpid
> 
> 
> Description
> ---
> 
> Get all supported SSL/TLS versions via `SSL_VersionRangeGetSupported` method 
> and update the defaults also when supported max version is higher than 
> default max version - analoguously like disabling SSLv2 and 3.
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/src/qpid/sys/ssl/util.cpp 1722327 
> 
> Diff: https://reviews.apache.org/r/41800/diff/
> 
> 
> Testing
> ---
> 
> `openssl s_client -tls1_[1-2] connect` passed, no more tests done.
> 
> 
> Thanks,
> 
> Pavel Moravec
> 
>



Re: Review Request 41800: C++ broker and client to support TLS1.1 and TLS1.2

2016-01-04 Thread Gordon Sim

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41800/#review112526
---

Ship it!


Ship It!

- Gordon Sim


On Dec. 30, 2015, 2:16 p.m., Pavel Moravec wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41800/
> ---
> 
> (Updated Dec. 30, 2015, 2:16 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Kenneth Giusti.
> 
> 
> Bugs: QPID-6966
> https://issues.apache.org/jira/browse/QPID-6966
> 
> 
> Repository: qpid
> 
> 
> Description
> ---
> 
> Get all supported SSL/TLS versions via `SSL_VersionRangeGetSupported` method 
> and update the defaults also when supported max version is higher than 
> default max version - analoguously like disabling SSLv2 and 3.
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/src/qpid/sys/ssl/util.cpp 1722327 
> 
> Diff: https://reviews.apache.org/r/41800/diff/
> 
> 
> Testing
> ---
> 
> `openssl s_client -tls1_[1-2] connect` passed, no more tests done.
> 
> 
> Thanks,
> 
> Pavel Moravec
> 
>



Review Request 41800: C++ broker and client to support TLS1.1 and TLS1.2

2015-12-30 Thread Pavel Moravec

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41800/
---

Review request for qpid, Gordon Sim and Kenneth Giusti.


Bugs: QPID-6966
https://issues.apache.org/jira/browse/QPID-6966


Repository: qpid


Description
---

Get all supported SSL/TLS versions via `SSL_VersionRangeGetSupported` method 
and update the defaults also when supported max version is higher than default 
max version - analoguously like disabling SSLv2 and 3.


Diffs
-

  trunk/qpid/cpp/src/qpid/sys/ssl/util.cpp 1722327 

Diff: https://reviews.apache.org/r/41800/diff/


Testing
---

`openssl s_client -tls1_[1-2] connect` passed, no more tests done.


Thanks,

Pavel Moravec