[GitHub] incubator-quickstep pull request #263: Added the execution support for LIP w...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep pull request #257: Added Partition Rule for HashJoin.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122334121
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
rules.emplace_back(new AttachLIPFilters());
}
+ rules.push_back(std::make_unique(optimizer_context_));
--- End diff --
In the single-node version on a `NUMA` machine, we needs this partition
rule. Sure, I am adding a flag to switch this rule.
Regarding the first question, if I put the partition rule before `LIP`
rules, how could I process `FilterJoin` with partitioned inputs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #263: Added the execution support for LIP w...
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/263 Added the execution support for LIP with partitions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zuyu/incubator-quickstep partitioned-lip-execution-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-quickstep/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit 1c749c911814926c48b8c4f7f34519605dc435a2 Author: Zuyu Zhang Date: 2017-06-15T22:38:53Z Added the execution support for LIP with partitions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep issue #257: Added Partition Rule for HashJoin.
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/257 Good refactoring. LGTM! Except one place in `PhysicalGenerator.cpp`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep pull request #257: Added Partition Rule for HashJoin.
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122326409
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
rules.emplace_back(new AttachLIPFilters());
}
+ rules.push_back(std::make_unique(optimizer_context_));
--- End diff --
The other question is that -- is this rule always needed to be applied
(e.g. even in single-node mode)? If not, we may have a flag or `#ifdef` to
conditionally apply this rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #257: Added Partition Rule for HashJoin.
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122325834
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
rules.emplace_back(new AttachLIPFilters());
}
+ rules.push_back(std::make_unique(optimizer_context_));
--- End diff --
Is it okay to move this rule before the two LIP-related rules? Currently
the LIP information may be invalidated (and lead to incorrect results) if tree
transformation happens after the two LIP passes.
Meanwhile, better add some comments describing what additional information
would be added into the physical nodes after this pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
