[GitHub] incubator-quickstep pull request #299: QUICKSTEP-104 Fix the problem that Li...

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/299#discussion_r139872360
  
--- Diff: cli/tests/command_executor/D.test ---
@@ -69,6 +71,7 @@ INSERT INTO foo3 values(5, 1, 1.0, 1.0, 'XYZZ');
  col4   | Float  
  col5   | Char(5)
 ==
+
--- End diff --

In the test, is it possible to also check special chars `\t` and `\r`?


---

[GitHub] incubator-quickstep pull request #299: QUICKSTEP-104 Fix the problem that Li...

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/299#discussion_r139872510
  
--- Diff: cli/LineReader.cpp ---
@@ -171,7 +173,7 @@ std::string LineReader::getNextCommand() {
 case '.':
 case '\\':  //  Fall Through.
   // If the dot or forward slash begins the line, begin a 
command search.
-  if (scan_position == 0) {
+  if (special_char_location == 
multiline_buffer.find_first_not_of(" \t\r\n")) {
--- End diff --

I think we should keep `scan_position == 0` as well. Otherwise, it seems 
that we require some special chars before a command string.


---

[GitHub] incubator-quickstep pull request #299: QUICKSTEP-104 Fix the problem that Li...

[jianqiao]

GitHub user jianqiao opened a pull request:

https://github.com/apache/incubator-quickstep/pull/299

QUICKSTEP-104 Fix the problem that LineReader cannot recognize a command if 
there are whitespaces before it.

This PR fixes a bug that the Quickstep REPL cannot recognize a command 
(e.g. `\d`, `\analyze`) if there are whitespaces or empty lines before the 
command.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jianqiao/incubator-quickstep 
fix-extract-command

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #299


commit 77960a42dcfb3d27de5601548a04d81a6be79375
Author: Jianqiao Zhu 
Date:   2017-09-20T03:02:02Z

Fix a bug in LineReader for recognizing command




---

[GitHub] incubator-quickstep pull request #298: Prune columns after partition rule.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/298


---

[GitHub] incubator-quickstep issue #298: Prune columns after partition rule.

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/298
  
LGTM. Merging.


---

[GitHub] incubator-quickstep pull request #298: Prune columns after partition rule.

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/298

Prune columns after partition rule.

This small PR allows to prune columns after partition rule, and thus 
improve the query performance by avoiding unused attributes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep 
prune-columns-after-repartition

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #298


commit 71aa8d265cc2240da0ebf8275a70884002a1ea45
Author: Zuyu Zhang 
Date:   2017-09-20T00:17:29Z

Prune columns after partition rule.




---