[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...

2017-11-09 Thread phenyl-sphinx
Github user phenyl-sphinx commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/323#discussion_r150144494
  
--- Diff: CMakeLists.txt ---
@@ -302,11 +302,11 @@ else()
 endif()
   endif()
 
-  # OSX 10.12 has deprecated certain system-level APIs which causes 
protobuf & glog
+  # OSX 10.12+ has deprecated certain system-level APIs which causes 
protobuf & glog
   # builds to fail. As a short-term workaround for now, we turn off 
deprecated
   # warnings so that they do not cause build failures anymore.
   # TODO: Remove this workaround by fixing the protobuf_cmake and 
glog_cmake.
-  if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
+  if (${CMAKE_SYSTEM} MATCHES "Darwin-1[6-7]*.[0-9]*.[0-9]*")
--- End diff --

No. But either should be able to work.


---


[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...

2017-11-09 Thread zuyu
Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/323#discussion_r150140641
  
--- Diff: CMakeLists.txt ---
@@ -302,11 +302,11 @@ else()
 endif()
   endif()
 
-  # OSX 10.12 has deprecated certain system-level APIs which causes 
protobuf & glog
+  # OSX 10.12+ has deprecated certain system-level APIs which causes 
protobuf & glog
   # builds to fail. As a short-term workaround for now, we turn off 
deprecated
   # warnings so that they do not cause build failures anymore.
   # TODO: Remove this workaround by fixing the protobuf_cmake and 
glog_cmake.
-  if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
+  if (${CMAKE_SYSTEM} MATCHES "Darwin-1[6-7]*.[0-9]*.[0-9]*")
--- End diff --

Just curious if you have tried `Darwin-1[67].[0-9]*.[0-9]*`? Thanks!


---


[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13

2017-11-09 Thread zuyu
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/323
  
Hi Yuanchen,

Thank you for submitting your PR, and we will test your PR soon.


---


Re: cmake error

2017-11-09 Thread Om Jadhav
Hi,

It’s gcc version 6.3.0.

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/6/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 
6.3.0-18ubuntu2~16.04' --with-bugurl=file:///usr/share/doc/gcc-6/README.Bugs 
--enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr 
--program-suffix=-6 --program-prefix=x86_64-linux-gnu- --enable-shared 
--enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext 
--enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ 
--enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes 
--with-default-libstdcxx-abi=new --enable-gnu-unique-object 
--disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib 
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo 
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-6-amd64/jre --enable-java-home 
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-6-amd64 
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-6-amd64 
--with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar 
--with-target-system-zlib --enable-objc-gc=auto --enable-multiarch 
--disable-werror --with-arch-32=i686 --with-abi=m64 
--with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic 
--enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu 
--target=x86_64-linux-gnu
Thread model: posix
gcc version 6.3.0 20170519 (Ubuntu/Linaro 6.3.0-18ubuntu2~16.04)


On 09/11/17, 5:04 PM, "Jianqiao"  wrote:

It seems to be a problem related to C++ compiler version. Can you check its
version by using command:
gcc -v

The fix should be a few lines of changes in root directory's/glog's
CMakeLists.txt.

Best,
Jianqiao


2017-11-08 15:30 GMT-06:00 Om Jadhav :

> Hi Jianqiao,
>
> Please find the make error below:
>
> [  7%] Completed 'libtcmalloc_ext'
> [  7%] Built target libtcmalloc_ext
> [  7%] Building CXX object third_party/googletest/
> googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
> [  7%] Linking CXX static library libgtest.a
> [  7%] Built target gtest
> [  7%] Building CXX object third_party/gflags/CMakeFiles/
> gflags_nothreads-static.dir/src/gflags.cc.o
> /home/omjadhav/quickstep/third_party/src/gflags/src/gflags.cc:443:5:
> error: ‘int google::{anonymous}::FlagValue::ValueSize() const’ defined
> but not used [-Werror=unused-function]
>  int FlagValue::ValueSize() const {
>  ^
> cc1plus: error: unrecognized command line option
> ‘-Wno-return-type-c-linkage’ [-Werror]
> cc1plus: all warnings being treated as errors
> third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/build.make:62:
> recipe for target 
'third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/src/gflags.cc.o'
> failed
> make[2]: *** 
[third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/src/gflags.cc.o]
> Error 1
> CMakeFiles/Makefile2:939: recipe for target 'third_party/gflags/
> CMakeFiles/gflags_nothreads-static.dir/all' failed
> make[1]: *** 
[third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/all]
> Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2
>
>
> Thanks
> Om
>
> On 06/11/17, 3:45 PM, "Jianqiao"  wrote:
>
> Hi Om,
>
> It seems that your "cmake" output is okay. Can you also provide the
> "make"
> error message?
>
> Best,
> Jianqiao
>
> 2017-11-06 11:34 GMT-06:00 Harshad Deshmukh :
>
> > Hi Om,
> >
> > What's your build setup? Did you download the prerequisites and
> > initialized the git submodules?
> >
> > Get Outlook for Android
> >
> > 
> > From: Om Jadhav 
> > Sent: Friday, November 3, 2017 3:42:05 PM
> > To: dev@quickstep.incubator.apache.org
> > Subject: cmake error
> >
> > Hello,
> >
> > I am trying to cmake, and I am getting most of the things failed for
> the
> > first time. And also the build is failing after this cmake.
> >
> > o/p:
> >
> > Vector copy elision level set to: single-relation selection
> > -- git Version: v0.0.0
> > -- Version: 0.0.0
> > -- Performing Test HAVE_STD_REGEX
> > -- Performing Test HAVE_STD_REGEX -- success
> > -- Performing Test HAVE_GNU_POSIX_REGEX
> > -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
> > -- Performing Test HAVE_POSIX_REGEX
> > -- Performing Test HAVE_POSIX_REGEX -- success
> > -- 

Re: cmake error

2017-11-09 Thread Jianqiao
It seems to be a problem related to C++ compiler version. Can you check its
version by using command:
gcc -v

The fix should be a few lines of changes in root directory's/glog's
CMakeLists.txt.

Best,
Jianqiao


2017-11-08 15:30 GMT-06:00 Om Jadhav :

> Hi Jianqiao,
>
> Please find the make error below:
>
> [  7%] Completed 'libtcmalloc_ext'
> [  7%] Built target libtcmalloc_ext
> [  7%] Building CXX object third_party/googletest/
> googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
> [  7%] Linking CXX static library libgtest.a
> [  7%] Built target gtest
> [  7%] Building CXX object third_party/gflags/CMakeFiles/
> gflags_nothreads-static.dir/src/gflags.cc.o
> /home/omjadhav/quickstep/third_party/src/gflags/src/gflags.cc:443:5:
> error: ‘int google::{anonymous}::FlagValue::ValueSize() const’ defined
> but not used [-Werror=unused-function]
>  int FlagValue::ValueSize() const {
>  ^
> cc1plus: error: unrecognized command line option
> ‘-Wno-return-type-c-linkage’ [-Werror]
> cc1plus: all warnings being treated as errors
> third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/build.make:62:
> recipe for target 
> 'third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/src/gflags.cc.o'
> failed
> make[2]: *** 
> [third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/src/gflags.cc.o]
> Error 1
> CMakeFiles/Makefile2:939: recipe for target 'third_party/gflags/
> CMakeFiles/gflags_nothreads-static.dir/all' failed
> make[1]: *** [third_party/gflags/CMakeFiles/gflags_nothreads-static.dir/all]
> Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2
>
>
> Thanks
> Om
>
> On 06/11/17, 3:45 PM, "Jianqiao"  wrote:
>
> Hi Om,
>
> It seems that your "cmake" output is okay. Can you also provide the
> "make"
> error message?
>
> Best,
> Jianqiao
>
> 2017-11-06 11:34 GMT-06:00 Harshad Deshmukh :
>
> > Hi Om,
> >
> > What's your build setup? Did you download the prerequisites and
> > initialized the git submodules?
> >
> > Get Outlook for Android
> >
> > 
> > From: Om Jadhav 
> > Sent: Friday, November 3, 2017 3:42:05 PM
> > To: dev@quickstep.incubator.apache.org
> > Subject: cmake error
> >
> > Hello,
> >
> > I am trying to cmake, and I am getting most of the things failed for
> the
> > first time. And also the build is failing after this cmake.
> >
> > o/p:
> >
> > Vector copy elision level set to: single-relation selection
> > -- git Version: v0.0.0
> > -- Version: 0.0.0
> > -- Performing Test HAVE_STD_REGEX
> > -- Performing Test HAVE_STD_REGEX -- success
> > -- Performing Test HAVE_GNU_POSIX_REGEX
> > -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
> > -- Performing Test HAVE_POSIX_REGEX
> > -- Performing Test HAVE_POSIX_REGEX -- success
> > -- Performing Test HAVE_STEADY_CLOCK
> > -- Performing Test HAVE_STEADY_CLOCK -- success
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.gregs[REG_EIP]
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.gregs[REG_RIP]
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> uc_mcontext.sc_ip
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.uc_regs->gregs[PT_NIP]
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.gregs[R15]
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.arm_pc
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.mc_eip
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.mc_rip
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
> > -- Checking program counter fetch from ucontext_t member:
> > uc_mcontext.__gregs[_REG_EIP]
> > -- Performing Test PC_FROM_UCONTEXT_COMPILES
> > -- Performing Test 

Re: cmake error

2017-11-09 Thread Om Jadhav
Hi Harshad,

I am using google cloud instance:
ubuntu 16.04(1 vCPU, 3.75 GB memory)

Yes, I have downloaded all the prerequisites and initialized git submodules.

PFA make error details.

Thanks
Om

On 06/11/17, 11:34 AM, "Harshad Deshmukh"  wrote:

Hi Om,

What's your build setup? Did you download the prerequisites and initialized 
the git submodules?

Get Outlook for Android


From: Om Jadhav 
Sent: Friday, November 3, 2017 3:42:05 PM
To: dev@quickstep.incubator.apache.org
Subject: cmake error

Hello,

I am trying to cmake, and I am getting most of the things failed for the 
first time. And also the build is failing after this cmake.

o/p:

Vector copy elision level set to: single-relation selection
-- git Version: v0.0.0
-- Version: 0.0.0
-- Performing Test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX -- success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.gregs[REG_EIP]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.gregs[REG_RIP]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: uc_mcontext.sc_ip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.uc_regs->gregs[PT_NIP]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.gregs[R15]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: uc_mcontext.arm_pc
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: uc_mcontext.mc_eip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: uc_mcontext.mc_rip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.__gregs[_REG_EIP]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext.__gregs[_REG_RIP]
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->ss.eip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->__ss.__eip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->ss.rip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->__ss.__rip
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->ss.srr0
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
-- Checking program counter fetch from ucontext_t member: 
uc_mcontext->__ss.__srr0
-- Performing Test PC_FROM_UCONTEXT_COMPILES
-- Performing Test PC_FROM_UCONTEXT_COMPILES - Failed
CMake Warning at third_party/src/glog/CMakeLists.txt:185 (message):
  Unable to find program counter field in ucontext_t.  GLOG signal handler
  will not be able to report precise PC position.


You appear to be building on a Linux system with HugeTLB support. To take 
advantage of this feature, you will need to configure kernel support for 
hugepages by setting /proc/sys/vm/nr_hugepages and/or 
/proc/sys/vm/nr_overcommit_hugepages as well as running quickstep executables 
under the group id specified in /proc/sys/vm/hugetlb_shm_group (see Linux 
documentation 

[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...

2017-11-09 Thread phenyl-sphinx
GitHub user phenyl-sphinx opened a pull request:

https://github.com/apache/incubator-quickstep/pull/323

Temporary Build Support for OS X 10.13

Added building support for OS X 10.13 (which didn't work beforehand)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phenyl-sphinx/incubator-quickstep master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #323


commit 2d02669adfaf8cba6f8dee4a6edfa82a2a22
Author: Yuanchen Li 
Date:   2017-11-09T08:18:42Z

Temporary Build Support for OS X 10.13




---