[GitHub] incubator-quickstep issue #334: Fix iwyu include path

[hbdeshmukh]

Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/334
  
Hi @jianqiao 

This looks good to me. Have you been actively using the IWYU library? I 
stopped using it a while ago because of the false positives. I am not sure if 
it has improved.


---

[GitHub] incubator-quickstep pull request #334: Fix iwyu include path

[jianqiao]

GitHub user jianqiao opened a pull request:

https://github.com/apache/incubator-quickstep/pull/334

Fix iwyu include path

This PR fixes the third-party library include paths for the iwyu 
(include-what-you-use) tool.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep fix-iwyu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #334


commit c2ed5c69b6b8dad07d7410beb0c8292ea1a746e0
Author: Jianqiao Zhu 
Date:   2017-09-01T20:07:41Z

Fix iwyu include path




---

Re: Question about using Intel TBB

[Julian Hyde]

Apache license is fine.


> On Feb 26, 2018, at 9:11 AM, Harshad Deshmukh  wrote:
> 
> Hello,
> 
> 
> I am planning to incorporate Intel's TBB library 
> (https://www.threadingbuildingblocks.org/) in the Quickstep source code as a 
> third party module. TBB provides fast and parallel data structures such as 
> concurrent hash map. Its licence looks alright to me but I want to run it 
> through the licensing experts on the dev list. Here's the licensing header I 
> found in their source code:
> 
> 
> 
> 
>Copyright (c) 2005-2017 Intel Corporation
> 
>Licensed under the Apache License, Version 2.0 (the "License");
>you may not use this file except in compliance with the License.
>You may obtain a copy of the License at
>http://www.apache.org/licenses/LICENSE-2.0
>Unless required by applicable law or agreed to in writing, software
>distributed under the License is distributed on an "AS IS" BASIS,
>WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>See the License for the specific language governing permissions and
>limitations under the License.
> 
> 
> 
> Thanks,
> 
> Harshad

Question about using Intel TBB

[Harshad Deshmukh]

Hello,


I am planning to incorporate Intel's TBB library 
(https://www.threadingbuildingblocks.org/) in the Quickstep source code as a 
third party module. TBB provides fast and parallel data structures such as 
concurrent hash map. Its licence looks alright to me but I want to run it 
through the licensing experts on the dev list. Here's the licensing header I 
found in their source code:




Copyright (c) 2005-2017 Intel Corporation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.



Thanks,

Harshad