[GitHub] incubator-quickstep pull request #354: Fixed the union-all elimiation case w...

2018-05-07 Thread zuyu
GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/354

Fixed the union-all elimiation case where some project expression is not an 
AttributeReference.

This PR fixed for the case where the only one child of the union-all query 
is non-empty, and the child has a non-AttributeReference project expression:

```
SELECT 1 AS a FROM not_empty
UNION ALL
SELECT 0 AS a FROM empty;
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep 
eliminate-empty-node-bug-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit f7d1132672f4ef6399dbbe77541f93911c2d640b
Author: Zuyu Zhang 
Date:   2018-05-08T04:58:35Z

Fixed the union-all elimiation case where some project expression is not an 
AttributeReference.




---


[GitHub] incubator-quickstep pull request #353: Minor bug fixes and refactors.

2018-05-07 Thread zuyu
GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/353

Minor bug fixes and refactors.

This PR contains most work from @jianqiao when working on the datalog 
branch, including bug fix and some refactors.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep bug-fix-refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit 7aa91392e67cdb96a75e36522f243c71330ab811
Author: Zuyu Zhang 
Date:   2018-05-07T21:08:35Z

Minor bug fixes and refactors.




---


[GitHub] incubator-quickstep pull request #351: Use Exactness info in Catalog stats.

2018-05-07 Thread zuyu
Github user zuyu closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/351


---


[GitHub] incubator-quickstep issue #351: Use Exactness info in Catalog stats.

2018-05-07 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/351
  
I agree with Jianqiao. The plans may be a bit off when the stats are stale, 
however it is still better than not using the stats at all. 


---


[GitHub] incubator-quickstep issue #351: Use Exactness info in Catalog stats.

2018-05-07 Thread jianqiao
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/351
  
The stats can be used to provide an estimation even when they are not 
exact. 


---