[GitHub] incubator-quickstep pull request #357: Fixed the command execution bug in th...
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/357 Fixed the command execution bug in the distributed version. This PR fixed the command execution bugs in the distributed version, and now it is consistent with the single-node version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zuyu/incubator-quickstep dist-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-quickstep/pull/357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #357 commit 89ddcb48b32f352659600cdcdc55fe059184a06a Author: Zuyu Zhang Date: 2018-05-21T21:39:42Z Fixed the command execution bug in the distributed version. ---
[GitHub] incubator-quickstep pull request #338: Fixed the gRPC Problem for Data Excha...
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/338#discussion_r189711855 --- Diff: storage/StorageManager.cpp --- @@ -687,8 +687,13 @@ StorageManager::BlockHandle StorageManager::loadBlockOrBlob( #ifdef QUICKSTEP_DISTRIBUTED const string domain_network_address = getPeerDomainNetworkAddress(BlockIdUtil::Domain(block)); DLOG(INFO) << "Pulling Block " << BlockIdUtil::ToString(block) << " from " << domain_network_address; + +// Customize the grpc channel +grpc::ChannelArguments channelArgs; +channelArgs.SetMaxReceiveMessageSize(kGrpcChanelSize); --- End diff -- Please add a condition wrapper based on the `GRPC` version number for this API call, since not every version has this API. ---
[GitHub] incubator-quickstep pull request #356: DO NOT MERGE: Added the grpc in Travi...
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/356 DO NOT MERGE: Added the grpc in Travis CI. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zuyu/incubator-quickstep travis-grpc-new Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-quickstep/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit d6554af49ae003e7999f4367369dc3e6242ad18b Author: Zuyu Zhang Date: 2018-05-21T18:42:15Z Added the grpc in Travis CI. ---
[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/355 We do not test the distributed version in CI due to previous time-out issue while installing `grpc` by source code. ---
[GitHub] incubator-quickstep pull request #355: QUICKSTEP-127 Data provider thread
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/355#discussion_r189664042
--- Diff: storage/DataProviderThread.hpp ---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ **/
+
+#ifndef QUICKSTEP_STORAGE_DATA_PROVIDER_THREAD_HPP_
+#define QUICKSTEP_STORAGE_DATA_PROVIDER_THREAD_HPP_
+
+#include
+
+#include "query_execution/QueryExecutionTypedefs.hpp"
+#include "storage/StorageConfig.h"
+#include "threading/Thread.hpp"
+#include "utility/Macros.hpp"
+
+#include "tmb/native_net_client_message_bus.h"
+
+namespace quickstep {
+
+class CatalogDatabase;
+class CatalogRelation;
+class QueryProcessor;
+class StorageManager;
+
+/** \addtogroup Storage
+ * @{
+ */
+
+/**
+ * @brief A thread that provides access to query results (e.g. storage
blocks),
+ *to Quickstep clients.
--- End diff --
Could you please provide more info regarding this class, including which
class will own this class, and why it needs write permissions to both
`CatalogDatabase` and `QueryProcessor`? Thanks!
---
[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/355 @zuyu Question: How do you run tests for distributed quickstep on Travis? ---
[GitHub] incubator-quickstep pull request #355: QUICKSTEP-127 Data provider thread
GitHub user hbdeshmukh opened a pull request: https://github.com/apache/incubator-quickstep/pull/355 QUICKSTEP-127 Data provider thread - Thread used for receiving block requests from clients and sending the contents of a block back to the client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hbdeshmukh/incubator-quickstep data-provider-thread Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-quickstep/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit 6967ca57c448a17b63e176bf8bc1576066fe893a Author: Harshad Deshmukh Date: 2018-04-06T21:00:54Z Data Provider thread added. - Thread used for receiving block requests from clients and sending the contents of a block back to the client. ---
