[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

2018-04-25 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/341
  
Looks good to me. 


---

[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

2018-04-21 Thread zuyu 
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/341
  
`CopyFrom` = `Clear` + `MergeFrom`.

Since we set a value for each new `proto`, we do not need `Clear` to reset 
the memory.


---

[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

2018-04-21 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/341
  
What's the difference between the two functions?


---