[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-06-04 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
Hi @jianqiao 

I have rebased and addressed style concerns by @zuyu. Thanks! 


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-06-04 Thread jianqiao 
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
@hbdeshmukh Hi Harshad, can you rebase the branch so I can help merge this 
PR.


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-06-04 Thread jianqiao 
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
LGTM!


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-06-01 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
Hi @zuyu I have made the changes. The code in this PR will be invoked only 
with a compile time flag ENABLE_NETWORK_CLI. Earlier it was dependent on 
ENABLE_DISTRIBUTED, which was not correct. I am working on interfacing this 
feature with our frontend, another PR will be coming soon which will have an 
end-to-end working of this feature.


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-05-25 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
Right now, the new code is included only in the distributed version. It 
need not be the case, as the only dependency for Data Provider Thread is for 
GRPC and Networked TMB.


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-05-21 Thread zuyu 
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
We do not test the distributed version in CI due to previous time-out issue 
while installing `grpc` by source code.


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

2018-05-21 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
@zuyu Question: How do you run tests for distributed quickstep on Travis?


---