[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...

2018-10-11 Thread zuyu 
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/362
  
LGTM. Squash the commits and once the checks pass, I can merge.


---

[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...

2018-10-11 Thread zuyu 
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/362
  
For completeness, please add `override` for the destructors of derived 
classes of `GeneratorFunctionHandle`, `LIPFilter`, and `BaseClass`. Thanks!


---