[GitHub] incubator-quickstep pull request #340: More informative error for BlockNotFo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/340


---

[GitHub] incubator-quickstep pull request #340: More informative error for BlockNotFo...

[hbdeshmukh]

Github user hbdeshmukh commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/340#discussion_r182228415
  
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
  **/
 class BlockNotFoundInMemory : public std::exception {
  public:
+  BlockNotFoundInMemory(int block_id) : block_id_(block_id) {}
+
   virtual const char* what() const throw() {
-return "BlockNotFoundInMemory: The specified block was not found in 
memory";
+std::string message = "BlockNotFoundInMemory: The specified block with 
ID "
+  + std::to_string(block_id_ )+ " was not found in memory";
+return message.c_str();
--- End diff --

My bad, that's a stupid mistake. Thanks for pointing out. 


---

[GitHub] incubator-quickstep pull request #340: More informative error for BlockNotFo...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/340#discussion_r182212888
  
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
  **/
 class BlockNotFoundInMemory : public std::exception {
  public:
+  BlockNotFoundInMemory(int block_id) : block_id_(block_id) {}
+
   virtual const char* what() const throw() {
-return "BlockNotFoundInMemory: The specified block was not found in 
memory";
+std::string message = "BlockNotFoundInMemory: The specified block with 
ID "
+  + std::to_string(block_id_ )+ " was not found in memory";
+return message.c_str();
   }
+
+ private:
+  int block_id_;
--- End diff --

Suggested fix:
```
  const std::string block_id_message_;
```


---

[GitHub] incubator-quickstep pull request #340: More informative error for BlockNotFo...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/340#discussion_r182210127
  
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
  **/
 class BlockNotFoundInMemory : public std::exception {
  public:
+  BlockNotFoundInMemory(int block_id) : block_id_(block_id) {}
--- End diff --

Minor style fix:
```
explicit BlockNotFoundInMemory(const int block_id) : ...
```


---