[GitHub] incubator-quickstep pull request #348: Refactored ScalarCaseExpression.

2018-05-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/348


---


[GitHub] incubator-quickstep pull request #348: Refactored ScalarCaseExpression.

2018-05-02 Thread zuyu
GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/348

Refactored ScalarCaseExpression.

This PR does the following:
 1. Moved the static methods into the cpp file.
 1. Added a fast path for `getAllValuesForJoin`, similar to other existing 
methods.
 1. Added more unit tests to cover the join cases with a static branch.
 1. Removed a unnecessary overridden virtual function 
`getRelationIdForValueAccessor`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep case-expr-opt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit dc4b5ddedb11077ae6a6a3a92a841a42c4a8b819
Author: Zuyu Zhang 
Date:   2018-05-02T21:06:59Z

Refactored ScalarCaseExpression.




---