[jira] [Created] (RANGER-1842) Don't catch Throwables in the test code
Colm O hEigeartaigh created RANGER-1842: --- Summary: Don't catch Throwables in the test code Key: RANGER-1842 URL: https://issues.apache.org/jira/browse/RANGER-1842 Project: Ranger Issue Type: Test Components: plugins Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Priority: Trivial Fix For: 1.0.0 In a couple of the tests, we are catching Throwables. This means that the Assert.fail() conditions inside the try statement are ineffective. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 63068: RANGER-1842 - Don't catch Throwables in the test code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63068/ --- Review request for ranger. Bugs: RANGER-1842 https://issues.apache.org/jira/browse/RANGER-1842 Repository: ranger Description --- In a couple of the tests, we are catching Throwables. This means that the Assert.fail() conditions inside the try statement are ineffective. Diffs - kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java cac22502 storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java 53173078 Diff: https://reviews.apache.org/r/63068/diff/1/ Testing --- Thanks, Colm O hEigeartaigh
[jira] [Updated] (RANGER-1842) Don't catch Throwables in the test code
[ https://issues.apache.org/jira/browse/RANGER-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1842: Attachment: 0001-RANGER-1842-Don-t-catch-Throwables-in-the-test-code.patch > Don't catch Throwables in the test code > --- > > Key: RANGER-1842 > URL: https://issues.apache.org/jira/browse/RANGER-1842 > Project: Ranger > Issue Type: Test > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Trivial > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1842-Don-t-catch-Throwables-in-the-test-code.patch > > > In a couple of the tests, we are catching Throwables. This means that the > Assert.fail() conditions inside the try statement are ineffective. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1828) Good coding practice-add additional headers in ranger
[ https://issues.apache.org/jira/browse/RANGER-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Purbhe updated RANGER-1828: -- Attachment: RANGER-1828_1.patch > Good coding practice-add additional headers in ranger > - > > Key: RANGER-1828 > URL: https://issues.apache.org/jira/browse/RANGER-1828 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Nikhil Purbhe >Assignee: Nikhil Purbhe > Fix For: 1.0.0, 0.7.2 > > Attachments: RANGER-1828, RANGER-1828_1.patch > > > Good coding practice-add additional headers in ranger -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 62882: Good coding practice-add additional headers in ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62882/ --- (Updated Oct. 17, 2017, 4:24 p.m.) Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-1828 https://issues.apache.org/jira/browse/RANGER-1828 Repository: ranger Description --- Good coding practice-add additional headers in ranger. Diffs (updated) - security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44 Diff: https://reviews.apache.org/r/62882/diff/2/ Changes: https://reviews.apache.org/r/62882/diff/1-2/ Testing --- 1)Verified if response contains additional headers on simple ranger(http). 2)Verified if response contains additional headers on kerberized ranger. 3)Verified if response contains additional headers on SSL ranger(https). 4)Verified if response contains additional headers on kerberized+SSL ranger. Thanks, Nikhil P
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin
> On Sept. 27, 2017, 9:33 a.m., pengjianhua wrote: > > The https://issues.apache.org/jira/browse/KYLIN-2703 I submitted had been > > resolved. Our test experts have rigorously tested this issue. At the same > > time the Kyligence company which is Apache kylin's main contributor will > > soon use this feature. > > Colm O hEigeartaigh wrote: > When will Kylin 2.2.0 be released? If we merge a dependency on a SNAPSHOT > version in Ranger, we can't release Ranger until Kylin is released. Do you > have any documentation on how to set up a simple test-scenario? > > pengjianhua wrote: > Ok. The Kylin 2.2.0 will be released in late October. > > Qiang Zhang wrote: > Ok. I am writing install guide for the feature. > > Qiang Zhang wrote: > Hi Colm, Can you tell me how to build a document patch? Thanks! > > Colm O hEigeartaigh wrote: > I'm not sure what you mean by "document patch". What do you want to do > exactly? I build patch for RANGER-1809 after writed installing guide for RANGER-1672. I want to know which path the document is placed and how to build the document patch. Thanks! - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61021/#review186391 --- On Sept. 27, 2017, 9:19 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61021/ > --- > > (Updated Sept. 27, 2017, 9:19 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1672 > https://issues.apache.org/jira/browse/RANGER-1672 > > > Repository: ranger > > > Description > --- > > Ranger supports plugin to enable, monitor and manage apache kylin > > > Diffs > - > > agents-common/scripts/enable-agent.sh d31a264 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 9463ab8 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 58cdd35 > agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json > PRE-CREATION > plugin-kylin/.gitignore PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION > plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-kylin/pom.xml PRE-CREATION > plugin-kylin/scripts/install.properties PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java > PRE-CREATION > pom.xml 3958014 > ranger-kylin-plugin-shim/.gitignore PRE-CREATION > ranger-kylin-plugin-shim/pom.xml PRE-CREATION > > ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > src/main/assembly/admin-web.xml 0e97818 > src/main/assembly/plugin-kylin.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61021/diff/3/ > > > Testing > --- > > Tested > > > Thanks, > > Qiang Zhang > >
Re: Review Request 63068: RANGER-1842 - Don't catch Throwables in the test code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63068/#review188342 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 17, 2017, 10:04 a.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63068/ > --- > > (Updated Oct. 17, 2017, 10:04 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1842 > https://issues.apache.org/jira/browse/RANGER-1842 > > > Repository: ranger > > > Description > --- > > In a couple of the tests, we are catching Throwables. This means that the > Assert.fail() conditions inside the try statement are ineffective. > > > Diffs > - > > > kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java > cac22502 > > storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java > 53173078 > > > Diff: https://reviews.apache.org/r/63068/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 62882: Good coding practice-add additional headers in ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62882/#review188343 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 17, 2017, 10:54 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62882/ > --- > > (Updated Oct. 17, 2017, 10:54 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1828 > https://issues.apache.org/jira/browse/RANGER-1828 > > > Repository: ranger > > > Description > --- > > Good coding practice-add additional headers in ranger. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 721dd44 > > > Diff: https://reviews.apache.org/r/62882/diff/2/ > > > Testing > --- > > 1)Verified if response contains additional headers on simple ranger(http). > 2)Verified if response contains additional headers on kerberized ranger. > 3)Verified if response contains additional headers on SSL ranger(https). > 4)Verified if response contains additional headers on kerberized+SSL ranger. > > > Thanks, > > Nikhil P > >
[jira] [Created] (RANGER-1843) Tag enricher performance improvement in identifying tags for resource being accessed
Madhan Neethiraj created RANGER-1843: Summary: Tag enricher performance improvement in identifying tags for resource being accessed Key: RANGER-1843 URL: https://issues.apache.org/jira/browse/RANGER-1843 Project: Ranger Issue Type: Bug Components: plugins Reporter: Madhan Neethiraj Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (RANGER-1843) Tag enricher performance improvement in identifying tags for resource being accessed
[ https://issues.apache.org/jira/browse/RANGER-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni reassigned RANGER-1843: -- Assignee: Abhay Kulkarni > Tag enricher performance improvement in identifying tags for resource being > accessed > > > Key: RANGER-1843 > URL: https://issues.apache.org/jira/browse/RANGER-1843 > Project: Ranger > Issue Type: Bug > Components: plugins >Reporter: Madhan Neethiraj >Assignee: Abhay Kulkarni > > Performance improvements in RANGER-1771, in finding the policies for a given > resource, should be made in tag-enricher as well - to optimize finding of > tags applicable for a given resource, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63085/ --- Review request for ranger, Madhan Neethiraj and Ramesh Mani. Bugs: RANGER-1843 https://issues.apache.org/jira/browse/RANGER-1843 Repository: ranger Description --- Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422 Diff: https://reviews.apache.org/r/63085/diff/1/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63085/ --- (Updated Oct. 17, 2017, 11:32 p.m.) Review request for ranger, Madhan Neethiraj and Ramesh Mani. Changes --- More performance improvements Bugs: RANGER-1843 https://issues.apache.org/jira/browse/RANGER-1843 Repository: ranger Description --- Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource. Diffs (updated) - agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422 agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d Diff: https://reviews.apache.org/r/63085/diff/2/ Changes: https://reviews.apache.org/r/63085/diff/1-2/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63085/ --- (Updated Oct. 18, 2017, 1:03 a.m.) Review request for ranger, Madhan Neethiraj and Ramesh Mani. Changes --- Clarified code. Bugs: RANGER-1843 https://issues.apache.org/jira/browse/RANGER-1843 Repository: ranger Description --- Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource. Diffs (updated) - agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422d agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d5 Diff: https://reviews.apache.org/r/63085/diff/3/ Changes: https://reviews.apache.org/r/63085/diff/2-3/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni
