Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/ --- (Updated 十二月 13, 2017, 1:49 a.m.) Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-1924 https://issues.apache.org/jira/browse/RANGER-1924 Repository: ranger Description (updated) --- Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml and ranger/hdfs-agent/pom.xml and Simplify ranger-hive plugin remove gson.jar in ranger/src/main/assembly/hive-agent.xml and ranger/hive-agent/pom.xml Description: Remove com.google.code.gson:gson* in ranger/src/main/assembly/hdfs-agent.xml Remove com.google.code.gson:gson* in ranger/src/main/assembly/hive-agent.xml Remove " com.google.code.gson gson " from ranger/hdfs-agent/pom.xml and ranger/hive-agent/pom.xml Reason: 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts 2.Observing ranger-yarn plugin has also removed gson.jar in ranger/src/main/assembly/plugin-yarn.xml. 3.Hive already has gson.jar removed from gson.jar to prevent conflicts Result: the ranger-hdfs plugin also works fine after removing gson.jar. the ranger-hive plugin also works fine after removing gson.jar Diffs - hdfs-agent/pom.xml 0b6773d hive-agent/pom.xml c195443 src/main/assembly/hdfs-agent.xml 5279a9a src/main/assembly/hive-agent.xml ca65c80 Diff: https://reviews.apache.org/r/64525/diff/2/ Testing --- Tested it. Thanks, pengjianhua
Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/ --- (Updated 十二月 13, 2017, 1:43 a.m.) Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-1924 https://issues.apache.org/jira/browse/RANGER-1924 Repository: ranger Description --- Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml Description: Remove com.google.code.gson:gson* in ranger/src/main/assembly/hdfs-agent.xml Reason: 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts 2.Observing ranger-yarn plugin has also removed gson.jar in ranger/src/main/assembly/plugin-yarn.xml. Result: the ranger-hdfs plugin also works fine after removing gson.jar. Diffs (updated) - hdfs-agent/pom.xml 0b6773d hive-agent/pom.xml c195443 src/main/assembly/hdfs-agent.xml 5279a9a src/main/assembly/hive-agent.xml ca65c80 Diff: https://reviews.apache.org/r/64525/diff/2/ Changes: https://reviews.apache.org/r/64525/diff/1-2/ Testing --- Tested it. Thanks, pengjianhua
Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/#review193580 --- And also, you could remove the gson dependency from the hdfs-plugin pom. - Colm O hEigeartaigh On Dec. 12, 2017, 2:43 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64525/ > --- > > (Updated Dec. 12, 2017, 2:43 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1924 > https://issues.apache.org/jira/browse/RANGER-1924 > > > Repository: ranger > > > Description > --- > > Simplify ranger-hdfs plugin remove gson.jar in > ranger/src/main/assembly/hdfs-agent.xml > Description: > Remove com.google.code.gson:gson* in > ranger/src/main/assembly/hdfs-agent.xml > Reason: > 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts > 2.Observing ranger-yarn plugin has also removed gson.jar in > ranger/src/main/assembly/plugin-yarn.xml. > Result: the ranger-hdfs plugin also works fine after removing gson.jar. > > > Diffs > - > > src/main/assembly/hdfs-agent.xml 5279a9a > > > Diff: https://reviews.apache.org/r/64525/diff/1/ > > > Testing > --- > > Tested it. > > > Thanks, > > pengjianhua > >
Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/#review193578 --- The Hive plugin also ships gson, which looks like it could be removed as well. - Colm O hEigeartaigh On Dec. 12, 2017, 2:43 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64525/ > --- > > (Updated Dec. 12, 2017, 2:43 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1924 > https://issues.apache.org/jira/browse/RANGER-1924 > > > Repository: ranger > > > Description > --- > > Simplify ranger-hdfs plugin remove gson.jar in > ranger/src/main/assembly/hdfs-agent.xml > Description: > Remove com.google.code.gson:gson* in > ranger/src/main/assembly/hdfs-agent.xml > Reason: > 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts > 2.Observing ranger-yarn plugin has also removed gson.jar in > ranger/src/main/assembly/plugin-yarn.xml. > Result: the ranger-hdfs plugin also works fine after removing gson.jar. > > > Diffs > - > > src/main/assembly/hdfs-agent.xml 5279a9a > > > Diff: https://reviews.apache.org/r/64525/diff/1/ > > > Testing > --- > > Tested it. > > > Thanks, > > pengjianhua > >
Review Request 64549: RANGER-1926 - Upgrade Storm dependency to 1.1.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64549/ --- Review request for ranger. Bugs: RANGER-1926 https://issues.apache.org/jira/browse/RANGER-1926 Repository: ranger Description --- This task is to upgrade the Storm dependency to 1.1.1. No further changes are required, as it's backwards compatible with 1.0.x. Diffs - pom.xml 3086a1e5 Diff: https://reviews.apache.org/r/64549/diff/1/ Testing --- Not required as no changes are made to the distribution jars. Thanks, Colm O hEigeartaigh
[jira] [Updated] (RANGER-1926) Upgrade Storm dependency to 1.1.1
[ https://issues.apache.org/jira/browse/RANGER-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1926: Attachment: 0001-RANGER-1926-Upgrade-Storm-dependency-to-1.1.1.patch > Upgrade Storm dependency to 1.1.1 > - > > Key: RANGER-1926 > URL: https://issues.apache.org/jira/browse/RANGER-1926 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1926-Upgrade-Storm-dependency-to-1.1.1.patch > > > This task is to upgrade the Storm dependency to 1.1.1. No further changes are > required, as it's backwards compatible with 1.0.x. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1926) Upgrade Storm dependency to 1.1.1
Colm O hEigeartaigh created RANGER-1926: --- Summary: Upgrade Storm dependency to 1.1.1 Key: RANGER-1926 URL: https://issues.apache.org/jira/browse/RANGER-1926 Project: Ranger Issue Type: Improvement Components: plugins Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Priority: Minor Fix For: 1.0.0 This task is to upgrade the Storm dependency to 1.1.1. No further changes are required, as it's backwards compatible with 1.0.x. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 64529: RANGER-1925:Remove invalid code from plugin script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64529/#review193520 --- Ship it! Ship It! - pengjianhua On 十二月 12, 2017, 9:29 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64529/ > --- > > (Updated 十二月 12, 2017, 9:29 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1925 > https://issues.apache.org/jira/browse/RANGER-1925 > > > Repository: ranger > > > Description > --- > > Some codes were copied to plugin script from other file. They are invalid, we > should remove them. > > > Diffs > - > > agents-common/scripts/enable-agent.sh d77e4f9e > plugin-kms/scripts/enable-kms-plugin.sh 9180b57 > > > Diff: https://reviews.apache.org/r/64529/diff/1/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Re: Review Request 64409: RANGER-1920 - Remove SOLR dependencies from the KMS service + plugins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64409/#review193519 --- Ship it! Ship It! - pengjianhua On 十二月 7, 2017, 12:40 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64409/ > --- > > (Updated 十二月 7, 2017, 12:40 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1920 > https://issues.apache.org/jira/browse/RANGER-1920 > > > Repository: ranger > > > Description > --- > > The SOLR dependencies are not required in the KMS service, or the KMS > plugins, as the jar is instead on the classpath via plugins-audit. > > > Diffs > - > > kms/pom.xml bc0d96f7 > plugin-kms/pom.xml 344940aa > ranger-kms-plugin-shim/pom.xml 10473707 > > > Diff: https://reviews.apache.org/r/64409/diff/1/ > > > Testing > --- > > Tested SOLR auditing works fine with the KMS Service. > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 64500: RANGER-1923 - Simplify Hive dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64500/#review193518 --- Ship it! Ship It! - pengjianhua On 十二月 11, 2017, 11:36 a.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64500/ > --- > > (Updated 十二月 11, 2017, 11:36 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1923 > https://issues.apache.org/jira/browse/RANGER-1923 > > > Repository: ranger > > > Description > --- > > This task is to simplify the Hive plugin dependencies. The plugin itself has > a dependency on the Hadoop HDFS jar that is not required, similarly the Shim > has some dependencies on other Hadoop jars. > > With Hive, we pick up the relevant jars from the Hadoop distribution, so > Ranger does not have to ship any Hadoop jars. > > No changes are made to the jars shipped in the plugin distribution. > > > Diffs > - > > hive-agent/pom.xml 7d54a4dc > ranger-hive-plugin-shim/pom.xml 87330cef > > > Diff: https://reviews.apache.org/r/64500/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 64447: RANGER-1922 - Simplify HBase dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64447/#review193517 --- Ship it! Ship It! - pengjianhua On 十二月 8, 2017, 12:38 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64447/ > --- > > (Updated 十二月 8, 2017, 12:38 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1922 > https://issues.apache.org/jira/browse/RANGER-1922 > > > Repository: ranger > > > Description > --- > > Description > > This task is to simplify the HBase dependencies: > > a) We don't need to specify the Solr jar as it gets picked up from the audit > module. > b) We don't need to specify the HDFS jar as we don't bundle it in the > distribution - the jar is picked up from HBase itself. > c) The 2.7.1 Hadoop dependencies in the HBase pom should be removed - instead > we should just pick up the Hadoop dependencies required for testing from the > Hadoop version that ships with HBase. > > This work means that the HBase module compiles + tests work correctly when we > upgrade to Hadoop 3.0.0. > > > Diffs > - > > hbase-agent/pom.xml 19cc905e > ranger-hbase-plugin-shim/pom.xml e0e27a7c > > > Diff: https://reviews.apache.org/r/64447/diff/1/ > > > Testing > --- > > Tested HDFS + Solr auditing still works as expected with the plugin. > > > Thanks, > > Colm O hEigeartaigh > >
[jira] [Updated] (RANGER-1925) Remove invalid code from plugin script.
[ https://issues.apache.org/jira/browse/RANGER-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1925: Attachment: 0001-RANGER-1925-Remove-invalid-code-from-plugin-script.patch > Remove invalid code from plugin script. > --- > > Key: RANGER-1925 > URL: https://issues.apache.org/jira/browse/RANGER-1925 > Project: Ranger > Issue Type: Improvement > Components: kms, plugins >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > Attachments: > 0001-RANGER-1925-Remove-invalid-code-from-plugin-script.patch > > > Some codes were copied to plugin script from other file. They are invalid, > we should remove them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 64529: RANGER-1925:Remove invalid code from plugin script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64529/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy. Bugs: RANGER-1925 https://issues.apache.org/jira/browse/RANGER-1925 Repository: ranger Description --- Some codes were copied to plugin script from other file. They are invalid, we should remove them. Diffs - agents-common/scripts/enable-agent.sh d77e4f9e plugin-kms/scripts/enable-kms-plugin.sh 9180b57 Diff: https://reviews.apache.org/r/64529/diff/1/ Testing --- Thanks, Qiang Zhang
Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/#review193516 --- Ship it! Ship It! - Qiang Zhang On Dec. 12, 2017, 2:43 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64525/ > --- > > (Updated Dec. 12, 2017, 2:43 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1924 > https://issues.apache.org/jira/browse/RANGER-1924 > > > Repository: ranger > > > Description > --- > > Simplify ranger-hdfs plugin remove gson.jar in > ranger/src/main/assembly/hdfs-agent.xml > Description: > Remove com.google.code.gson:gson* in > ranger/src/main/assembly/hdfs-agent.xml > Reason: > 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts > 2.Observing ranger-yarn plugin has also removed gson.jar in > ranger/src/main/assembly/plugin-yarn.xml. > Result: the ranger-hdfs plugin also works fine after removing gson.jar. > > > Diffs > - > > src/main/assembly/hdfs-agent.xml 5279a9a > > > Diff: https://reviews.apache.org/r/64525/diff/1/ > > > Testing > --- > > Tested it. > > > Thanks, > > pengjianhua > >
[jira] [Updated] (RANGER-1925) Remove invalid code from plugin script.
[ https://issues.apache.org/jira/browse/RANGER-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1925: Description: Some codes were copied to plugin script from other file. They are invalid, we should remove them. (was: Some codes was copied to plugin script from other file. They are invalid, we should remove them.) > Remove invalid code from plugin script. > --- > > Key: RANGER-1925 > URL: https://issues.apache.org/jira/browse/RANGER-1925 > Project: Ranger > Issue Type: Improvement > Components: kms, plugins >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > > Some codes were copied to plugin script from other file. They are invalid, > we should remove them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1925) Remove invalid code from plugin script.
[ https://issues.apache.org/jira/browse/RANGER-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1925: Description: Some codes was copied to plugin script from other file. They are invalid, we should remove them. (was: Some codes are invalide, we should remove them) > Remove invalid code from plugin script. > --- > > Key: RANGER-1925 > URL: https://issues.apache.org/jira/browse/RANGER-1925 > Project: Ranger > Issue Type: Improvement > Components: kms, plugins >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > > Some codes was copied to plugin script from other file. They are invalid, we > should remove them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 64500: RANGER-1923 - Simplify Hive dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64500/#review193514 --- Ship it! Ship It! - Qiang Zhang On Dec. 11, 2017, 11:36 a.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64500/ > --- > > (Updated Dec. 11, 2017, 11:36 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1923 > https://issues.apache.org/jira/browse/RANGER-1923 > > > Repository: ranger > > > Description > --- > > This task is to simplify the Hive plugin dependencies. The plugin itself has > a dependency on the Hadoop HDFS jar that is not required, similarly the Shim > has some dependencies on other Hadoop jars. > > With Hive, we pick up the relevant jars from the Hadoop distribution, so > Ranger does not have to ship any Hadoop jars. > > No changes are made to the jars shipped in the plugin distribution. > > > Diffs > - > > hive-agent/pom.xml 7d54a4dc > ranger-hive-plugin-shim/pom.xml 87330cef > > > Diff: https://reviews.apache.org/r/64500/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 64447: RANGER-1922 - Simplify HBase dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64447/#review193513 --- Ship it! Ship It! - Qiang Zhang On Dec. 8, 2017, 12:38 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64447/ > --- > > (Updated Dec. 8, 2017, 12:38 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1922 > https://issues.apache.org/jira/browse/RANGER-1922 > > > Repository: ranger > > > Description > --- > > Description > > This task is to simplify the HBase dependencies: > > a) We don't need to specify the Solr jar as it gets picked up from the audit > module. > b) We don't need to specify the HDFS jar as we don't bundle it in the > distribution - the jar is picked up from HBase itself. > c) The 2.7.1 Hadoop dependencies in the HBase pom should be removed - instead > we should just pick up the Hadoop dependencies required for testing from the > Hadoop version that ships with HBase. > > This work means that the HBase module compiles + tests work correctly when we > upgrade to Hadoop 3.0.0. > > > Diffs > - > > hbase-agent/pom.xml 19cc905e > ranger-hbase-plugin-shim/pom.xml e0e27a7c > > > Diff: https://reviews.apache.org/r/64447/diff/1/ > > > Testing > --- > > Tested HDFS + Solr auditing still works as expected with the plugin. > > > Thanks, > > Colm O hEigeartaigh > >
[jira] [Created] (RANGER-1925) Remove invalid code from plugin script.
Qiang Zhang created RANGER-1925: --- Summary: Remove invalid code from plugin script. Key: RANGER-1925 URL: https://issues.apache.org/jira/browse/RANGER-1925 Project: Ranger Issue Type: Improvement Components: kms, plugins Reporter: Qiang Zhang Assignee: Qiang Zhang Some codes are invalide, we should remove them -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 64409: RANGER-1920 - Remove SOLR dependencies from the KMS service + plugins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64409/#review193510 --- Ship it! Ship It! - Qiang Zhang On Dec. 7, 2017, 12:40 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64409/ > --- > > (Updated Dec. 7, 2017, 12:40 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1920 > https://issues.apache.org/jira/browse/RANGER-1920 > > > Repository: ranger > > > Description > --- > > The SOLR dependencies are not required in the KMS service, or the KMS > plugins, as the jar is instead on the classpath via plugins-audit. > > > Diffs > - > > kms/pom.xml bc0d96f7 > plugin-kms/pom.xml 344940aa > ranger-kms-plugin-shim/pom.xml 10473707 > > > Diff: https://reviews.apache.org/r/64409/diff/1/ > > > Testing > --- > > Tested SOLR auditing works fine with the KMS Service. > > > Thanks, > > Colm O hEigeartaigh > >
