Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-06 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208440
---


Ship it!




Ship It!

- Nitin Galave


On Aug. 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated Aug. 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68128: RANGER-2170:Ranger supports plugin to enable, monitor and manage Elasticsearch

2018-09-06 Thread Qiang Zhang 


> On 九月 6, 2018, 6:30 p.m., Ramesh Mani wrote:
> > ranger-elasticsearch-plugin-shim/conf/plugin-descriptor.properties
> > Lines 46 (patched)
> > 
> >
> > Why is -shim- is having the conf and classes which are core to the 
> > plugin it should part of /plugin-elasticseach/conf folder.
> > -shim is to hold the ranger-classloader.
> > Please refer the existing plugin and see if that can be done.

Because unlike other Hadoop components, Elasticseach is designed to be 
pluggable.
To implement a new extension function, 
we need to organize code and configuration files according to the requirements 
of Elasticseach.
Some classes in ranger-elasticsearch-plugin-shim is necessary to mount on 
Elasticseach.
Other classes is due to the fact that Elasticseach itself does not support user 
authentication,
so this plugin should work with other Elasticsearch plugin to authenticate 
users,
such as Basic Authentication, Kerberos, LDAP, etc.
Or, in the future, we can realize user authentication in 
ranger-elasticsearch-plugin-shim.
So these classes can't sink into plugin-elasticseach.
And plugin-descriptor.properties is for Elasticseach to start the Ranger 
Elasticseach plugin.
But the files in the plugin-elasticseach/conf directory are for Ranger 
Elasticseach plugin.

The related directory structure after plugin installed is as follows:
1.ranger-elasticsearch-plugin-shim/conf/?
```
[elasticsearch@zdh-11 ranger-elasticsearch-plugin]$ pwd
/home/elasticsearch/elasticsearch-6.2.2/plugins/ranger-elasticsearch-plugin
[elasticsearch@zdh-11 ranger-elasticsearch-plugin]$ ll
-rwxrwxrwx. 1 elasticsearch hadoop 588337 4?  25 2017 
commons-collections-3.2.2.jar
-rwxrwxrwx. 1 elasticsearch hadoop 284220 4?  25 2017 commons-lang-2.6.jar
-rwxrwxrwx. 1 elasticsearch hadoop   2547 6?  26 09:41 
plugin-descriptor.properties
-rwxrwxrwx. 1 elasticsearch hadoop   1754 6?  26 09:27 plugin-security.policy
drwxrwxrwx. 2 elasticsearch hadoop   4096 7?  13 09:40 
ranger-elasticsearch-plugin-impl
-rwxrwxrwx. 1 elasticsearch hadoop  20627 6?  26 09:36 
ranger-elasticsearch-plugin-shim-1.1.0-SNAPSHOT.jar
-rwxrwxrwx. 1 elasticsearch hadoop  16799 6?  26 09:35 
ranger-plugin-classloader-1.1.0-SNAPSHOT.jar
-rwxrwxrwx. 1 elasticsearch hadoop  26084 4?  25 2017 slf4j-api-1.7.5.jar
-rwxrwxrwx. 1 elasticsearch hadoop   8866 6?  26 15:30 slf4j-log4j12-1.7.10.jar
```

2.plugin-elasticseach/conf?
```
[elasticsearch@zdh-11 ranger-elasticsearch-plugin]$ pwd
/home/elasticsearch/elasticsearch-6.2.2/config/ranger-elasticsearch-plugin
[elasticsearch@zdh-11 ranger-elasticsearch-plugin]$ ll
-rwxrwxrwx. 1 elasticsearch hadoop 9548 6?  26 14:15 
ranger-elasticsearch-audit.xml
-rwxrwxrwx. 1 elasticsearch hadoop 2773 6?  26 14:15 
ranger-elasticsearch-security.xml
-rwxrwxrwx. 1 elasticsearch hadoop 1917 6?  26 14:15 ranger-policymgr-ssl.xml
-rwxrwxrwx. 1 elasticsearch hadoop   83 6?  26 14:15 ranger-security.xml
```

In addition, I have developed 2 plugins: Ranger Kylin Plugin and Ranger Sqoop2 
Plugin.
In order to meet the requirements of Elasticsearch plugins 
and take into account the general design principles of Ranger plugins,
I think the implementation of Ranger Elasticsearch plugin is reasonable at 
present.
Try install this plugin , and you can get a better understanding of the 
implementation of it.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68128/#review208418
---


On 八月 14, 2018, 8:46 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68128/
> ---
> 
> (Updated 八月 14, 2018, 8:46 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2170
> https://issues.apache.org/jira/browse/RANGER-2170
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Elasticsearch is a distributed, RESTful search and analytics engine capable 
> of solving a growing number of use cases. 
> Like Apache Solr, it is also an index server based on Lucence.
> Ranger supports plugin to enable, monitor and manage Elasticsearch,
> to control index security of Elasticsearch.
> 
> As there is X-Pack plugin for the Elasticsearch, but it is not free.
> X-Pack is an Elastic Stack extension that bundles security, alerting, 
> monitoring, reporting, 
> and graph capabilities into one easy-to-install package.
> We refer to the Indices Privileges design of X-Pack,
> by keeping the permissions consistent,
> to make user use ranger Elasticsearch plugin

Re: Review Request 68128: RANGER-2170:Ranger supports plugin to enable, monitor and manage Elasticsearch

2018-09-06 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68128/#review208418
---




ranger-elasticsearch-plugin-shim/conf/plugin-descriptor.properties
Lines 46 (patched)


Why is -shim- is having the conf and classes which are core to the plugin 
it should part of /plugin-elasticseach/conf folder.
-shim is to hold the ranger-classloader.
Please refer the existing plugin and see if that can be done.


- Ramesh Mani


On Aug. 14, 2018, 8:46 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68128/
> ---
> 
> (Updated Aug. 14, 2018, 8:46 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2170
> https://issues.apache.org/jira/browse/RANGER-2170
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Elasticsearch is a distributed, RESTful search and analytics engine capable 
> of solving a growing number of use cases. 
> Like Apache Solr, it is also an index server based on Lucence.
> Ranger supports plugin to enable, monitor and manage Elasticsearch,
> to control index security of Elasticsearch.
> 
> As there is X-Pack plugin for the Elasticsearch, but it is not free.
> X-Pack is an Elastic Stack extension that bundles security, alerting, 
> monitoring, reporting, 
> and graph capabilities into one easy-to-install package.
> We refer to the Indices Privileges design of X-Pack,
> by keeping the permissions consistent,
> to make user use ranger Elasticsearch plugin easily.
> Reference X-Pack Indices Privileges:
> https://www.elastic.co/guide/en/x-pack/current/security-privileges.html
> 
> Here we develop Ranger Elasticsearch plugin, based on Elasticsearch version 
> 6.2.2.
> Elasticsearch 6.2.2 was released in February 20, 2018, reference 
> release-notes:
> https://www.elastic.co/guide/en/elasticsearch/reference/6.2/release-notes-6.2.2.html
> Not like other system, Elasticsearch has no basic authentication, 
> it uses X-pack plugin to support basic authentication, 
> role-based access control, SSL/TLS encryption, LDAP and so on.
> Not like X-pack, our Ranger Elasticsearch plugin is designed to do 
> authorization,
> it is to control index of Elasticsearch without authentication,
> this plugin should work with other Elasticsearch plugin to authenticate users.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh ce0dc8c 
>   agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 
> e654f2b 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  5e74da8 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json
>  PRE-CREATION 
>   plugin-elasticsearch/.gitignore PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 
> PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-elasticsearch-security-changes.cfg 
> PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-elasticsearch-security.xml PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION 
>   plugin-elasticsearch/conf/ranger-policymgr-ssl.xml PRE-CREATION 
>   plugin-elasticsearch/pom.xml PRE-CREATION 
>   plugin-elasticsearch/scripts/install.properties PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/authorization/elasticsearch/authorizer/RangerElasticsearchAuthorizer.java
>  PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/services/elasticsearch/RangerServiceElasticsearch.java
>  PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/services/elasticsearch/client/ElasticsearchClient.java
>  PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/services/elasticsearch/client/ElasticsearchResourceMgr.java
>  PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/services/elasticsearch/privilege/IndexPrivilege.java
>  PRE-CREATION 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/services/elasticsearch/privilege/IndexPrivilegeUtils.java
>  PRE-CREATION 
>   pom.xml 8d7ea13 
>   ranger-elasticsearch-plugin-shim/.gitignore PRE-CREATION 
>   ranger-elasticsearch-plugin-shim/conf/plugin-descriptor.properties 
> PRE-CREATION 
>   ranger-elasticsearch-plugin-shim/conf/plugin-security.policy PRE-CREATION 
>   ranger-elasticsearch-plugin-shim/pom.xml PRE-CREATION 
>   
>

Re: Review Request 68428: RANGER-1935/RANGER-1738 - Upgrade Ranger to support Apache Hadoop 3.0.0

2018-09-06 Thread Ramesh Mani 


> On Sept. 5, 2018, 11:09 p.m., Ramesh Mani wrote:
> > security-admin/pom.xml
> > Line 263 (original), 263 (patched)
> > 
> >
> > why using hadoop.2.7 version for ranger secuirty-admin?
> 
> Colm O hEigeartaigh wrote:
> As I said in the description above, if the Admin service uses the new 
> Hadoop jars, when you click on the users part of the Admin UI, no users 
> appear. I'm not expert enough with the UI to figure out why, so I left the 
> admin service using the old hadoop jars in the patch, and planned to create a 
> separate JIRA to upgrade the admin service afterwards.

Thanks Colm, I was not sure of what was the issue from the description


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68428/#review208381
---


On Sept. 5, 2018, 1:22 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68428/
> ---
> 
> (Updated Sept. 5, 2018, 1:22 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1935
> https://issues.apache.org/jira/browse/RANGER-1935
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Upgrade Ranger to use Apache Hadoop 3.0.0. Some comments:
> 
> - KMS reencryptEncryptedKey not implemented.
> - HDFS unit test - HDFSContentSummaryTest test failing. @Ignore'd for now, 
> I'll create a separate JIRA for this.
> - Hive tests commented out - waiting for Hive upgrade task.
> - Admin service users not appearing so in the patch it's using the old Hadoop 
> jars. I'll create a separate JIRA for this to upgrade it as well.
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java
>  0f291389f 
>   credentialbuilder/pom.xml 461dcd0b6 
>   
> hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java 
> a7215ce92 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
>  7dc5c54b0 
>   kms/pom.xml 6fc190f35 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java
>  f853a844b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 
> be3700ffa 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
>  ada9a56f4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 
> b2540cb42 
>   knox-agent/pom.xml 1d8fdae62 
>   
> plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
>  a4de016ea 
>   pom.xml ae3f4be4c 
>   ranger-examples/plugin-sampleapp/pom.xml bef0f5c1f 
>   ranger-storm-plugin-shim/pom.xml 89efe34de 
>   
> ranger-yarn-plugin-shim/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
>  7b7f1f303 
>   security-admin/pom.xml 84bbd6650 
>   src/main/assembly/hbase-agent.xml 3ebc334d1 
>   src/main/assembly/hdfs-agent.xml 561d13737 
>   src/main/assembly/hive-agent.xml 03bd31a55 
>   src/main/assembly/kms.xml 7fbc1410c 
>   src/main/assembly/knox-agent.xml 8357d4989 
>   src/main/assembly/plugin-atlas.xml 8f4a64cb6 
>   src/main/assembly/plugin-kafka.xml 97ff8ad1b 
>   src/main/assembly/plugin-kms.xml 6d15f2a10 
>   src/main/assembly/plugin-kylin.xml f4e082007 
>   src/main/assembly/plugin-solr.xml de30bfb13 
>   src/main/assembly/plugin-sqoop.xml d2bd69ab3 
>   src/main/assembly/plugin-yarn.xml c6a48e888 
>   src/main/assembly/ranger-tools.xml 249de9a2d 
>   src/main/assembly/storm-agent.xml fdaf67863 
>   src/main/assembly/tagsync.xml d1b83df42 
>   src/main/assembly/usersync.xml d170d8c1c 
>   storm-agent/pom.xml a084e6891 
>   tagsync/pom.xml e98cf63dc 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml d49001a65 
>   
> ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java
>  9a77cedf7 
>   ugsync/pom.xml f4c24e739 
>   unixauthclient/pom.xml cd3d15604 
>   unixauthservice/pom.xml 2c0ed2eef 
> 
> 
> Diff: https://reviews.apache.org/r/68428/diff/3/
> 
> 
> Testing
> ---
> 
> Tested plugins: HDFS, Yarn, Storm (uses Hadoop 2.7.1), Knox, HBase, KMS, 
> Sqoop, Kafka, Solr, usersync. Test admin service works OK.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 68428: RANGER-1935/RANGER-1738 - Upgrade Ranger to support Apache Hadoop 3.0.0

2018-09-06 Thread Colm O hEigeartaigh 


> On Sept. 5, 2018, 11:09 p.m., Ramesh Mani wrote:
> > security-admin/pom.xml
> > Line 263 (original), 263 (patched)
> > 
> >
> > why using hadoop.2.7 version for ranger secuirty-admin?

As I said in the description above, if the Admin service uses the new Hadoop 
jars, when you click on the users part of the Admin UI, no users appear. I'm 
not expert enough with the UI to figure out why, so I left the admin service 
using the old hadoop jars in the patch, and planned to create a separate JIRA 
to upgrade the admin service afterwards.


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68428/#review208381
---


On Sept. 5, 2018, 1:22 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68428/
> ---
> 
> (Updated Sept. 5, 2018, 1:22 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1935
> https://issues.apache.org/jira/browse/RANGER-1935
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Upgrade Ranger to use Apache Hadoop 3.0.0. Some comments:
> 
> - KMS reencryptEncryptedKey not implemented.
> - HDFS unit test - HDFSContentSummaryTest test failing. @Ignore'd for now, 
> I'll create a separate JIRA for this.
> - Hive tests commented out - waiting for Hive upgrade task.
> - Admin service users not appearing so in the patch it's using the old Hadoop 
> jars. I'll create a separate JIRA for this to upgrade it as well.
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java
>  0f291389f 
>   credentialbuilder/pom.xml 461dcd0b6 
>   
> hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java 
> a7215ce92 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
>  7dc5c54b0 
>   kms/pom.xml 6fc190f35 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java
>  f853a844b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 
> be3700ffa 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
>  ada9a56f4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 
> b2540cb42 
>   knox-agent/pom.xml 1d8fdae62 
>   
> plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
>  a4de016ea 
>   pom.xml ae3f4be4c 
>   ranger-examples/plugin-sampleapp/pom.xml bef0f5c1f 
>   ranger-storm-plugin-shim/pom.xml 89efe34de 
>   
> ranger-yarn-plugin-shim/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
>  7b7f1f303 
>   security-admin/pom.xml 84bbd6650 
>   src/main/assembly/hbase-agent.xml 3ebc334d1 
>   src/main/assembly/hdfs-agent.xml 561d13737 
>   src/main/assembly/hive-agent.xml 03bd31a55 
>   src/main/assembly/kms.xml 7fbc1410c 
>   src/main/assembly/knox-agent.xml 8357d4989 
>   src/main/assembly/plugin-atlas.xml 8f4a64cb6 
>   src/main/assembly/plugin-kafka.xml 97ff8ad1b 
>   src/main/assembly/plugin-kms.xml 6d15f2a10 
>   src/main/assembly/plugin-kylin.xml f4e082007 
>   src/main/assembly/plugin-solr.xml de30bfb13 
>   src/main/assembly/plugin-sqoop.xml d2bd69ab3 
>   src/main/assembly/plugin-yarn.xml c6a48e888 
>   src/main/assembly/ranger-tools.xml 249de9a2d 
>   src/main/assembly/storm-agent.xml fdaf67863 
>   src/main/assembly/tagsync.xml d1b83df42 
>   src/main/assembly/usersync.xml d170d8c1c 
>   storm-agent/pom.xml a084e6891 
>   tagsync/pom.xml e98cf63dc 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml d49001a65 
>   
> ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java
>  9a77cedf7 
>   ugsync/pom.xml f4c24e739 
>   unixauthclient/pom.xml cd3d15604 
>   unixauthservice/pom.xml 2c0ed2eef 
> 
> 
> Diff: https://reviews.apache.org/r/68428/diff/3/
> 
> 
> Testing
> ---
> 
> Tested plugins: HDFS, Yarn, Storm (uses Hadoop 2.7.1), Knox, HBase, KMS, 
> Sqoop, Kafka, Solr, usersync. Test admin service works OK.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 67782: RANGER-2144 - refactor DAO creation

2018-09-06 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67782/
---

(Updated Sept. 6, 2018, 8:54 a.m.)


Review request for ranger.


Changes
---

Rebased on master


Bugs: RANGER-2144
https://issues.apache.org/jira/browse/RANGER-2144


Repository: ranger


Description
---

Currently, RangerDaoManagerBase is used to construct new DAO instances, instead 
of relying on Spring to provide one for it. This would reduce the code to write 
and run, and make it less interdependent, and simplifies the tests, as less 
code would be needed to mock.

As RangerDaoManagerBase is used everywhere, and to avoid having huge patches, 
it would be better do it in smaller steps.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
b304e3e99 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java 
c26f0a576 
  security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 
7875bc2a8 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
32af4cd2d 
  security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 4a426b78a 
  security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java d29df930c 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 2a638f890 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b1ea280c9 
  security-admin/src/main/java/org/apache/ranger/common/StringUtil.java 
82afa2708 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java 
8c1cfd841 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
5dffc0ef2 
  security-admin/src/main/java/org/apache/ranger/db/XXAssetDao.java 1cd83badc 
  security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 
d383cf596 
  security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 
24a0e63ef 
  
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java 
808170323 
  security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 58bf4d891 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForAtlasResourceAndAccessTypeUpdate_J10016.java
 eed6a9e43 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForServiceVersionInfo_J10004.java
 68c80c170 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java 
0af7a1da2 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java
 6f9350da2 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 7df957973 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
 2bbf0d413 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 
08baf8907 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyWithAssignedIdService.java
 540a29eb2 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
 5cbe47ad3 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java
 d7256802a 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
 2ddb5f315 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
 315946e4f 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 
82eb252e6 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java
 89c451ee2 
  security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java 
28b9115fa 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java
 2e2c04f47 
  security-admin/src/main/java/org/apache/ranger/service/UserService.java 
9ca6a4fb3 
  security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java 
d5ca38548 
  security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java 
066bc6ae7 
  
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 
c96878d21 
  security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 
b3e7bd7d7 
  
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java
 7f3d0c70d 
  
security-admin/src/main/java/org/apache/ranger/service/XUserPermissionServiceBase.java
 bc6c21eae 
  security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 
22e290a66 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 
c9db90a0e 
  security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 
4f4298a95 
  security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 
2bf5ee6c9