Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-19 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208791
---


Ship it!




Ship It!

- pengjianhua


On 八月 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated 八月 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat 
> Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68682: RANGER-2214 Do some code improvement for the error message for KylinClient.java

2018-09-19 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68682/#review208790
---


Ship it!




Ship It!

- pengjianhua


On 九月 11, 2018, 3:30 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68682/
> ---
> 
> (Updated 九月 11, 2018, 3:30 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Nitin Galave, pengjianhua, 
> Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2214
> https://issues.apache.org/jira/browse/RANGER-2214
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Now the test connection get an error return, such as 401, the error message 
> always show 'got null response'
> 
> 
> Diffs
> -
> 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
>  9cf21aa67 
> 
> 
> Diff: https://reviews.apache.org/r/68682/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68676: RANGER-2212 Add multiple urls tips for the ‘Kylin URL’ configuration item when creating the kylin-plugin service

2018-09-19 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68676/#review208789
---


Ship it!




Ship It!

- pengjianhua


On 九月 10, 2018, 7:43 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68676/
> ---
> 
> (Updated 九月 10, 2018, 7:43 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat 
> Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2212
> https://issues.apache.org/jira/browse/RANGER-2212
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add multiple urls tips for the ‘Kylin URL’ configuration item:
> 1.For one url, eg.
> 'http://:7070'
> 2.For multiple urls (use , or ; delimiter), eg.
> 'http://:7070,http://:7070'
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
> cda352665 
> 
> 
> Diff: https://reviews.apache.org/r/68676/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

[jira] [Updated] (RANGER-2229) Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-09-19 Thread bhavik patel (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bhavik patel updated RANGER-2229:
-
Attachment: RANGER-2229.patch

> Perform graceful terminate with retries before doing forceful kill for 
> usersync and tagsync
> ---
>
> Key: RANGER-2229
> URL: https://issues.apache.org/jira/browse/RANGER-2229
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync, usersync
>Affects Versions: 1.1.0
>Reporter: suja s
>Assignee: bhavik patel
>Priority: Major
> Attachments: RANGER-2229.patch
>
>
> In ranger usersync and tagsync scripts, stop of the process is done 
> forcefully using kill -9.
> Suggestion is to do a graceful shutdown with retries and do a force kill only 
> if graceful shutdown is not successful.
> Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
> {noformat}
> lif [ "${action}" == "STOP" ]; then
>  WAIT_TIME_FOR_SHUTDOWN=2
>  NR_ITER_FOR_SHUTDOWN_CHECK=15
>  if [ -f "$pidf" ] ; then
>  pid=`cat $pidf` > /dev/null 2>&1
>  echo "Found Apache Ranger TagSync Service with pid $pid, Stopping..."
>  kill -9 $pid > /dev/null 2>&1
>  sleep 1 #Give kill -9 sometime to "kill"
>  if ps -p $pid > /dev/null; then
>  echo "Wow, even kill -9 failed, giving up! Sorry.."
>  else
>  rm -f $pidf
>  echo "Apache Ranger Tagsync Service pid = ${pid} has been stopped."
>  fi
>  else
>  echo "Ranger Tagsync Service not running"
>  fi
>  exit;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-19 Thread navi ramesh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208783
---


Ship it!




Ship It!

- navi ramesh


On 八月 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated 八月 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

[jira] [Assigned] (RANGER-2218) Service-Definition update should not allow updates to names of resources, access-types, conditions or data-masks

2018-09-19 Thread Sailaja Polavarapu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu reassigned RANGER-2218:
--

Assignee: Sailaja Polavarapu

> Service-Definition update should not allow updates to names of resources, 
> access-types,  conditions or data-masks
> -
>
> Key: RANGER-2218
> URL: https://issues.apache.org/jira/browse/RANGER-2218
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: master
>Reporter: Abhay Kulkarni
>Assignee: Sailaja Polavarapu
>Priority: Major
> Fix For: master, 2.0.0
>
>
> Updates to service definitions should not allow updating names of the 
> following components: 
>  * Resources
>  * Access types
>  * Policy conditions
>  * Data Masks
> In general, these updates are seldom needed and can be avoided by careful 
> design of service definition. Also, with a de-normalized database schema for 
> storing policies, it is expensive and inefficient to maintain and lookup 
> mapping from internal IDs to names for each of these components. By not 
> allowing updates to these names, there is no need to maintain ( or reference) 
> such mappings after updating (or reading) policy when using de-normalized 
> database schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files

2018-09-19 Thread Csaba Koncz (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621209#comment-16621209
 ] 

Csaba Koncz commented on RANGER-2220:
-

Here is the promised patch: [https://reviews.apache.org/r/68770/]

It is quite large as it includes RequireJS optimizer source.

Unfortunately I could thoroughly test it only on version 0.7.0 (the one 
included in HDP 2.6.5).

For the master branch I only loaded the UI and checked that there are no 
RequireJS errors (did not have a compatible backend to check the functionality).

> Admin UI loads slowly because of many small JavaScript files
> 
>
> Key: RANGER-2220
> URL: https://issues.apache.org/jira/browse/RANGER-2220
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 1.1.0
>Reporter: Csaba Koncz
>Assignee: Dhaval Rajpara
>Priority: Minor
>
> The Admin UI web page loads slowly after login (~10 seconds or more, 
> depending on network conditions)
> This is due to the ~140 small JavaScript files that need to be downloaded 
> before the UI can be presented to the user.
> Compressing/concatenating (=minifying) JS resources and downloading them in a 
> single step can improve the situation.
> Prototyped a solution for version 0.7 (using RequireJS Optimizer), will try 
> to port it to the master version.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

(Updated Sept. 19, 2018, 9 p.m.)


Review request for ranger.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description (updated)
---

Maven build modified so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs
-

  security-admin/pom.xml 84bbd6650 
  security-admin/scripts-js/minify.build.js PRE-CREATION 
  security-admin/scripts-js/r.js PRE-CREATION 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/1/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208773
---




security-admin/pom.xml
Line 563 (original), 564 (patched)


these old includes had no effect (pat



security-admin/pom.xml
Lines 572 (patched)


lines staring with  are commented out



security-admin/pom.xml
Lines 576 (patched)


lines in the form  are transformed into  
CONTENT, i.e. the CONTENT becomes uncommented.



security-admin/pom.xml
Lines 607 (patched)


Assume JDK8 (Nashorn interpreter (jjs) should be available)



security-admin/scripts-js/minify.build.js
Lines 1 (patched)


This file is only for manually testing the minification without running mvn 
package. It is not used by the maven build.



security-admin/scripts-js/r.js
Lines 1 (patched)


RequireJS Optimizer included unchanged.



security-admin/src/main/webapp/index.html
Lines 129 (patched)


The line starting with  loads the individual JS files



security-admin/src/main/webapp/index.html
Lines 130 (patched)


The " This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 19, 2018, 8:33 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modifies so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/scripts-js/minify.build.js PRE-CREATION 
>   security-admin/scripts-js/r.js PRE-CREATION 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/1/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

Review request for ranger.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description
---

Maven build modifies so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs
-

  security-admin/pom.xml 84bbd6650 
  security-admin/scripts-js/minify.build.js PRE-CREATION 
  security-admin/scripts-js/r.js PRE-CREATION 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/1/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

[jira] [Created] (RANGER-2230) Update Atlas version to 1.1.0

2018-09-19 Thread Velmurugan Periasamy (JIRA) 
Velmurugan Periasamy created RANGER-2230:


 Summary: Update Atlas version to 1.1.0
 Key: RANGER-2230
 URL: https://issues.apache.org/jira/browse/RANGER-2230
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Velmurugan Periasamy
Assignee: Velmurugan Periasamy
 Fix For: 1.2.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (RANGER-2229) Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-09-19 Thread Mehul Parikh (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mehul Parikh reassigned RANGER-2229:


Assignee: bhavik patel

> Perform graceful terminate with retries before doing forceful kill for 
> usersync and tagsync
> ---
>
> Key: RANGER-2229
> URL: https://issues.apache.org/jira/browse/RANGER-2229
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync, usersync
>Affects Versions: 1.1.0
>Reporter: suja s
>Assignee: bhavik patel
>Priority: Major
>
> In ranger usersync and tagsync scripts, stop of the process is done 
> forcefully using kill -9.
> Suggestion is to do a graceful shutdown with retries and do a force kill only 
> if graceful shutdown is not successful.
> Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
> {noformat}
> lif [ "${action}" == "STOP" ]; then
>  WAIT_TIME_FOR_SHUTDOWN=2
>  NR_ITER_FOR_SHUTDOWN_CHECK=15
>  if [ -f "$pidf" ] ; then
>  pid=`cat $pidf` > /dev/null 2>&1
>  echo "Found Apache Ranger TagSync Service with pid $pid, Stopping..."
>  kill -9 $pid > /dev/null 2>&1
>  sleep 1 #Give kill -9 sometime to "kill"
>  if ps -p $pid > /dev/null; then
>  echo "Wow, even kill -9 failed, giving up! Sorry.."
>  else
>  rm -f $pidf
>  echo "Apache Ranger Tagsync Service pid = ${pid} has been stopped."
>  fi
>  else
>  echo "Ranger Tagsync Service not running"
>  fi
>  exit;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (RANGER-2215) Can't copy and paste multiple paths into Ranger Admin UI for HDFS create policy

2018-09-19 Thread Nitin Galave (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620169#comment-16620169
 ] 

Nitin Galave edited comment on RANGER-2215 at 9/19/18 6:30 AM:
---

Committed to 
[master|https://github.com/apache/ranger/commit/90979b4a8d78055fe04a692c6c86c7de33ab07ad]
 branch.


was (Author: nitin.galave):
Committed to [master| 
https://github.com/apache/ranger/commit/90979b4a8d78055fe04a692c6c86c7de33ab07ad]
 branch.

> Can't copy and paste multiple paths into Ranger Admin UI for HDFS create 
> policy
> ---
>
> Key: RANGER-2215
> URL: https://issues.apache.org/jira/browse/RANGER-2215
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master
>
> Attachments: RANGER-2215.patch
>
>
> Can't copy and paste multiple paths into Ranger Admin UI for HDFS create 
> policy
> We have noticed an interesting issue with the Ranger Admin web UI. If you are 
> using a Hive policy, you can paste in multiple lines from the clipboard, and 
> each line will become a database, table, or column as desired. But for HDFS 
> policies, multiple HDFS paths cannot be pasted in from the clipboard 
> properly. They will just be treated as a single path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2215) Can't copy and paste multiple paths into Ranger Admin UI for HDFS create policy

2018-09-19 Thread Nitin Galave (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620169#comment-16620169
 ] 

Nitin Galave commented on RANGER-2215:
--

Committed to [master| 
https://github.com/apache/ranger/commit/90979b4a8d78055fe04a692c6c86c7de33ab07ad]
 branch.

> Can't copy and paste multiple paths into Ranger Admin UI for HDFS create 
> policy
> ---
>
> Key: RANGER-2215
> URL: https://issues.apache.org/jira/browse/RANGER-2215
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master
>
> Attachments: RANGER-2215.patch
>
>
> Can't copy and paste multiple paths into Ranger Admin UI for HDFS create 
> policy
> We have noticed an interesting issue with the Ranger Admin web UI. If you are 
> using a Hive policy, you can paste in multiple lines from the clipboard, and 
> each line will become a database, table, or column as desired. But for HDFS 
> policies, multiple HDFS paths cannot be pasted in from the clipboard 
> properly. They will just be treated as a single path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files

2018-09-19 Thread Mehul Parikh (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mehul Parikh reassigned RANGER-2220:


Assignee: Dhaval Rajpara

> Admin UI loads slowly because of many small JavaScript files
> 
>
> Key: RANGER-2220
> URL: https://issues.apache.org/jira/browse/RANGER-2220
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 1.1.0
>Reporter: Csaba Koncz
>Assignee: Dhaval Rajpara
>Priority: Minor
>
> The Admin UI web page loads slowly after login (~10 seconds or more, 
> depending on network conditions)
> This is due to the ~140 small JavaScript files that need to be downloaded 
> before the UI can be presented to the user.
> Compressing/concatenating (=minifying) JS resources and downloading them in a 
> single step can improve the situation.
> Prototyped a solution for version 0.7 (using RequireJS Optimizer), will try 
> to port it to the master version.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (RANGER-2229) Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-09-19 Thread suja s (JIRA) 
suja s created RANGER-2229:
--

 Summary: Perform graceful terminate with retries before doing 
forceful kill for usersync and tagsync
 Key: RANGER-2229
 URL: https://issues.apache.org/jira/browse/RANGER-2229
 Project: Ranger
  Issue Type: Bug
  Components: tagsync, usersync
Affects Versions: 1.1.0
Reporter: suja s


In ranger usersync and tagsync scripts, stop of the process is done forcefully 
using kill -9.
Suggestion is to do a graceful shutdown with retries and do a force kill only 
if graceful shutdown is not successful.

Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
{noformat}
lif [ "${action}" == "STOP" ]; then
 WAIT_TIME_FOR_SHUTDOWN=2
 NR_ITER_FOR_SHUTDOWN_CHECK=15
 if [ -f "$pidf" ] ; then
 pid=`cat $pidf` > /dev/null 2>&1
 echo "Found Apache Ranger TagSync Service with pid $pid, Stopping..."
 kill -9 $pid > /dev/null 2>&1
 sleep 1 #Give kill -9 sometime to "kill"
 if ps -p $pid > /dev/null; then
 echo "Wow, even kill -9 failed, giving up! Sorry.."
 else
 rm -f $pidf
 echo "Apache Ranger Tagsync Service pid = ${pid} has been stopped."
 fi
 else
 echo "Ranger Tagsync Service not running"
 fi
 exit;
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68684: RANGER-2215: Can't copy and paste multiple paths into Ranger Admin UI for HDFS create policy

2018-09-19 Thread Mehul Parikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68684/#review208748
---


Ship it!




Ship It!

- Mehul Parikh


On Sept. 11, 2018, 1:26 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68684/
> ---
> 
> (Updated Sept. 11, 2018, 1:26 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2215
> https://issues.apache.org/jira/browse/RANGER-2215
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We have noticed an interesting issue with the Ranger Admin web UI. If you are 
> using a Hive policy, you can paste in multiple lines from the clipboard, and 
> each line will become a database, table, or column as desired. But for HDFS 
> policies, multiple HDFS paths cannot be pasted in from the clipboard 
> properly. They will just be treated as a single path.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> e3d9635 
> 
> 
> Diff: https://reviews.apache.org/r/68684/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that multiple resource Paths can be copy-paste in HDFS Policy 
> separated by comma/space
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>