[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11

2021-05-30 Thread Pradeep Agrawal (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354213#comment-17354213
 ] 

Pradeep Agrawal commented on RANGER-3243:
-

[~mgrigorov] : Which command did you use for build and in which environment you 
tried the build.

> Build fails on JDK 8 and 11
> ---
>
> Key: RANGER-3243
> URL: https://issues.apache.org/jira/browse/RANGER-3243
> Project: Ranger
>  Issue Type: Task
>  Components: build-infra
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The build of current master branch fails - 
> [https://travis-ci.com/github/apache/ranger/builds/223139469]
> There are several issues:
> [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) 
> org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory
>  was not able to import com.google.common.base.Throwables.throwIfUnchecked 
> because it was coming from an old copy of Guava's Throwables shaded in 
> hive-exec.
> By replacing hive-exec with orc-core in agents-audit module all depending 
> modules use their preferred version of Guava (26.0-jre)
> [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) 
> RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a 
> class that is not available in Java 9+ and this breaks the compilation.
> This should use reflection to load SunPKCS11 class dynamically.
> [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of 
> JDK 11+
> [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 
> Assert.assertThat() is deprecated in favour of Hamcrest's 
> MatcherAssert.assertThat(). This fixes a compilation issue with JDK11.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73367: RANGER-3294:AccessResult attribute with isAudited as false not filtered in Ranger Audit Filter

2021-05-30 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73367/
---

(Updated May 30, 2021, 7:59 a.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Changes
---

Fixed review comments


Bugs: RANGER-3294
https://issues.apache.org/jira/browse/RANGER-3294


Repository: ranger


Description
---

RANGER-3294:AccessResult attribute with isAudited as false not filtered in 
Ranger Audit Filter


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
 7b34f77da 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 ecfc9ad14 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 4d7fb6c87 
  
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
 539d4c148 
  hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java 
c5fe8a332 
  
hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java
 e96ea5c12 
  hdfs-agent/src/test/resources/hdfs_version_3.0/hdfs-policies.json a3fd96813 
  hdfs-agent/src/test/resources/ranger-hdfs-security.xml 2c7f22fa9 
  
plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
 1f965823c 


Diff: https://reviews.apache.org/r/73367/diff/3/

Changes: https://reviews.apache.org/r/73367/diff/2-3/


Testing (updated)
---

- Verified in local VM for audit filter to filter out Allow and deny request in 
Hive.
- Verified YARN and HDFS fallback and audit related to it.
- Fixed failing Unit test based on this change.


Thanks,

Ramesh Mani