Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223249
---


Ship it!




Ship It!

- Nitin Galave


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> ---
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
> https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that 
> user can customize if required.
> 
> 
> Diffs
> -
> 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
>  137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> ---
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 73466: RANGER-3343: Ranger policy cache is incorrect in some scenario

2021-07-19 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73466/
---

Review request for ranger, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3343
https://issues.apache.org/jira/browse/RANGER-3343


Repository: ranger


Description
---

There are two external users : diasmi(user role) and diasmi_admin (admin role).

diasmi is granted a delegated admin privilege on some resource.
Log in to Ranger admin GUI from as diasmi_admin and change the policy (first 
policy item) for the resource.
Wait for policy sync. policy cache json is correct and it has both policy item 
entries.
Log in to Ranger admin GUI as diasmi user and change the policy to add another 
policy item (second policy-item) with the delegated-admin box unchecked.
Wait for policy sync. policy cache json is incorrect and it has only first 
policy item entry.

Ensured that the policy cache is not modified during creation of 
delegated-admin processing policy engine.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
 99ae598a0 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 03e37fe3d 


Diff: https://reviews.apache.org/r/73466/diff/1/


Testing
---

Tested the scenario and ensured that the Policy-cache is not modified, and the 
downloaded policies are same as the database copy.


Thanks,

Abhay Kulkarni

Re: Review Request 73451: RANGER-3334:Enhance Ranger admin REST Client to use cookie for policy, tag and role download

2021-07-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73451/#review223248
---




knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
Lines 658 (patched)


Line #658 can cause isRangerCookieEnabled to be set to false temporarily. 
Consider the following reorg:

  if (isRangerCookieEnabled) {
String sessionCookie = null; 

for (String cookieName : cookieMap.keySet()) {
  if (StringUtils.equalsIgnoreCase(cookieName, rangerAdminCookieName)) {
sessionCookie = cookieMap.get(cookieName);

break;
  }
}

policyDownloadSessionId= sessionCookie; 
isValidPolicyDownloadSessionCookie = 
StringUtils.isNotBlank(policyDownloadSessionId);
  }

Similar updates for following methods as well:
 - setCookieReceivedFromTagDownloadSession()
 - setCookieReceivedFromRoleDownloadSession()



knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
Lines  (patched)


Is 'if' at # necessary? i.e. it is not necessary to check whether 
cookie value has changed or not. Consider replacing # - #1116 with:
  if (cookieName.equalsIgnoreCase(rangerAdminCookieName)) {
roleDownloadSessionId= cookieMap.get(cookieName);
isValidRoleDownloadSessionCookie = 
StringUtils.isNotEmpty(roleDownloadSessionId);

break;
  }


- Madhan Neethiraj


On July 10, 2021, 6:57 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73451/
> ---
> 
> (Updated July 10, 2021, 6:57 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3334
> https://issues.apache.org/jira/browse/RANGER-3334
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-3334:Enhance Ranger admin REST Client to use cookie for policy, tag 
> and role download
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java
>  e0d7a9b71 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java
>  ed2dffd91 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  216b6b2a9 
>   
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
>  fa17f5d4b 
> 
> 
> Diff: https://reviews.apache.org/r/73451/diff/1/
> 
> 
> Testing
> ---
> 
> - Testing done in local vm for policy, tag and role download.
> - Access log in ranger admin will show the 401 for authentication call for 
> the first download and if there are no changes only 304 response will be 
> there. There won't be any 401 kerberos authentication call each time when 
> downloads are happening.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

[jira] [Created] (RANGER-3343) Ranger policy cache is incorrect in some scenario

2021-07-19 Thread Abhay Kulkarni (Jira) 
Abhay Kulkarni created RANGER-3343:
--

 Summary: Ranger policy cache is incorrect in some scenario
 Key: RANGER-3343
 URL: https://issues.apache.org/jira/browse/RANGER-3343
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni


Steps are : # There are two external users : diasmi(user role) and diasmi_admin 
(admin role).
 # diasmi is granted a delegated admin privilege on some resource.
 # Log in to Ranger admin GUI from as diasmi_admin and change the policy (first 
policy item) for the resource.
 # Wait for policy sync. policy cache json is correct and it has both policy 
item entries.
 # Log in to Ranger admin GUI as diasmi user and change the policy to add 
another policy item (second policy-item) with the delegated-admin box unchecked.
 # Wait for policy sync. policy cache json is incorrect and it has only first 
policy item entry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223246
---




embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 267 (patched)


Consider replacing #267 with the following (to reuse config value already 
read):
  webappCtx.setWorkDir(workDirPath);



embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 270 (patched)


Consider including value of workDirPath in the log message, to help 
troubleshooting:
  LOG.fine("Skipping to set tomcat server work directory, '" + workDirPath 
+ "', as its is blank or directory does not exist.");


- Madhan Neethiraj


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> ---
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
> https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that 
> user can customize if required.
> 
> 
> Diffs
> -
> 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
>  137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> ---
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

[jira] [Updated] (RANGER-3122) Support delegate-admin for specific permissions

2021-07-19 Thread Velmurugan Periasamy (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-3122:
-
Fix Version/s: 2.2.0
   3.0.0

> Support delegate-admin for specific permissions
> ---
>
> Key: RANGER-3122
> URL: https://issues.apache.org/jira/browse/RANGER-3122
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently delegate-admin cannot be marked for specific permissions. It is 
> all-or-nothing for the permissions defined in resource policy. Ranger should 
> have ability for granting delegate-admin for specific permissions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73443: RANGER-3329: Request for _any access-type is denied only when on all access-types are denied

2021-07-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73443/#review223245
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 18, 2021, 5:43 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73443/
> ---
> 
> (Updated July 18, 2021, 5:43 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3329
> https://issues.apache.org/jira/browse/RANGER-3329
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently a request for _any access-type is denied only if all access-types 
> in the service-def are denied by policies. Instead of this, the policy-engine 
> should deny _any access if there are no allowed accesses, and at least one of 
> the access-type is denied. This will help address following usecase:
> 
> when accessTypeRestrictions is defined on a resource i.e. only a subset of 
> access-types are shown in policy-UI, it will not be possible to create 
> policies that deny all accesses. In such cases, the proposed change will 
> enable denying _any access-type with only subset of access-types denied.
> 
> The fix is to deny the access with type _any only if all of access-types 
> "specified in the denying policy" are explicitly denied by policies.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java
>  74a7a2615 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
>  3c0e32c2e 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
>  03e37fe3d 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java
>  696a3f6eb 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java
>  f8eba5f96 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_descendant_tags.json
>  934655ba9 
>   agents-common/src/test/resources/policyengine/test_policyengine_hive.json 
> bd2f67b68 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 
> a8ec02733 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_for_show_databases.json
>  f42df3eab 
> 
> 
> Diff: https://reviews.apache.org/r/73443/diff/4/
> 
> 
> Testing
> ---
> 
> Passed all existing test cases.
> Created a unit test for the use-case outlined in the JIRA, and ensured that 
> it passes.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223244
---


Ship it!




Ship It!

- Pradeep Agrawal


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> ---
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
> https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that 
> user can customize if required.
> 
> 
> Diffs
> -
> 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
>  137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> ---
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223243
---


Ship it!




Ship It!

- Pradeep Agrawal


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> ---
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
> https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that 
> user can customize if required.
> 
> 
> Diffs
> -
> 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
>  137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> ---
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

[jira] [Commented] (RANGER-3328) RANGER-KMS : code improvement

2021-07-19 Thread Dhaval Shah (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383340#comment-17383340
 ] 

Dhaval Shah commented on RANGER-3328:
-

Committed in master:
https://github.com/apache/ranger/commit/2f569ee82106c00da57e9447baf1a9bbf86b26e3

> RANGER-KMS : code improvement
> -
>
> Key: RANGER-3328
> URL: https://issues.apache.org/jira/browse/RANGER-3328
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Mateen N Mansoori
>Priority: Minor
>
> The following Hadoop kms changes need to be ported in ranger-kms : 
> [HADOOP-14784|https://issues.apache.org/jira/browse/HADOOP-14784], 
> [HADOOP-15234|https://issues.apache.org/jira/browse/HADOOP-15234], 
> [HADOOP-15455|https://issues.apache.org/jira/browse/HADOOP-15455], 
> [HADOOP-15418|https://issues.apache.org/jira/browse/HADOOP-15418], 
> RangerKeyStoreProvider : remove duplicate check.
> RangerHSM : improve null check



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Vishal Suvagia via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/
---

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam 
Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, 
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Bugs: RANGER-3342
https://issues.apache.org/jira/browse/RANGER-3342


Repository: ranger


Description
---

Currently the work directory for Ranger embedded server is not configurable.
Need to make the work directory configurable to a custom location so that user 
can customize if required.


Diffs
-

  
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
 137168259d9aa55548a3953aff7def6d7228a9e5 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
8842071982f7a5831db4dcbcffd00d6a22a6fb2c 


Diff: https://reviews.apache.org/r/73463/diff/1/


Testing
---

Validated the changes locally.


Thanks,

Vishal Suvagia

[jira] [Updated] (RANGER-3342) Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Vishal Suvagia (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vishal Suvagia updated RANGER-3342:
---
Attachment: RANGER-3342.patch

> Need to make the Ranger embedded server work directory configurable
> ---
>
> Key: RANGER-3342
> URL: https://issues.apache.org/jira/browse/RANGER-3342
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Vishal Suvagia
>Assignee: Vishal Suvagia
>Priority: Major
> Attachments: RANGER-3342.patch
>
>
> Currently the work directory for Ranger embedded server is not configurable. 
> Need to make the work directory configurable to a custom location so that 
> user can customize if required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73447: RANGER-3328 : RANGER-KMS code improvement

2021-07-19 Thread Mehul Parikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73447/#review223242
---


Ship it!




Ship It!

- Mehul Parikh


On July 12, 2021, 11:01 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73447/
> ---
> 
> (Updated July 12, 2021, 11:01 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3328
> https://issues.apache.org/jira/browse/RANGER-3328
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The following Hadoop kms changes need to be ported in ranger-kms : 
> HADOOP-14784, HADOOP-15234, HADOOP-15455, HADOOP-15418
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java a531f32f6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> 011318b4b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java 
> 5df58e7f8 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
>  ca13a5390 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 
> 1efc5219c 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java
>  fb9a261eb 
>   
> kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73447/diff/2/
> 
> 
> Testing
> ---
> 
> Ran : mvn clean compile test verify install => Build was successful 
> Testing : 
>  - Performed key crud from Ranger KMS UI and did the same from hadoop CLI.
>  - Perfromed the file encryption decryption using zone.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73447: RANGER-3328 : RANGER-KMS code improvement

2021-07-19 Thread Dhaval Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73447/#review223241
---


Ship it!




Ship It!

- Dhaval Shah


On July 12, 2021, 11:01 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73447/
> ---
> 
> (Updated July 12, 2021, 11:01 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3328
> https://issues.apache.org/jira/browse/RANGER-3328
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The following Hadoop kms changes need to be ported in ranger-kms : 
> HADOOP-14784, HADOOP-15234, HADOOP-15455, HADOOP-15418
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java a531f32f6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> 011318b4b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java 
> 5df58e7f8 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
>  ca13a5390 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 
> 1efc5219c 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java
>  fb9a261eb 
>   
> kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73447/diff/2/
> 
> 
> Testing
> ---
> 
> Ran : mvn clean compile test verify install => Build was successful 
> Testing : 
>  - Performed key crud from Ranger KMS UI and did the same from hadoop CLI.
>  - Perfromed the file encryption decryption using zone.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>