[jira] [Comment Edited] (RANGER-3285) expose user source details in ranger UI

[Abhishek Kumar (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403491#comment-17403491
 ] 

Abhishek Kumar edited comment on RANGER-3285 at 8/24/21, 3:28 AM:
--

Apache 
[Commit|https://github.com/apache/ranger/commit/224e5fb50055929d506f7554c1b27ed8d081f5d2]


was (Author: abhi_2110):
Apache Commit

> expose user source details in ranger UI
> ---
>
> Key: RANGER-3285
> URL: https://issues.apache.org/jira/browse/RANGER-3285
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Deepesh Joshi
>Assignee: Abhishek Kumar
>Priority: Major
>
> In latest version two new attributes are added when users are synced.
> sync source and sync source url
> Those attributes are present in database but not exposed to UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3285) expose user source details in ranger UI

[Abhishek Kumar (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403491#comment-17403491
 ] 

Abhishek Kumar commented on RANGER-3285:


Apache Commit

> expose user source details in ranger UI
> ---
>
> Key: RANGER-3285
> URL: https://issues.apache.org/jira/browse/RANGER-3285
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Deepesh Joshi
>Assignee: Abhishek Kumar
>Priority: Major
>
> In latest version two new attributes are added when users are synced.
> sync source and sync source url
> Those attributes are present in database but not exposed to UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73531: RANGER-3374: Syncing 300K+ user group mappings to ranger is causing ranger to go out of memory

[Sailaja Polavarapu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73531/
---

(Updated Aug. 23, 2021, 10:27 p.m.)


Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and 
Velmurugan Periasamy.


Changes
---

Minor fix of the log message


Bugs: RANGER-3374
https://issues.apache.org/jira/browse/RANGER-3374


Repository: ranger


Description
---

Creating new DB transaction for add/update of user group mapping from Ranger 
Usersync.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 7b29f3d85 
  security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 
6c0289c1c 


Diff: https://reviews.apache.org/r/73531/diff/2/

Changes: https://reviews.apache.org/r/73531/diff/1-2/


Testing
---

1. Patched cluster and verified with almost 1million user group mappings.


Thanks,

Sailaja Polavarapu

[jira] [Assigned] (RANGER-3379) Performance Analysis tool for Ranger Policy REST API

[Sailaja Polavarapu (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu reassigned RANGER-3379:
--

Assignee: Sailaja Polavarapu

> Performance Analysis tool for Ranger Policy REST API
> 
>
> Key: RANGER-3379
> URL: https://issues.apache.org/jira/browse/RANGER-3379
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Steven Ramirez
>Assignee: Sailaja Polavarapu
>Priority: Major
>
> The tool will focus on the creation, capture, and analysis of critical 
> performance metrics of Ranger REST API for policy management. The analysis of 
> these metrics will help predict trends of latencies suggesting performance 
> issues. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3379) Performance Analysis tool for Ranger Policy REST API

[Steven Ramirez (Jira)]

Steven Ramirez created RANGER-3379:
--

 Summary: Performance Analysis tool for Ranger Policy REST API
 Key: RANGER-3379
 URL: https://issues.apache.org/jira/browse/RANGER-3379
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Steven Ramirez


The tool will focus on the creation, capture, and analysis of critical 
performance metrics of Ranger REST API for policy management. The analysis of 
these metrics will help predict trends of latencies suggesting performance 
issues. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73486: RANGER-3350: Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in current hive beeline session

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73486/#review223376
---


Ship it!




Ship It!

- Abhay Kulkarni


On Aug. 18, 2021, 5 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73486/
> ---
> 
> (Updated Aug. 18, 2021, 5 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3350
> https://issues.apache.org/jira/browse/RANGER-3350
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-3350: Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the 
> role set in current hive beeline session
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  8621f73e2 
> 
> 
> Diff: https://reviews.apache.org/r/73486/diff/2/
> 
> 
> Testing
> ---
> 
> - Verified set current roles command 
> - Verified get current roles command
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 73354: RANGER-3285: Introduce new column Sync Source

[Pradeep Agrawal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73354/#review223375
---


Ship it!




Ship It!

- Pradeep Agrawal


On Aug. 19, 2021, 4:24 a.m., Abhishek  Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73354/
> ---
> 
> (Updated Aug. 19, 2021, 4:24 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3285
> https://issues.apache.org/jira/browse/RANGER-3285
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> New features implemented in this patch:
> 1. A new coulmn 'sync_source' is available for db tables x_user, 
> x_portal_user and x_group. This column is also a search field for REST API 
> queries.
> 2. Tested the functionality on containers for proper functioning.
> 3. Front-End side changes to follow soon.
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 1ba3e69e8 
>   
> security-admin/db/mysql/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 021c34c77 
>   
> security-admin/db/oracle/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 89e9e77a0 
>   
> security-admin/db/postgres/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  b90a48e0a 
>   
> security-admin/db/sqlanywhere/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 7e03289dd 
>   
> security-admin/db/sqlserver/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java e72a7a733 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 38b06d1b2 
>   security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 
> 996a9e1d4 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java 
> ed69f385e 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 
> 4c648aeb1 
>   security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 
> 44eebcfb7 
>   
> security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java 
> cde91dc52 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserServiceBase.java
>  85e4b8412 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 
> 0728eea2a 
>   
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 
> 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXGroup.java ed6470425 
>   security-admin/src/main/java/org/apache/ranger/view/VXPortalUser.java 
> b6035b236 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   
> ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XGroupInfo.java 
> a80e5dc1b 
>   ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XUserInfo.java 
> bc1a6655c 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  65e26fe06 
> 
> 
> Diff: https://reviews.apache.org/r/73354/diff/4/
> 
> 
> Testing
> ---
> 
> Tested the changes on postgres:
> 1. New column is present on the tables x_user, x_portal_user and x_group.
> 2. REST API calls (POST) made for user and group result in persistence of 
> data for syncSource: verified via db queries.
> 3. The syncSource field appears in the response for a GET at the user and 
> group APIs with correct data.
> 
> 
> Thanks,
> 
> Abhishek  Kumar
> 
>

Re: Review Request 73354: RANGER-3285: Introduce new column Sync Source

[Sailaja Polavarapu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73354/#review223374
---


Ship it!




Ship It!

- Sailaja Polavarapu


On Aug. 19, 2021, 4:24 a.m., Abhishek  Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73354/
> ---
> 
> (Updated Aug. 19, 2021, 4:24 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3285
> https://issues.apache.org/jira/browse/RANGER-3285
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> New features implemented in this patch:
> 1. A new coulmn 'sync_source' is available for db tables x_user, 
> x_portal_user and x_group. This column is also a search field for REST API 
> queries.
> 2. Tested the functionality on containers for proper functioning.
> 3. Front-End side changes to follow soon.
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 1ba3e69e8 
>   
> security-admin/db/mysql/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 021c34c77 
>   
> security-admin/db/oracle/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 89e9e77a0 
>   
> security-admin/db/postgres/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  b90a48e0a 
>   
> security-admin/db/sqlanywhere/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 7e03289dd 
>   
> security-admin/db/sqlserver/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java e72a7a733 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 38b06d1b2 
>   security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 
> 996a9e1d4 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java 
> ed69f385e 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 
> 4c648aeb1 
>   security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 
> 44eebcfb7 
>   
> security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java 
> cde91dc52 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserServiceBase.java
>  85e4b8412 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 
> 0728eea2a 
>   
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 
> 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXGroup.java ed6470425 
>   security-admin/src/main/java/org/apache/ranger/view/VXPortalUser.java 
> b6035b236 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   
> ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XGroupInfo.java 
> a80e5dc1b 
>   ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XUserInfo.java 
> bc1a6655c 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  65e26fe06 
> 
> 
> Diff: https://reviews.apache.org/r/73354/diff/4/
> 
> 
> Testing
> ---
> 
> Tested the changes on postgres:
> 1. New column is present on the tables x_user, x_portal_user and x_group.
> 2. REST API calls (POST) made for user and group result in persistence of 
> data for syncSource: verified via db queries.
> 3. The syncSource field appears in the response for a GET at the user and 
> group APIs with correct data.
> 
> 
> Thanks,
> 
> Abhishek  Kumar
> 
>

[jira] [Updated] (RANGER-3371) Update algorithm to build Ranger policy-database object from Ranger policy-view object

[Velmurugan Periasamy (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-3371:
-
Fix Version/s: 2.2.0
   3.0.0

> Update algorithm to build Ranger policy-database object from Ranger 
> policy-view object
> --
>
> Key: RANGER-3371
> URL: https://issues.apache.org/jira/browse/RANGER-3371
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> The algorithm to build Ranger policy database object from the Ranger policy 
> view object leaves some fields (guid, policy-type, etc.) un-initialized 
> during policy creation. Values of all fields whose values are known when 
> database policy object was created need to be initialized so that the 
> policy_text field-value can be used to recreate the original policy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73539: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs - follow-up

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73539/#review223373
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 23, 2021, 2:57 p.m., Kishor Gollapalliwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73539/
> ---
> 
> (Updated Aug. 23, 2021, 2:57 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3348
> https://issues.apache.org/jira/browse/RANGER-3348
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Remove hard-coded 'true' for 'forceDelete' request param in delete user & 
> group APIs
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_ranger/client/ranger_client.py dc69b045d 
> 
> 
> Diff: https://reviews.apache.org/r/73539/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean compile package install
> Python client - create service
> Python client - create policy
> Python client - delete policy
> Python client - delete service
> Python client - delete group
> Python client - delete user
> Python client - delete role
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>

[jira] [Commented] (RANGER-3348) Add user & group delete functionality in Apache Ranger Python APIs

[Kishor Gollapalliwar (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403220#comment-17403220
 ] 

Kishor Gollapalliwar commented on RANGER-3348:
--

Created follow-up RR: https://reviews.apache.org/r/73539/

> Add user & group delete functionality in Apache Ranger Python APIs
> --
>
> Key: RANGER-3348
> URL: https://issues.apache.org/jira/browse/RANGER-3348
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Kishor Gollapalliwar
>Assignee: Kishor Gollapalliwar
>Priority: Major
>
> Create class named *RangerClientPrivate* in 
> [ranger_client.py|https://github.com/apache/ranger/blob/master/intg/src/main/python/apache_ranger/client/ranger_client.py],
>  which will contains delete user/group defs with implementation using 
> non-public user/ group delete Ranger Admin APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73539: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs - follow-up

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73539/
---

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, and 
Velmurugan Periasamy.


Bugs: RANGER-3348
https://issues.apache.org/jira/browse/RANGER-3348


Repository: ranger


Description
---

Remove hard-coded 'true' for 'forceDelete' request param in delete user & group 
APIs


Diffs
-

  intg/src/main/python/apache_ranger/client/ranger_client.py dc69b045d 


Diff: https://reviews.apache.org/r/73539/diff/1/


Testing
---

mvn clean compile package install
Python client - create service
Python client - create policy
Python client - delete policy
Python client - delete service
Python client - delete group
Python client - delete user
Python client - delete role


Thanks,

Kishor Gollapalliwar

Re: Review Request 73535: RANGER-3376: Add policy_guid column in x_policy_change_log table

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73535/#review223372
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 23, 2021, 11:09 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73535/
> ---
> 
> (Updated Aug. 23, 2021, 11:09 a.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3376
> https://issues.apache.org/jira/browse/RANGER-3376
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:**
> Currently x_policy_change_log table has policy_id column and it does not have 
> its guid there. 
> For few operations we might need guid of the policy, if its in the same table 
> then it shall reduce the loopup time.
> 
> **Proposed Solution:**
> Add policy_guid column in the x_policy_change_log table for fresh and upgrade 
> case and update the policy_guid column value also whenever any entry is added 
> for a policy change event goes to the x_policy_change_log table.
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 1ba3e69e8 
>   
> security-admin/db/mysql/patches/056-add-policyguid-in-x_policy_change_log.sql 
> PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 021c34c77 
>   
> security-admin/db/oracle/patches/056-add-policyguid-in-x_policy_change_log.sql
>  PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 89e9e77a0 
>   
> security-admin/db/postgres/patches/056-add-policyguid-in-x_policy_change_log.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  b90a48e0a 
>   
> security-admin/db/sqlanywhere/patches/056-add-policyguid-in-x_policy_change_log.sql
>  PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 7e03289dd 
>   
> security-admin/db/sqlserver/patches/056-add-policyguid-in-x_policy_change_log.sql
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> b9a926b33 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java 
> bc48d4a25 
> 
> 
> Diff: https://reviews.apache.org/r/73535/diff/1/
> 
> 
> Testing
> ---
> 
> Tested the patch for fresh and upgrade case in MySQL, Oracle, PostGres, MSSQL 
> db flavor. 
> Column policy_guid was added in the x_policy_change_log table.
> policy_guid values was updated for each policy change event in the 
> x_policy_change_log table.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 73525: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs

[Kishor Gollapalliwar]

> On Aug. 19, 2021, 2:56 p.m., Madhan Neethiraj wrote:
> > intg/src/main/python/apache_ranger/client/ranger_client.py
> > Lines 478 (patched)
> > 
> >
> > 'forceDelete' is hardcoded to 'true' here. Consider adding a parameter 
> > with default value as true:
> >   def delete_user(self, userName, execUser, forceDelete=true):

I will create a follow-up patch to handle this comment.


> On Aug. 19, 2021, 2:56 p.m., Madhan Neethiraj wrote:
> > intg/src/main/python/apache_ranger/client/ranger_client.py
> > Lines 480 (patched)
> > 
> >
> > 'forceDelete' is hardcoded to 'true' here. Consider adding a parameter 
> > with default value as true:
> >   def delete_group(self, userName, execUser, forceDelete=true):

I will create a follow-up patch to handle this comment.


- Kishor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73525/#review223362
---


On Aug. 18, 2021, 12:39 p.m., Kishor Gollapalliwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73525/
> ---
> 
> (Updated Aug. 18, 2021, 12:39 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3348
> https://issues.apache.org/jira/browse/RANGER-3348
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Create class named RangerClientPrivate in ranger_client.py, which will 
> contains delete user/group defs with implementation using non-public user/ 
> group delete Ranger Admin APIs.
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_ranger/client/ranger_client.py ce6de34dc 
> 
> 
> Diff: https://reviews.apache.org/r/73525/diff/1/
> 
> 
> Testing
> ---
> 
> 1. mvn clean compile package install
> 2. Python client - create service
> 3. Python client - create policy
> 4. Python client - delete policy
> 5. Python client - delete service
> 6. Python client - delete group
> 7. Python client - delete user
> 8. Python client - delete role
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>

Review Request 73535: RANGER-3376: Add policy_guid column in x_policy_change_log table

[Pradeep Agrawal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73535/
---

Review request for ranger, Abhishek  Kumar, Abhay Kulkarni, Madhan Neethiraj, 
Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3376
https://issues.apache.org/jira/browse/RANGER-3376


Repository: ranger


Description
---

**Problem Statement:**
Currently x_policy_change_log table has policy_id column and it does not have 
its guid there. 
For few operations we might need guid of the policy, if its in the same table 
then it shall reduce the loopup time.

**Proposed Solution:**
Add policy_guid column in the x_policy_change_log table for fresh and upgrade 
case and update the policy_guid column value also whenever any entry is added 
for a policy change event goes to the x_policy_change_log table.


Diffs
-

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 1ba3e69e8 
  security-admin/db/mysql/patches/056-add-policyguid-in-x_policy_change_log.sql 
PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
021c34c77 
  
security-admin/db/oracle/patches/056-add-policyguid-in-x_policy_change_log.sql 
PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
89e9e77a0 
  
security-admin/db/postgres/patches/056-add-policyguid-in-x_policy_change_log.sql
 PRE-CREATION 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
b90a48e0a 
  
security-admin/db/sqlanywhere/patches/056-add-policyguid-in-x_policy_change_log.sql
 PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
7e03289dd 
  
security-admin/db/sqlserver/patches/056-add-policyguid-in-x_policy_change_log.sql
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
b9a926b33 
  security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java 
bc48d4a25 


Diff: https://reviews.apache.org/r/73535/diff/1/


Testing
---

Tested the patch for fresh and upgrade case in MySQL, Oracle, PostGres, MSSQL 
db flavor. 
Column policy_guid was added in the x_policy_change_log table.
policy_guid values was updated for each policy change event in the 
x_policy_change_log table.


Thanks,

Pradeep Agrawal

Re: Review Request 73522: RANGER-3372 : ISSUE IN POLICIES SEARCH ON REPORT PAGE WITH USER HAVING MORE THAN ONE UNIX GROUPS

[Mehul Parikh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73522/#review223370
---


Ship it!




Ship It!

- Mehul Parikh


On Aug. 20, 2021, 5:16 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73522/
> ---
> 
> (Updated Aug. 20, 2021, 5:16 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dhaval Shah, Abhay Kulkarni, 
> Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3372
> https://issues.apache.org/jira/browse/RANGER-3372
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> PROBLEM STATEMENT : 
> We have a user called "A"
> User A belongs to 2 Groups [Group 1 and Group 2 ]
> Group 1 is assigned to Hive Policy [Test 1 ]
> Group 2 is assigned to Hive Policy [Test 2 ]
> 
> Now while searching user "A" in Ranger Reports , We can only see 1 of the 
> Policy is listing , Expected behaviour should be : Both policy should be 
> displayed in reports.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> b9a926b33 
> 
> 
> Diff: https://reviews.apache.org/r/73522/diff/4/
> 
> 
> Testing
> ---
> 
> Ran - mvn clean compile test verify install
> Testing - Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

[jira] [Updated] (RANGER-3376) Add policy_guid column in x_policy_change_log table

[Pradeep Agrawal (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-3376:

Fix Version/s: 2.2.0
   3.0.0

> Add policy_guid column in x_policy_change_log table
> ---
>
> Key: RANGER-3376
> URL: https://issues.apache.org/jira/browse/RANGER-3376
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-RANGER-3376-Add-policy_guid-column-in-x_policy_chang.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-3376) Add policy_guid column in x_policy_change_log table

[Pradeep Agrawal (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-3376:

Attachment: 0001-RANGER-3376-Add-policy_guid-column-in-x_policy_chang.patch

> Add policy_guid column in x_policy_change_log table
> ---
>
> Key: RANGER-3376
> URL: https://issues.apache.org/jira/browse/RANGER-3376
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
>Priority: Major
> Attachments: 
> 0001-RANGER-3376-Add-policy_guid-column-in-x_policy_chang.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)