[jira] [Comment Edited] (RANGER-3390) improve plugin performance for yarn and es by replacing getAsString

[caozhiqiang (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412345#comment-17412345
 ] 

caozhiqiang edited comment on RANGER-3390 at 9/9/21, 6:06 AM:
--

[~bpatel] Thank you for your help.If ES add other resources like shard, we 
would get the shard value use 
Objects.toString(super.getValue(ElasticsearchResourceMgr.SHARD)) and append it 
to INDEX.

Further, we could add a variable in class RangerElasticsearchResource and 
RangerYarnResource to save the resource value like below.

 
{code:java}
class RangerElasticsearchResource extends RangerAccessResourceImpl {
   private String index;
   public RangerElasticsearchResource(String index) {
  if (StringUtils.isEmpty(index)) {
 index = "*";
  }
  setValue(ElasticsearchResourceMgr.INDEX, index);
  this.index = index
   }

   @Override
   public String getAsString() {
  String ret = super.getStringifiedValue();

  if (ret == null) {
 ret = index;
 super.setStringifiedValue(ret);
  }
  return ret;
   }
}
{code}
I am not sure what's the mean to update RR description with Jira ID, could you 
give me more explain? And I have add a review request in 
[https://reviews.apache.org/r/73560/] , thank you.

 


was (Author: caozhiqiang):
If ES add other resources like shard, we would get the shard value use 
Objects.toString(super.getValue(ElasticsearchResourceMgr.SHARD)) and append it 
to INDEX.

> improve plugin performance for yarn and es by replacing getAsString
> ---
>
> Key: RANGER-3390
> URL: https://issues.apache.org/jira/browse/RANGER-3390
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.0.1
>Reporter: caozhiqiang
>Assignee: caozhiqiang
>Priority: Major
> Attachments: RANGER-3390-branch-2.0.1.001.patch
>
>
> The 
> org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.getAsString 
> function take too much time. We should replace it to improve performance for 
> Yarn and ES.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3390) improve plugin performance for yarn and es by replacing getAsString

[caozhiqiang (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412345#comment-17412345
 ] 

caozhiqiang commented on RANGER-3390:
-

If ES add other resources like shard, we would get the shard value use 
Objects.toString(super.getValue(ElasticsearchResourceMgr.SHARD)) and append it 
to INDEX.

> improve plugin performance for yarn and es by replacing getAsString
> ---
>
> Key: RANGER-3390
> URL: https://issues.apache.org/jira/browse/RANGER-3390
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.0.1
>Reporter: caozhiqiang
>Assignee: caozhiqiang
>Priority: Major
> Attachments: RANGER-3390-branch-2.0.1.001.patch
>
>
> The 
> org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.getAsString 
> function take too much time. We should replace it to improve performance for 
> Yarn and ES.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-3403) Ranger usersync role based rules not working as expected

[Sailaja Polavarapu (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu updated RANGER-3403:
---
Attachment: 0001-RANGER-3403-Fixed-issue-where-role-assignments-are-n.patch

> Ranger usersync role based rules not working as expected
> 
>
> Key: RANGER-3403
> URL: https://issues.apache.org/jira/browse/RANGER-3403
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger, usersync
>Reporter: Sailaja Polavarapu
>Assignee: Sailaja Polavarapu
>Priority: Major
> Attachments: 
> 0001-RANGER-3403-Fixed-issue-where-role-assignments-are-n.patch
>
>
> When add a group in Ranger Usersync Group based role assignment Rules, all 
> members in the group will have the admin role, but if remove the group from 
> Ranger Usersync Group based role assignment Rules, the members will still be 
> admin. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73575: RANGER-3403: Ranger usersync role based rules not working as expected

[Sailaja Polavarapu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73575/
---

Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Vishal 
Suvagia, and Velmurugan Periasamy.


Bugs: RANGER-3403
https://issues.apache.org/jira/browse/RANGER-3403


Repository: ranger


Description
---

Added code to reset the users' role to "ROLE_USER" when a user/group is removed 
from the role assignment rules.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 546345ac0 
  security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 
d383cf596 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 8eff33643 
  
ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/UsersGroupRoleAssignments.java
 ce0b9dd8b 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 ff513aa86 


Diff: https://reviews.apache.org/r/73575/diff/1/


Testing
---

1. Verified the build is successful and existing test cases ran successfully
2. Patched a cluster and verified the functionality and basic regression tests.


Thanks,

Sailaja Polavarapu

[jira] [Created] (RANGER-3403) Ranger usersync role based rules not working as expected

[Sailaja Polavarapu (Jira)]

Sailaja Polavarapu created RANGER-3403:
--

 Summary: Ranger usersync role based rules not working as expected
 Key: RANGER-3403
 URL: https://issues.apache.org/jira/browse/RANGER-3403
 Project: Ranger
  Issue Type: Bug
  Components: Ranger, usersync
Reporter: Sailaja Polavarapu
Assignee: Sailaja Polavarapu


When add a group in Ranger Usersync Group based role assignment Rules, all 
members in the group will have the admin role, but if remove the group from 
Ranger Usersync Group based role assignment Rules, the members will still be 
admin. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73564: RANGER-3394: Too much `varchar(4000)` causes table to exceed ROW SIZE limit in MySQL

[Tsung-Ju Lii]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73564/
---

(Updated 九月 8, 2021, 6:57 p.m.)


Review request for ranger.


Repository: ranger


Description (updated)
---

The patch is just substituting all occurrences of `varchar(4000)` with 
`varchar(256)` in `core_db.sql` files.


Diffs (updated)
-

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 8e925e5d7 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
638d9fbf2 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
500e83f01 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
0048e504c 


Diff: https://reviews.apache.org/r/73564/diff/2/

Changes: https://reviews.apache.org/r/73564/diff/1-2/


Testing
---

After I applied this patch I was able to deploy using MySQL. Without it the 
deploy would fail.


Thanks,

Tsung-Ju Lii

Re: Review Request 73562: RANGER-3392: Fix bugs in `build_ranger_using_docker.sh` script

[Tsung-Ju Lii]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73562/
---

(Updated 九月 8, 2021, 6:39 p.m.)


Review request for ranger.


Repository: ranger


Description (updated)
---

1. The URL for Maven is no longer working
2. The GPG key server was deprecated some time ago


Diffs
-

  build_ranger_using_docker.sh 9aadfb5f7 


Diff: https://reviews.apache.org/r/73562/diff/2/


Testing
---

Tested on my Ubuntu box, after applying the patch I was able to build Ranger 
successfully.


Thanks,

Tsung-Ju Lii

Re: Review Request 73562: RANGER-3392: Fix bugs in `build_ranger_using_docker.sh` script

[Tsung-Ju Lii]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73562/
---

(Updated 九月 8, 2021, 6:38 p.m.)


Review request for ranger.


Repository: ranger


Description
---

1. The URL for Maven is no longer working
2. The GPG key server was deprecated some time ago
3. (Not sure about this) skip Apache Rat, since it claims a bunch of things are 
unapproved


Diffs (updated)
-

  build_ranger_using_docker.sh 9aadfb5f7 


Diff: https://reviews.apache.org/r/73562/diff/2/

Changes: https://reviews.apache.org/r/73562/diff/1-2/


Testing
---

Tested on my Ubuntu box, after applying the patch I was able to build Ranger 
successfully.


Thanks,

Tsung-Ju Lii

[jira] [Comment Edited] (RANGER-3397) Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation

[Abhay Kulkarni (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409730#comment-17409730
 ] 

Abhay Kulkarni edited comment on RANGER-3397 at 9/8/21, 4:54 PM:
-

Patch is available here - [https://reviews.apache.org/r/73567/]

[https://reviews.apache.org/r/73574/]

 


was (Author: abhayk):
Patch is available here - https://reviews.apache.org/r/73567/

> Update ACL computation to (optionally) expand Ranger Roles to users and 
> groups and include chained-plugins in ACL computation
> -
>
> Key: RANGER-3397
> URL: https://issues.apache.org/jira/browse/RANGER-3397
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently, getResourceACLs() API does not include chained-plugins into its 
> computation. Also, as users and groups for a given Ranger Role can be 
> completely resolved using Ranger's own database, it is useful to optionally 
> expand Roles to their constituent users and groups and report ACLs for users 
> and groups only. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (RANGER-3397) Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation

[Abhay Kulkarni (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409766#comment-17409766
 ] 

Abhay Kulkarni edited comment on RANGER-3397 at 9/8/21, 4:54 PM:
-

Commit details:

master:

[https://github.com/apache/ranger/commit/fe27e0b32d388033d305b6e58b9686566ee40eb1]

[https://github.com/apache/ranger/commit/3b0a9c8f5273ce7c6d12170b86e7a83a9fdba225]

 

ranger-2.2:

[https://github.com/apache/ranger/commit/218c06ff54f389a2ee57d80e156ecbf7364a51ec]

[https://github.com/apache/ranger/commit/7fb90c3941dbb5c381d9be967888b681c6b04fcb]

 

 


was (Author: abhayk):
Commit details:

master:

[https://github.com/apache/ranger/commit/fe27e0b32d388033d305b6e58b9686566ee40eb1]

ranger-2.2:

[https://github.com/apache/ranger/commit/218c06ff54f389a2ee57d80e156ecbf7364a51ec]

 

> Update ACL computation to (optionally) expand Ranger Roles to users and 
> groups and include chained-plugins in ACL computation
> -
>
> Key: RANGER-3397
> URL: https://issues.apache.org/jira/browse/RANGER-3397
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently, getResourceACLs() API does not include chained-plugins into its 
> computation. Also, as users and groups for a given Ranger Role can be 
> completely resolved using Ranger's own database, it is useful to optionally 
> expand Roles to their constituent users and groups and report ACLs for users 
> and groups only. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73574: RANGER-3397: Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation - Part 2

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73574/#review223460
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 8, 2021, 4:23 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73574/
> ---
> 
> (Updated Sept. 8, 2021, 4:23 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-3397
> https://issues.apache.org/jira/browse/RANGER-3397
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added a missing accessor method to RangerBasePlugin claas
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  3ad74e5de 
> 
> 
> Diff: https://reviews.apache.org/r/73574/diff/1/
> 
> 
> Testing
> ---
> 
> Passed all unit tests
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 73574: RANGER-3397: Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation - Part 2

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73574/#review223459
---


Ship it!




Ship It!

- Ramesh Mani


On Sept. 8, 2021, 4:23 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73574/
> ---
> 
> (Updated Sept. 8, 2021, 4:23 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-3397
> https://issues.apache.org/jira/browse/RANGER-3397
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added a missing accessor method to RangerBasePlugin claas
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  3ad74e5de 
> 
> 
> Diff: https://reviews.apache.org/r/73574/diff/1/
> 
> 
> Testing
> ---
> 
> Passed all unit tests
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Review Request 73574: RANGER-3397: Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation - Part 2

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73574/
---

Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Bugs: RANGER-3397
https://issues.apache.org/jira/browse/RANGER-3397


Repository: ranger


Description
---

Added a missing accessor method to RangerBasePlugin claas


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 3ad74e5de 


Diff: https://reviews.apache.org/r/73574/diff/1/


Testing
---

Passed all unit tests


Thanks,

Abhay Kulkarni

[jira] [Updated] (RANGER-3350) Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in current hive beeline session

[Ramesh Mani (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-3350:

Fix Version/s: 3.0.0

> Ranger HivePluginAuthorizer SHOW CURRENT ROLES  not fetching the role set in 
> current hive beeline session
> -
>
> Key: RANGER-3350
> URL: https://issues.apache.org/jira/browse/RANGER-3350
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: suja s
>Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
>
> Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in 
> current hive beeline session. User has to  open a new session to show current 
> roles assigned to the user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-3350) Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in current hive beeline session

[Ramesh Mani (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-3350:

Affects Version/s: 3.0.0

> Ranger HivePluginAuthorizer SHOW CURRENT ROLES  not fetching the role set in 
> current hive beeline session
> -
>
> Key: RANGER-3350
> URL: https://issues.apache.org/jira/browse/RANGER-3350
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: suja s
>Priority: Minor
> Fix For: 2.2.0
>
>
> Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in 
> current hive beeline session. User has to  open a new session to show current 
> roles assigned to the user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (RANGER-3350) Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in current hive beeline session

[Ramesh Mani (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani resolved RANGER-3350.
-
Resolution: Fixed

> Ranger HivePluginAuthorizer SHOW CURRENT ROLES  not fetching the role set in 
> current hive beeline session
> -
>
> Key: RANGER-3350
> URL: https://issues.apache.org/jira/browse/RANGER-3350
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.2.0
>Reporter: suja s
>Priority: Minor
> Fix For: 2.2.0
>
>
> Ranger HivePluginAuthorizer SHOW CURRENT ROLES not fetching the role set in 
> current hive beeline session. User has to  open a new session to show current 
> roles assigned to the user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3293) Show user source details on user tab in ranger UI.

[Nitin Galave (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411936#comment-17411936
 ] 

Nitin Galave commented on RANGER-3293:
--

Committed to 
[Apache-master|https://github.com/apache/ranger/commit/fcfed2062b0028b758893d898ec430ed4ea62328]
 branch.
Committed to 
[ranger-2.2|https://github.com/apache/ranger/commit/79f21e1de687e5bbf7b24f2695033c7f0825775f]
 branch.

> Show user source details on user tab in ranger UI.
> --
>
> Key: RANGER-3293
> URL: https://issues.apache.org/jira/browse/RANGER-3293
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Attachments: 0001-RANGER-3293.patch, 0002-RANGER-3293.patch
>
>
> Two new attributes are added when users are synced.
> Show them to the User details page Ranger UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73553: RANGER-3381: Upgrade to junit 4.13.1

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73553/#review223458
---


Ship it!




Ship It!

- bhavik patel


On Aug. 27, 2021, 11:35 a.m., Mahesh Bandal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73553/
> ---
> 
> (Updated Aug. 27, 2021, 11:35 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul 
> Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3381
> https://issues.apache.org/jira/browse/RANGER-3381
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently ranger is using junit-4.12.Upgrade junit version to 4.13.1 for best 
> practices.
> 
> 
> Diffs
> -
> 
>   plugin-schema-registry/pom.xml 4a597d5ec 
>   pom.xml 8d81988d4 
> 
> 
> Diff: https://reviews.apache.org/r/73553/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Ranger maven build successful -> mvn clean compile verify test install
> 2. Ranger Setup & install successful
> 3. Performed sanity testing.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>

[jira] [Commented] (RANGER-3390) improve plugin performance for yarn and es by replacing getAsString

[Bhavik Patel (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411878#comment-17411878
 ] 

Bhavik Patel commented on RANGER-3390:
--

This is really good contribution :).  

Can you please update the RR description with Jira ID?

 

Regarding the ES: if in future other resources are added then it not break, 
right?

> improve plugin performance for yarn and es by replacing getAsString
> ---
>
> Key: RANGER-3390
> URL: https://issues.apache.org/jira/browse/RANGER-3390
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.0.1
>Reporter: caozhiqiang
>Assignee: caozhiqiang
>Priority: Major
> Attachments: RANGER-3390-branch-2.0.1.001.patch
>
>
> The 
> org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.getAsString 
> function take too much time. We should replace it to improve performance for 
> Yarn and ES.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (RANGER-3358) Ranger - Upgrade Tomcat to 8.5.69

[Mateen N Mansoori (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mateen N Mansoori resolved RANGER-3358.
---
Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

Merged in master : 
https://github.com/apache/ranger/commit/e6ef861cac99c19ac583a175be801c077e166685
 & 2.2.0 : 
https://github.com/apache/ranger/commit/d9baa1ee110c9240f0dd2728c7016e2ba1cce02f

> Ranger - Upgrade Tomcat to 8.5.69
> -
>
> Key: RANGER-3358
> URL: https://issues.apache.org/jira/browse/RANGER-3358
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Mateen N Mansoori
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently Ranger is pulling in Tomcat 8.5.63, Upgrading to 8.5.69.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73564: RANGER-3394: Too much `varchar(4000)` causes table to exceed ROW SIZE limit in MySQL

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73564/#review223457
---



I think this is not a proper solution as TEXT data type use more memory for 
sorting as require the use of a disk-based temporary table and this might also 
impact performance.

Try to udpate the varchar size to 256-512 and you need to create sql patch for 
the same.

Also, try to provide patch for all the DB flavor.


security-admin/src/main/resources/log4jdbc.properties
Line 16 (original), 16 (patched)


this change belongs to RANGER-3393


- bhavik patel


On Sept. 1, 2021, 11:48 p.m., Tsung-Ju Lii wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73564/
> ---
> 
> (Updated Sept. 1, 2021, 11:48 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The patch is just substituting all occurrences of `varchar(4000)` with 
> `TEXT`. Probably not the best way to do this but it works for me.
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 8e925e5d7 
>   security-admin/src/main/resources/log4jdbc.properties 30cda789f 
> 
> 
> Diff: https://reviews.apache.org/r/73564/diff/1/
> 
> 
> Testing
> ---
> 
> After I applied this patch I was able to deploy using MySQL. Without it the 
> deploy would fail.
> 
> 
> Thanks,
> 
> Tsung-Ju Lii
> 
>

[jira] [Commented] (RANGER-3393) Stop using deprecated mysql driver class

[Bhavik Patel (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411863#comment-17411863
 ] 

Bhavik Patel commented on RANGER-3393:
--

This can be review/consider after 2.2 release.

> Stop using deprecated mysql driver class
> 
>
> Key: RANGER-3393
> URL: https://issues.apache.org/jira/browse/RANGER-3393
> Project: Ranger
>  Issue Type: Bug
>  Components: build-infra
>Reporter: Tsung-Ju Lii
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73562: RANGER-3392: Fix bugs in `build_ranger_using_docker.sh` script

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73562/#review223456
---




build_ranger_using_docker.sh
Line 30 (original), 30 (patched)


Please enable the rat(license) check


- bhavik patel


On Sept. 1, 2021, 11:42 p.m., Tsung-Ju Lii wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73562/
> ---
> 
> (Updated Sept. 1, 2021, 11:42 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> 1. The URL for Maven is no longer working
> 2. The GPG key server was deprecated some time ago
> 3. (Not sure about this) skip Apache Rat, since it claims a bunch of things 
> are unapproved
> 
> 
> Diffs
> -
> 
>   build_ranger_using_docker.sh 9aadfb5f7 
> 
> 
> Diff: https://reviews.apache.org/r/73562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on my Ubuntu box, after applying the patch I was able to build Ranger 
> successfully.
> 
> 
> Thanks,
> 
> Tsung-Ju Lii
> 
>

Re: Review Request 73521: RANGER-3358 : Upgrade Tomcat to 8.5.69

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73521/#review223455
---


Ship it!




Ship It!

- bhavik patel


On Aug. 16, 2021, 9:25 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73521/
> ---
> 
> (Updated Aug. 16, 2021, 9:25 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3358
> https://issues.apache.org/jira/browse/RANGER-3358
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently Ranger is pulling in Tomcat 8.5.63, Upgrading to 8.5.69.
> 
> 
> Diffs
> -
> 
>   pom.xml 8d81988d4 
> 
> 
> Diff: https://reviews.apache.org/r/73521/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73572: RANGER-3402: updated getResourceACLs() to avoid references to collections in RangerPolicy

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73572/#review223454
---


Ship it!




Ship It!

- bhavik patel


On Sept. 7, 2021, 3:47 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73572/
> ---
> 
> (Updated Sept. 7, 2021, 3:47 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Nitin Galave, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3402
> https://issues.apache.org/jira/browse/RANGER-3402
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> instead of referencing collections in RangerPolicy object, getResourceACLs() 
> has been updated to return copy of these collecitons
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 
> cca18cac8 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
>  c92b5502f 
> 
> 
> Diff: https://reviews.apache.org/r/73572/diff/1/
> 
> 
> Testing
> ---
> 
> - verified all tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 73558: RANGER-3387 : Ranger Admin Header Validation

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73558/#review223453
---




security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 3769 (patched)


Hard coded value might create security problem, try to add it in confi file


- bhavik patel


On Sept. 7, 2021, 6:22 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73558/
> ---
> 
> (Updated Sept. 7, 2021, 6:22 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Jayendra Parab, Abhay Kulkarni, 
> Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3387
> https://issues.apache.org/jira/browse/RANGER-3387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Admin Header Validation
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> 7d26b0a8a 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
>  3736bb4a7 
>   security-admin/src/main/webapp/scripts/modules/RestCsrf.js 50ac5f181 
>   
> security-admin/src/test/java/org/apache/ranger/security/web/filter/TestRangerCSRFPreventionFilter.java
>  b05afb52c 
> 
> 
> Diff: https://reviews.apache.org/r/73558/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local VM - performed CRUD operations, Verified User-Sync, Ranger 
> KMS plugin syncup.
> Ran - mvn clean compile test verify install -> Build succeeded.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>