Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223580
---




kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 35 (original), 35 (patched)


Please consider removing un-necessary spaces.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 123 (original), 124 (patched)


Please consider removing un-necessary spaces.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 137 (original), 137 (patched)


Please consider removing un-necessary spaces.


- Kishor Gollapalliwar


On Oct. 7, 2021, 5:07 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 5:07 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Review Request 73635: RANGER-3467: Revert RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted hive commands

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73635/
---

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-3467
https://issues.apache.org/jira/browse/RANGER-3467


Repository: ranger


Description
---

RANGER-3467: Revert RANGER-3368 Ranger HiveAuthorizer improvements to handle 
uncharted hive commands


Diffs
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java
 730c85514 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 9dfbc9bdf 


Diff: https://reviews.apache.org/r/73635/diff/1/


Testing
---

- Verified the reverted patch in LOCAL vm


Thanks,

Ramesh Mani

[jira] [Updated] (RANGER-3467) Revert RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted hive commands

[Ramesh Mani (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-3467:

Fix Version/s: 2.2.0
   3.0.0

> Revert  RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted 
> hive commands
> 
>
> Key: RANGER-3467
> URL: https://issues.apache.org/jira/browse/RANGER-3467
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> RANGER-3368 Introduced a check on Hive Input/Output HivePrivilegeObject 
> context to prevent hive commands slipping from authorization. But this check 
> needs more testing as there are many commands which doesn't have this context 
> and has to pass through the authorization. Because of this check there are 
> many hive command which are failing and to identify and marking in the 
> allowed list will need more testing cycles hence we need to revert this 
> change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-3467) Revert RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted hive commands

[Ramesh Mani (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani reassigned RANGER-3467:
---

Assignee: Ramesh Mani

> Revert  RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted 
> hive commands
> 
>
> Key: RANGER-3467
> URL: https://issues.apache.org/jira/browse/RANGER-3467
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
>
> RANGER-3368 Introduced a check on Hive Input/Output HivePrivilegeObject 
> context to prevent hive commands slipping from authorization. But this check 
> needs more testing as there are many commands which doesn't have this context 
> and has to pass through the authorization. Because of this check there are 
> many hive command which are failing and to identify and marking in the 
> allowed list will need more testing cycles hence we need to revert this 
> change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3467) Revert RANGER-3368 Ranger HiveAuthorizer improvements to handle uncharted hive commands

[Ramesh Mani (Jira)]

Ramesh Mani created RANGER-3467:
---

 Summary: Revert  RANGER-3368 Ranger HiveAuthorizer improvements to 
handle uncharted hive commands
 Key: RANGER-3467
 URL: https://issues.apache.org/jira/browse/RANGER-3467
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 3.0.0, 2.2.0
Reporter: Ramesh Mani


RANGER-3368 Introduced a check on Hive Input/Output HivePrivilegeObject context 
to prevent hive commands slipping from authorization. But this check needs more 
testing as there are many commands which doesn't have this context and has to 
pass through the authorization. Because of this check there are many hive 
command which are failing and to identify and marking in the allowed list will 
need more testing cycles hence we need to revert this change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73634: RANGER-3463 : Use apt logger to log messages

[Mateen Mansoori]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/
---

Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
Parikh, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-3463
https://issues.apache.org/jira/browse/RANGER-3463


Repository: ranger


Description
---

Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
98, 104.


Diffs
-

  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
925d2c76f 


Diff: https://reviews.apache.org/r/73634/diff/1/


Testing
---

Tested on local VM.


Thanks,

Mateen Mansoori

[jira] [Updated] (RANGER-3463) Use apt logger to log messages

[Mateen N Mansoori (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mateen N Mansoori updated RANGER-3463:
--
Attachment: 0001-RANGER-3463-Use-apt-logger-to-log-messages.patch

> Use apt logger to log messages
> --
>
> Key: RANGER-3463
> URL: https://issues.apache.org/jira/browse/RANGER-3463
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhishek Kumar
>Assignee: Mateen Mansoori
>Priority: Major
> Attachments: 0001-RANGER-3463-Use-apt-logger-to-log-messages.patch
>
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3421) Key getting logged in RangerMasterKey.java

[Abhishek Kumar (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425316#comment-17425316
 ] 

Abhishek Kumar commented on RANGER-3421:


In review : [https://reviews.apache.org/r/73633/]

> Key getting logged in RangerMasterKey.java
> --
>
> Key: RANGER-3421
> URL: https://issues.apache.org/jira/browse/RANGER-3421
> Project: Ranger
>  Issue Type: Task
>  Components: kms
>Reporter: Abhishek Kumar
>Assignee: Abhishek Kumar
>Priority: Minor
>
> Key in line RangerMasterKey.java:100 gets logged in the case of an exception, 
> is not a good coding practice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73633: RANGER-3421: Avoid logging key details in RangerMasterKey.java

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/
---

Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-3421
https://issues.apache.org/jira/browse/RANGER-3421


Repository: ranger


Description
---

Avoiding logging key details and code refactoring.


Diffs
-

  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java adb2c2604 


Diff: https://reviews.apache.org/r/73633/diff/1/


Testing
---


Thanks,

Abhishek  Kumar

[jira] [Assigned] (RANGER-3421) Key getting logged in RangerMasterKey.java

[Abhishek Kumar (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kumar reassigned RANGER-3421:
--

Assignee: Abhishek Kumar  (was: Dhaval Shah)

> Key getting logged in RangerMasterKey.java
> --
>
> Key: RANGER-3421
> URL: https://issues.apache.org/jira/browse/RANGER-3421
> Project: Ranger
>  Issue Type: Task
>  Components: kms
>Reporter: Abhishek Kumar
>Assignee: Abhishek Kumar
>Priority: Minor
>
> Key in line RangerMasterKey.java:100 gets logged in the case of an exception, 
> is not a good coding practice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3453) Avoid logging sensitive information in UserMgr.java

[Abhishek Kumar (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425276#comment-17425276
 ] 

Abhishek Kumar commented on RANGER-3453:


[Commited|https://github.com/apache/ranger/commit/4715c3e81fdf59b3d9bcc9fc0133ec6228799404]

> Avoid logging sensitive information in UserMgr.java
> ---
>
> Key: RANGER-3453
> URL: https://issues.apache.org/jira/browse/RANGER-3453
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhishek Kumar
>Assignee: Abhishek Kumar
>Priority: Minor
>
> The changeEmailAddress, updateUser methods in UserMgr class are logging 
> sensitive information as well while printing error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (RANGER-3453) Avoid logging sensitive information in UserMgr.java

[Abhishek Kumar (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kumar resolved RANGER-3453.

Resolution: Fixed

> Avoid logging sensitive information in UserMgr.java
> ---
>
> Key: RANGER-3453
> URL: https://issues.apache.org/jira/browse/RANGER-3453
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhishek Kumar
>Assignee: Abhishek Kumar
>Priority: Minor
>
> The changeEmailAddress, updateUser methods in UserMgr class are logging 
> sensitive information as well while printing error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (RANGER-3397) Update ACL computation to (optionally) expand Ranger Roles to users and groups and include chained-plugins in ACL computation

[Abhay Kulkarni (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409766#comment-17409766
 ] 

Abhay Kulkarni edited comment on RANGER-3397 at 10/6/21, 11:14 PM:
---

Commit details:

master:

[https://github.com/apache/ranger/commit/fe27e0b32d388033d305b6e58b9686566ee40eb1]

[https://github.com/apache/ranger/commit/3b0a9c8f5273ce7c6d12170b86e7a83a9fdba225]

[https://github.com/apache/ranger/commit/e5cd204efe69fa62b63cc70bf0960ea71ccc6453]

 

[https://github.com/apache/ranger/commit/1debdbcdec23c6688d4589253e75a32a894659c3]

 

 

 

ranger-2.2:

[https://github.com/apache/ranger/commit/218c06ff54f389a2ee57d80e156ecbf7364a51ec]

[https://github.com/apache/ranger/commit/7fb90c3941dbb5c381d9be967888b681c6b04fcb]

[https://github.com/apache/ranger/commit/b1dcfb42f942273de17bba58ab4c94cd3990b4f2]

[https://github.com/apache/ranger/commit/c1c22d94065e96705f696075d10f6ec41e282a05]

 

 

 


was (Author: abhayk):
Commit details:

master:

[https://github.com/apache/ranger/commit/fe27e0b32d388033d305b6e58b9686566ee40eb1]

[https://github.com/apache/ranger/commit/3b0a9c8f5273ce7c6d12170b86e7a83a9fdba225]

[https://github.com/apache/ranger/commit/e5cd204efe69fa62b63cc70bf0960ea71ccc6453]

 

[https://github.com/apache/ranger/commit/1debdbcdec23c6688d4589253e75a32a894659c3]

 

 

 

ranger-2.2:

[https://github.com/apache/ranger/commit/218c06ff54f389a2ee57d80e156ecbf7364a51ec]

[https://github.com/apache/ranger/commit/7fb90c3941dbb5c381d9be967888b681c6b04fcb]

[https://github.com/apache/ranger/commit/b1dcfb42f942273de17bba58ab4c94cd3990b4f2]

 

 

> Update ACL computation to (optionally) expand Ranger Roles to users and 
> groups and include chained-plugins in ACL computation
> -
>
> Key: RANGER-3397
> URL: https://issues.apache.org/jira/browse/RANGER-3397
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently, getResourceACLs() API does not include chained-plugins into its 
> computation. Also, as users and groups for a given Ranger Role can be 
> completely resolved using Ranger's own database, it is useful to optionally 
> expand Roles to their constituent users and groups and report ACLs for users 
> and groups only. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (RANGER-3462) User with delegated admin permission on a resource cannot fetch policy for the resource

[Abhay Kulkarni (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424787#comment-17424787
 ] 

Abhay Kulkarni edited comment on RANGER-3462 at 10/6/21, 11:13 PM:
---

Commit details:

master:

[https://github.com/apache/ranger/commit/d90361db662de1531eafa4d05853e7bc7e08c2a2]

ranger-2.2:

[https://github.com/apache/ranger/commit/f5924b3476ba3fed6f128e6257ebab9bea5cd769]

 


was (Author: abhayk):
Commit details:

master:

https://github.com/apache/ranger/commit/d90361db662de1531eafa4d05853e7bc7e08c2a2

> User with delegated admin permission on a resource cannot fetch policy for 
> the resource
> ---
>
> Key: RANGER-3462
> URL: https://issues.apache.org/jira/browse/RANGER-3462
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
>
> Steps to reproduce the issue:
>  # Create users in Ranger alice, bob, and charlie. Alice has admin role, bob 
> and charlie has user role.
>  # Create an HDFS policy with name "test-delegate-admin" as alice. In that 
> policy there 2 policy items; one for bob, and the other for alice with RWX 
> permissions with "Delegate Admin".
>  # Log in as bob, and edited the policy item for bob: removed Write 
> permission.
>  # After saving the policy bob is not able to see to policy anymore. It only 
> becomes visible after the Write permission is restored.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3466) Support co-routines - async/await in Ranger Python Client

[Zeashan Pappa (Jira)]

Zeashan Pappa created RANGER-3466:
-

 Summary: Support co-routines - async/await in Ranger Python Client
 Key: RANGER-3466
 URL: https://issues.apache.org/jira/browse/RANGER-3466
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Zeashan Pappa


*Background*
In order to support more modern tooling with Apache Ranger, add configuration 
and necessary interface changes within the Ranger Python Client to support 
async/await, specified within 
[PEP-0492.|https://www.python.org/dev/peps/pep-0492/]

 

*Implementation* 

**Use asyncio and aiohttp to implement this, and provide synchronous interfaces 
for backwards compatibility.

*Additional Information*

A write up on the performance gains to be had when using aiohttp and 
async/await vs standard synchronous calls through the requests module.

https://betterprogramming.pub/making-api-requests-in-python-aiohttp-client-vs-requests-26a7025c39a6



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-3466) Support co-routines - async/await in Ranger Python Client

[Zeashan Pappa (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zeashan Pappa reassigned RANGER-3466:
-

Assignee: Zeashan Pappa

> Support co-routines - async/await in Ranger Python Client
> -
>
> Key: RANGER-3466
> URL: https://issues.apache.org/jira/browse/RANGER-3466
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Zeashan Pappa
>Assignee: Zeashan Pappa
>Priority: Major
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> *Background*
> In order to support more modern tooling with Apache Ranger, add configuration 
> and necessary interface changes within the Ranger Python Client to support 
> async/await, specified within 
> [PEP-0492.|https://www.python.org/dev/peps/pep-0492/]
>  
> *Implementation* 
> **Use asyncio and aiohttp to implement this, and provide synchronous 
> interfaces for backwards compatibility.
> *Additional Information*
> A write up on the performance gains to be had when using aiohttp and 
> async/await vs standard synchronous calls through the requests module.
> https://betterprogramming.pub/making-api-requests-in-python-aiohttp-client-vs-requests-26a7025c39a6



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3465) Upgrade spring-security library

[Dineshkumar Yadav (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424815#comment-17424815
 ] 

Dineshkumar Yadav commented on RANGER-3465:
---

Updating spring-security version to 5.5.2

> Upgrade spring-security library 
> 
>
> Key: RANGER-3465
> URL: https://issues.apache.org/jira/browse/RANGER-3465
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Dineshkumar Yadav
>Assignee: Dineshkumar Yadav
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3465) Upgrade spring-security library

[Dineshkumar Yadav (Jira)]

Dineshkumar Yadav created RANGER-3465:
-

 Summary: Upgrade spring-security library 
 Key: RANGER-3465
 URL: https://issues.apache.org/jira/browse/RANGER-3465
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Dineshkumar Yadav
Assignee: Dineshkumar Yadav






--
This message was sent by Atlassian Jira
(v8.3.4#803005)