Review Request 74042: Fix ConcurrentModificationException in UnixUserGroupBuilder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74042/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Sailaja Polavarapu. Bugs: RANGER-3813 https://issues.apache.org/jira/browse/RANGER-3813 Repository: ranger Description --- Line number 426 in ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java updates the map while iteration which raises the exception ConcurrentModificationException. Updates to the table groupUserTable in the call to the funciton buildUnixUserList will be revisited if required. Diffs - ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java 7653dfdbe Diff: https://reviews.apache.org/r/74042/diff/1/ Testing --- Pending. Thanks, Abhishek Kumar
Re: [VOTE] Release Apache Ranger version 2.3.0 - rc3
+1 - Verified 2.3.0-rc3 builds successfully Thanks, Bhavik Patel +91-7208744109 On Wed, Jun 29, 2022, 2:42 AM Abhishek Kumar wrote: > +1 > - Verified 2.3.0-rc3 builds successfully > > On Tue, Jun 28, 2022 at 11:58 AM Nixon Rodrigues wrote: > > > +1 for rc3 release. > > > > Verified the build and signatures. > > > > Thanks Ramesh for putting this together for release > > > > On Tue, 28 Jun 2022 at 11:56, Selvamohan Neethiraj < > > sneet...@appsdefense.com> > > wrote: > > > > > +1 > > > > > > * verified signature > > > * Builds successfully > > > > > > Thanks Ramesh for driving the release. > > > > > > Selva- > > > > > > On 6/25/22 3:00 AM, Ramesh Mani wrote: > > > > Dear Rangers, > > > > > > > > Apache Ranger 2.3.0 release candidate #3 is now available for > > > > a vote within the dev community. Links to the release artifacts are > > > > given below. Please review and vote. > > > > > > > > The vote will be open for at least 72 hours or until > > > > necessary votes are reached. > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Thanks, > > > > Ramesh > > > > > > > > List of all issues / improvements addressed in this release: > > > > https://issues.apache.org/jira/issues/?jql=project=RANGER AND > > > > status=Resolved AND fixVersion=2.3.0 ORDER BY key DESC > > > > > > > > Git tag for the release: > > > > https://github.com/apache/ranger/tree/release-2.3.0-rc3 > > > > > > > > Sources for the release: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz > > > > > > > > Source release verification: > > > > PGP Signature: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.asc > > > > SHA256 Hash: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha256 > > > > SHA512 Hash: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha512 > > > > > > > > Keys to verify the signature of the release artifacts are available > > > > at: https://dist.apache.org/repos/dist/release/ranger/KEYS > > > > > > > > New features/enhancements: > > > > > > > > RANGER-2846 Add support for resource[volume, bucket, key] look up in > > > > ozone plugin > > > > RANGER-2967 Add support for Amazon CloudWatch Logs as an Audit Store > > > > RANGER-3023 Permission tab takes longer time to load with large > number > > > > of users and group_users data > > > > RANGER-3030 Replace Findbugs with Spotbugs maven plugin > > > > RANGER-3182 Prestosql is renamed to Trino > > > > RANGER-3221 Improve logging in Presto plugin > > > > RANGER-3276 Remove duplicate code from buildks.java > > > > RANGER-3290 ArrayIndexOutOfBoundsException if solr is down > > > > RANGER-3299 Upgrading the bouncycastle version for bcprov-jdk15on > > > > RANGER-3298 Add coarse URI check for Hive Agent > > > > RANGER-3389 Swagger UI Support for Ranger REST API > > > > RANGER-3435 Add unique index on guid, service and zone_id column of > > > > x_policy table > > > > RANGER-3439 Add rest api to get or delete ranger policy based on guid > > > > RANGER-3455 [Logout-Ranger] Should either be disabled/ should > redirect > > > > to knox logout page > > > > RANGER-3459 Upgrade Ranger's Kafka dependency to 2.8 > > > > RANGER-3475 Promote TagRest endpoints to /public/v2 > > > > RANGER-3487 Update underscore js with latest version. > > > > RANGER-3493 Add unique index on service and resource_signature column > > > > of x_policy table > > > > RANGER-3498 RANGER : Remove log4j1 dependencies. > > > > RANGER-3504 Create framework to execute DB patch dependent on Java > > patch. > > > > RANGER-3510 Ranger upgrade spring framework version to 5.3.12 > > > > RANGER-3511 Create Java patch to update policy resource-signature to > > > > unique value. > > > > RANGER-3512 Create Java patch to update policy guid to unique value. > > > > RANGER-3515 Enhance Ranger Java client SSL config to be configured > > > > using serviceType and AppId > > > > RANGER-3518 Limit the query size stored in Audit logs > > > > RANGER-3521 Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY > > > > RFC 6797 > > > > RANGER-3526 policy evaluation ordering to use name as secondary > > > > sorting key > > > > RANGER-3533 Provide sorting on columns throughout the audits result > > > > set and policy listing page. > > > > RANGER-3538 Reduce the granularity of locking when > building/retrieving > > > > a policy-engine within Ranger admin service > > > > RANGER-3539 Add jacoco-maven-plugin for code coverage > > > > RANGER-3540 Add support to read audit logs from Amazon CloudWatch > > > > RANGER-3545 Remove Logger Checks for Info Enabled > > > > RANGER-3548 Update performance engine test scripts > > > > RANGER-3550 support for using user/tag attributes in row-filter > > > > expressions and conditions > > > > RANGER-3551 Analyze & optimize module
Re: [VOTE] Release Apache Ranger version 2.3.0 - rc3
+1 - Verified 2.3.0-rc3 builds successfully On Tue, Jun 28, 2022 at 11:58 AM Nixon Rodrigues wrote: > +1 for rc3 release. > > Verified the build and signatures. > > Thanks Ramesh for putting this together for release > > On Tue, 28 Jun 2022 at 11:56, Selvamohan Neethiraj < > sneet...@appsdefense.com> > wrote: > > > +1 > > > > * verified signature > > * Builds successfully > > > > Thanks Ramesh for driving the release. > > > > Selva- > > > > On 6/25/22 3:00 AM, Ramesh Mani wrote: > > > Dear Rangers, > > > > > > Apache Ranger 2.3.0 release candidate #3 is now available for > > > a vote within the dev community. Links to the release artifacts are > > > given below. Please review and vote. > > > > > > The vote will be open for at least 72 hours or until > > > necessary votes are reached. > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove (and reason why) > > > > > > Thanks, > > > Ramesh > > > > > > List of all issues / improvements addressed in this release: > > > https://issues.apache.org/jira/issues/?jql=project=RANGER AND > > > status=Resolved AND fixVersion=2.3.0 ORDER BY key DESC > > > > > > Git tag for the release: > > > https://github.com/apache/ranger/tree/release-2.3.0-rc3 > > > > > > Sources for the release: > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz > > > > > > Source release verification: > > > PGP Signature: > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.asc > > > SHA256 Hash: > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha256 > > > SHA512 Hash: > > > > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha512 > > > > > > Keys to verify the signature of the release artifacts are available > > > at: https://dist.apache.org/repos/dist/release/ranger/KEYS > > > > > > New features/enhancements: > > > > > > RANGER-2846 Add support for resource[volume, bucket, key] look up in > > > ozone plugin > > > RANGER-2967 Add support for Amazon CloudWatch Logs as an Audit Store > > > RANGER-3023 Permission tab takes longer time to load with large number > > > of users and group_users data > > > RANGER-3030 Replace Findbugs with Spotbugs maven plugin > > > RANGER-3182 Prestosql is renamed to Trino > > > RANGER-3221 Improve logging in Presto plugin > > > RANGER-3276 Remove duplicate code from buildks.java > > > RANGER-3290 ArrayIndexOutOfBoundsException if solr is down > > > RANGER-3299 Upgrading the bouncycastle version for bcprov-jdk15on > > > RANGER-3298 Add coarse URI check for Hive Agent > > > RANGER-3389 Swagger UI Support for Ranger REST API > > > RANGER-3435 Add unique index on guid, service and zone_id column of > > > x_policy table > > > RANGER-3439 Add rest api to get or delete ranger policy based on guid > > > RANGER-3455 [Logout-Ranger] Should either be disabled/ should redirect > > > to knox logout page > > > RANGER-3459 Upgrade Ranger's Kafka dependency to 2.8 > > > RANGER-3475 Promote TagRest endpoints to /public/v2 > > > RANGER-3487 Update underscore js with latest version. > > > RANGER-3493 Add unique index on service and resource_signature column > > > of x_policy table > > > RANGER-3498 RANGER : Remove log4j1 dependencies. > > > RANGER-3504 Create framework to execute DB patch dependent on Java > patch. > > > RANGER-3510 Ranger upgrade spring framework version to 5.3.12 > > > RANGER-3511 Create Java patch to update policy resource-signature to > > > unique value. > > > RANGER-3512 Create Java patch to update policy guid to unique value. > > > RANGER-3515 Enhance Ranger Java client SSL config to be configured > > > using serviceType and AppId > > > RANGER-3518 Limit the query size stored in Audit logs > > > RANGER-3521 Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY > > > RFC 6797 > > > RANGER-3526 policy evaluation ordering to use name as secondary > > > sorting key > > > RANGER-3533 Provide sorting on columns throughout the audits result > > > set and policy listing page. > > > RANGER-3538 Reduce the granularity of locking when building/retrieving > > > a policy-engine within Ranger admin service > > > RANGER-3539 Add jacoco-maven-plugin for code coverage > > > RANGER-3540 Add support to read audit logs from Amazon CloudWatch > > > RANGER-3545 Remove Logger Checks for Info Enabled > > > RANGER-3548 Update performance engine test scripts > > > RANGER-3550 support for using user/tag attributes in row-filter > > > expressions and conditions > > > RANGER-3551 Analyze & optimize module permissions related API > > > RANGER-3553 Unit test coverage for XUserMgr and UserMgr class > > > RANGER-3556 Ranger tagsync logs unnecessary messages > > > RANGER-3561 Upgrade Storm version to 1.2.4 > > > RANGER-3562 Redesign post commit tasks for updating ref-tables when > > > policy/role is updated > > > RANGER-3565 RangerRESTClient to support retry > > > RANGER-3567 support for use of
Re: [VOTE] Release Apache Ranger version 2.3.0 - rc3
+1 for rc3 release. Verified the build and signatures. Thanks Ramesh for putting this together for release On Tue, 28 Jun 2022 at 11:56, Selvamohan Neethiraj wrote: > +1 > > * verified signature > * Builds successfully > > Thanks Ramesh for driving the release. > > Selva- > > On 6/25/22 3:00 AM, Ramesh Mani wrote: > > Dear Rangers, > > > > Apache Ranger 2.3.0 release candidate #3 is now available for > > a vote within the dev community. Links to the release artifacts are > > given below. Please review and vote. > > > > The vote will be open for at least 72 hours or until > > necessary votes are reached. > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Thanks, > > Ramesh > > > > List of all issues / improvements addressed in this release: > > https://issues.apache.org/jira/issues/?jql=project=RANGER AND > > status=Resolved AND fixVersion=2.3.0 ORDER BY key DESC > > > > Git tag for the release: > > https://github.com/apache/ranger/tree/release-2.3.0-rc3 > > > > Sources for the release: > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz > > > > Source release verification: > > PGP Signature: > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.asc > > SHA256 Hash: > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha256 > > SHA512 Hash: > > > https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha512 > > > > Keys to verify the signature of the release artifacts are available > > at: https://dist.apache.org/repos/dist/release/ranger/KEYS > > > > New features/enhancements: > > > > RANGER-2846 Add support for resource[volume, bucket, key] look up in > > ozone plugin > > RANGER-2967 Add support for Amazon CloudWatch Logs as an Audit Store > > RANGER-3023 Permission tab takes longer time to load with large number > > of users and group_users data > > RANGER-3030 Replace Findbugs with Spotbugs maven plugin > > RANGER-3182 Prestosql is renamed to Trino > > RANGER-3221 Improve logging in Presto plugin > > RANGER-3276 Remove duplicate code from buildks.java > > RANGER-3290 ArrayIndexOutOfBoundsException if solr is down > > RANGER-3299 Upgrading the bouncycastle version for bcprov-jdk15on > > RANGER-3298 Add coarse URI check for Hive Agent > > RANGER-3389 Swagger UI Support for Ranger REST API > > RANGER-3435 Add unique index on guid, service and zone_id column of > > x_policy table > > RANGER-3439 Add rest api to get or delete ranger policy based on guid > > RANGER-3455 [Logout-Ranger] Should either be disabled/ should redirect > > to knox logout page > > RANGER-3459 Upgrade Ranger's Kafka dependency to 2.8 > > RANGER-3475 Promote TagRest endpoints to /public/v2 > > RANGER-3487 Update underscore js with latest version. > > RANGER-3493 Add unique index on service and resource_signature column > > of x_policy table > > RANGER-3498 RANGER : Remove log4j1 dependencies. > > RANGER-3504 Create framework to execute DB patch dependent on Java patch. > > RANGER-3510 Ranger upgrade spring framework version to 5.3.12 > > RANGER-3511 Create Java patch to update policy resource-signature to > > unique value. > > RANGER-3512 Create Java patch to update policy guid to unique value. > > RANGER-3515 Enhance Ranger Java client SSL config to be configured > > using serviceType and AppId > > RANGER-3518 Limit the query size stored in Audit logs > > RANGER-3521 Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY > > RFC 6797 > > RANGER-3526 policy evaluation ordering to use name as secondary > > sorting key > > RANGER-3533 Provide sorting on columns throughout the audits result > > set and policy listing page. > > RANGER-3538 Reduce the granularity of locking when building/retrieving > > a policy-engine within Ranger admin service > > RANGER-3539 Add jacoco-maven-plugin for code coverage > > RANGER-3540 Add support to read audit logs from Amazon CloudWatch > > RANGER-3545 Remove Logger Checks for Info Enabled > > RANGER-3548 Update performance engine test scripts > > RANGER-3550 support for using user/tag attributes in row-filter > > expressions and conditions > > RANGER-3551 Analyze & optimize module permissions related API > > RANGER-3553 Unit test coverage for XUserMgr and UserMgr class > > RANGER-3556 Ranger tagsync logs unnecessary messages > > RANGER-3561 Upgrade Storm version to 1.2.4 > > RANGER-3562 Redesign post commit tasks for updating ref-tables when > > policy/role is updated > > RANGER-3565 RangerRESTClient to support retry > > RANGER-3567 support for use of user attributes in policy resources > > RANGER-3569 Support Ranger KMS integration with Google cloud HSM > > RANGER-3573 Add vim in docker base image > > RANGER-3577 RANGER : Upgrade POI version to 5.1.0 > > RANGER-3578 Simplify code for policy label creation > > RANGER-3580 Support Ranger KMS integration with TencentKMS > > RANGER-3585 Docker setup to run Ranger
Re: Review Request 74041: RANGER-3812: updated Python client to support multiple resource sets in a policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74041/#review224537 --- Ship it! Ship It! - Abhishek Kumar On June 28, 2022, 3:03 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74041/ > --- > > (Updated June 28, 2022, 3:03 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, deepak sharma, > Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3812 > https://issues.apache.org/jira/browse/RANGER-3812 > > > Repository: ranger > > > Description > --- > > updated Python client to support multiple resource sets in a policy > > > Diffs > - > > intg/src/main/python/apache_ranger/model/ranger_policy.py c33f6e4f1 > ranger-examples/sample-client/src/main/python/sample_client.py e558b6e1e > > > Diff: https://reviews.apache.org/r/74041/diff/1/ > > > Testing > --- > > - updated sample_client.py to verify that policy having multiple resource > sets is handled correctly by Python client > > > Thanks, > > Madhan Neethiraj > >
Review Request 74041: RANGER-3812: updated Python client to support multiple resource sets in a policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74041/ --- Review request for ranger, Abhishek Kumar, Ankita Sinha, deepak sharma, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. Bugs: RANGER-3812 https://issues.apache.org/jira/browse/RANGER-3812 Repository: ranger Description --- updated Python client to support multiple resource sets in a policy Diffs - intg/src/main/python/apache_ranger/model/ranger_policy.py c33f6e4f1 ranger-examples/sample-client/src/main/python/sample_client.py e558b6e1e Diff: https://reviews.apache.org/r/74041/diff/1/ Testing --- - updated sample_client.py to verify that policy having multiple resource sets is handled correctly by Python client Thanks, Madhan Neethiraj
Re: [VOTE] Release Apache Ranger version 2.3.0 - rc3
+1 * verified signature * Builds successfully Thanks Ramesh for driving the release. Selva- On 6/25/22 3:00 AM, Ramesh Mani wrote: Dear Rangers, Apache Ranger 2.3.0 release candidate #3 is now available for a vote within the dev community. Links to the release artifacts are given below. Please review and vote. The vote will be open for at least 72 hours or until necessary votes are reached. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Thanks, Ramesh List of all issues / improvements addressed in this release: https://issues.apache.org/jira/issues/?jql=project=RANGER AND status=Resolved AND fixVersion=2.3.0 ORDER BY key DESC Git tag for the release: https://github.com/apache/ranger/tree/release-2.3.0-rc3 Sources for the release: https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz Source release verification: PGP Signature: https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.asc SHA256 Hash: https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha256 SHA512 Hash: https://dist.apache.org/repos/dist/dev/ranger/2.3.0-rc3/apache-ranger-2.3.0.tar.gz.sha512 Keys to verify the signature of the release artifacts are available at: https://dist.apache.org/repos/dist/release/ranger/KEYS New features/enhancements: RANGER-2846 Add support for resource[volume, bucket, key] look up in ozone plugin RANGER-2967 Add support for Amazon CloudWatch Logs as an Audit Store RANGER-3023 Permission tab takes longer time to load with large number of users and group_users data RANGER-3030 Replace Findbugs with Spotbugs maven plugin RANGER-3182 Prestosql is renamed to Trino RANGER-3221 Improve logging in Presto plugin RANGER-3276 Remove duplicate code from buildks.java RANGER-3290 ArrayIndexOutOfBoundsException if solr is down RANGER-3299 Upgrading the bouncycastle version for bcprov-jdk15on RANGER-3298 Add coarse URI check for Hive Agent RANGER-3389 Swagger UI Support for Ranger REST API RANGER-3435 Add unique index on guid, service and zone_id column of x_policy table RANGER-3439 Add rest api to get or delete ranger policy based on guid RANGER-3455 [Logout-Ranger] Should either be disabled/ should redirect to knox logout page RANGER-3459 Upgrade Ranger's Kafka dependency to 2.8 RANGER-3475 Promote TagRest endpoints to /public/v2 RANGER-3487 Update underscore js with latest version. RANGER-3493 Add unique index on service and resource_signature column of x_policy table RANGER-3498 RANGER : Remove log4j1 dependencies. RANGER-3504 Create framework to execute DB patch dependent on Java patch. RANGER-3510 Ranger upgrade spring framework version to 5.3.12 RANGER-3511 Create Java patch to update policy resource-signature to unique value. RANGER-3512 Create Java patch to update policy guid to unique value. RANGER-3515 Enhance Ranger Java client SSL config to be configured using serviceType and AppId RANGER-3518 Limit the query size stored in Audit logs RANGER-3521 Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797 RANGER-3526 policy evaluation ordering to use name as secondary sorting key RANGER-3533 Provide sorting on columns throughout the audits result set and policy listing page. RANGER-3538 Reduce the granularity of locking when building/retrieving a policy-engine within Ranger admin service RANGER-3539 Add jacoco-maven-plugin for code coverage RANGER-3540 Add support to read audit logs from Amazon CloudWatch RANGER-3545 Remove Logger Checks for Info Enabled RANGER-3548 Update performance engine test scripts RANGER-3550 support for using user/tag attributes in row-filter expressions and conditions RANGER-3551 Analyze & optimize module permissions related API RANGER-3553 Unit test coverage for XUserMgr and UserMgr class RANGER-3556 Ranger tagsync logs unnecessary messages RANGER-3561 Upgrade Storm version to 1.2.4 RANGER-3562 Redesign post commit tasks for updating ref-tables when policy/role is updated RANGER-3565 RangerRESTClient to support retry RANGER-3567 support for use of user attributes in policy resources RANGER-3569 Support Ranger KMS integration with Google cloud HSM RANGER-3573 Add vim in docker base image RANGER-3577 RANGER : Upgrade POI version to 5.1.0 RANGER-3578 Simplify code for policy label creation RANGER-3580 Support Ranger KMS integration with TencentKMS RANGER-3585 Docker setup to run Ranger usersync and tagsync RANGER-3586 Script condition expression to support csv of group/tag attributes RANGER-3595 Tar of KMS contains rubbish files RANGER-3597 User role should not be able to modify the Policy RANGER-3600 Ranger service tags import request failure RANGER-3603 HDFS audit files rollover improvement to trigger rollover in monitoring thread RANGER-3605 Support macros in row-filter/condition expressions RANGER-3606 remove unnecessary static members from plugin class loaders RANGER-3609 option to add user group enricher
Re: Review Request 74039: RANGER-3806: Group's users mapping entry failing whenever primary key auto-increment is not set to 1 in db
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74039/#review224536 --- Ship it! Ship It! - Sailaja Polavarapu On June 24, 2022, 10:12 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74039/ > --- > > (Updated June 24, 2022, 10:12 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3806 > https://issues.apache.org/jira/browse/RANGER-3806 > > > Repository: ranger > > > Description > --- > > **Problem Statement:** > Ranger db table `x_group_users` has columns "added_by_id" and "upd_by_id" > which should be filled with the id of logged-in user. Whenever group's-users > mapping is pushed from usersync module at that time these values are > considered from a config "ranger.xuser.createdByUserId" which is set to 1 in > ranger-default-admin-site.xml and code as well. > If users have set ranger db table's primary key's auto-increment offset to > any number other than 1 and have not updated the same accordingly in the > config "ranger.xuser.createdByUserId" then request may fail due to Foreignkey > constraint violation. > > Example Case: if primary key's auto-increment start value has been set to 2 > in db engine then first entry in table x_portal_user will have primary-key id > 2. while if config "ranger.xuser.createdByUserId" is set to 1 then due to > non availablity of userID 1 when it will try to insert group-user mappinng > entry in `x_group_users` table with value 1 for the column "added_by_id" and > "upd_by_id" it will cause to fail the request. > > **Proposed solution:** Rather directly putting the config's > "ranger.xuser.createdByUserId" value in "added_by_id" and "upd_by_id" field > of `x_group_users` table we can check whether user id exist in x_portal_user > or not. if it does not exist then do not set the value received from config > "ranger.xuser.createdByUserId" and avoid the Foreign-key Constraint Violation > Exception. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > 9345e8180 > > > Diff: https://reviews.apache.org/r/74039/diff/1/ > > > Testing > --- > > With the patch issue is not reproducing when i have set the > auto_increment_increment to 3 in mysql server env. > > > Thanks, > > Pradeep Agrawal > >
