[jira] [Commented] (RANGER-4131) clientIP is not logged for create/grant/revoke role operations via hive beeline

2023-03-20 Thread Fateh Singh (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702973#comment-17702973
 ] 

Fateh Singh commented on RANGER-4131:
-

Patch merged to master: 
https://github.com/apache/ranger/commit/7901d88e2aeac1d515581a0e987e7d4318da78b1

> clientIP is not logged for create/grant/revoke role operations via hive 
> beeline
> ---
>
> Key: RANGER-4131
> URL: https://issues.apache.org/jira/browse/RANGER-4131
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fateh Singh
>Assignee: Fateh Singh
>Priority: Major
>
> For user operations via hive beeline to create role, grant role to user, 
> revoke role from user ranger access audits are not displaying clientIP



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ranger] kumaab merged pull request #234: RANGER 4131: Use SessionState to log clientIP in RangerHiveAuthorizer

2023-03-20 Thread via GitHub


kumaab merged PR #234:
URL: https://github.com/apache/ranger/pull/234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Review Request 74356: RANGER-4144 : Fixing test suite for kafka plugin

2023-03-20 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74356/
---

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, and 
Velmurugan Periasamy.


Bugs: RANGER-4144
https://issues.apache.org/jira/browse/RANGER-4144


Repository: ranger


Description
---

Changed version of curator test version from 2.12.0 to 5.4.0 & fixed Java 
Autoboxing issues


Diffs
-

  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
 d24ee1e57 
  pom.xml 1e77f5191 


Diff: https://reviews.apache.org/r/74356/diff/1/


Testing
---

1. Run Unit Test (as part of build) done on Linux Platform


Thanks,

Selvamohan Neethiraj



[jira] [Updated] (RANGER-4144) Fixed Kafka Test Suite Issues

2023-03-20 Thread Selvamohan Neethiraj (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-4144:
-
Attachment: 0001-RANGER-4144-fixed-kafka-plugin-test-suite-issues.patch

> Fixed Kafka Test Suite Issues
> -
>
> Key: RANGER-4144
> URL: https://issues.apache.org/jira/browse/RANGER-4144
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: 2.4.0
>Reporter: Selvamohan Neethiraj
>Assignee: Selvamohan Neethiraj
>Priority: Critical
> Fix For: 2.4.0
>
> Attachments: 
> 0001-RANGER-4144-fixed-kafka-plugin-test-suite-issues.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4144) Fixed Kafka Test Suite Issues

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4144:


 Summary: Fixed Kafka Test Suite Issues
 Key: RANGER-4144
 URL: https://issues.apache.org/jira/browse/RANGER-4144
 Project: Ranger
  Issue Type: Bug
  Components: plugins
Affects Versions: 2.4.0
Reporter: Selvamohan Neethiraj
Assignee: Selvamohan Neethiraj
 Fix For: 2.4.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4143) Publish release artifacts

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4143:


 Summary: Publish release artifacts
 Key: RANGER-4143
 URL: https://issues.apache.org/jira/browse/RANGER-4143
 Project: Ranger
  Issue Type: Sub-task
  Components: Ranger
Reporter: Selvamohan Neethiraj






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4142) Update Apache Ranger website with 2.4.0

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4142:


 Summary: Update Apache Ranger website with 2.4.0 
 Key: RANGER-4142
 URL: https://issues.apache.org/jira/browse/RANGER-4142
 Project: Ranger
  Issue Type: Sub-task
  Components: Ranger
Reporter: Selvamohan Neethiraj






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4141) Change pom version from 2.4.0-SNAPSHOT to 2.4.0

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4141:


 Summary: Change pom version from 2.4.0-SNAPSHOT to 2.4.0
 Key: RANGER-4141
 URL: https://issues.apache.org/jira/browse/RANGER-4141
 Project: Ranger
  Issue Type: Sub-task
  Components: Ranger
Reporter: Selvamohan Neethiraj






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4140) Release Apache Ranger 2.4.0

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4140:


 Summary: Release Apache Ranger 2.4.0
 Key: RANGER-4140
 URL: https://issues.apache.org/jira/browse/RANGER-4140
 Project: Ranger
  Issue Type: Task
  Components: Ranger
Affects Versions: 2.3.0
Reporter: Selvamohan Neethiraj
Assignee: Selvamohan Neethiraj
 Fix For: 2.4.0


Tracking 2.4.0 release tasks.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread YiJi Gao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225284
---


Ship it!




Ship It!

- YiJi Gao


On 三月 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated 三月 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>



Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread YiJi Gao


> On 三月 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once
> 
> Ramachandran Krishnan wrote:
> I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
> In the future we can accomadate more fields with different type (not 
> List may be some other object) in the same modal 
> RangerUsersAndGroups if it is needed
> 
> Ramachandran Krishnan wrote:
> cc madhan
> 
> Ramachandran Krishnan wrote:
> if you use Map ,we need to validate the correct key whether user is 
> paased the correct key or not (users or groups) ?
> 
> YiJi Gao wrote:
> if we need to accomadte more fields, emmm...that makes sense. Speaking of 
> field validation, it would be convenient to use map.getOrDefault() instead of 
> if-else.
> 
> Ramachandran Krishnan wrote:
> it would be convenient to use map.getOrDefault() instead of if-else -- 
> that i agree .
> I feel adding the new modal to accomadate the groups,users list also not 
> a bad option in this case

Totally agree.


- YiJi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On 三月 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated 三月 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: 

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread Ramachandran Krishnan


> On March 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once
> 
> Ramachandran Krishnan wrote:
> I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
> In the future we can accomadate more fields with different type (not 
> List may be some other object) in the same modal 
> RangerUsersAndGroups if it is needed
> 
> Ramachandran Krishnan wrote:
> cc madhan
> 
> Ramachandran Krishnan wrote:
> if you use Map ,we need to validate the correct key whether user is 
> paased the correct key or not (users or groups) ?
> 
> YiJi Gao wrote:
> if we need to accomadte more fields, emmm...that makes sense. Speaking of 
> field validation, it would be convenient to use map.getOrDefault() instead of 
> if-else.

it would be convenient to use map.getOrDefault() instead of if-else -- that i 
agree .
I feel adding the new modal to accomadate the groups,users list also not a bad 
option in this case


- Ramachandran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On March 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated March 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> 

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread YiJi Gao


> On 三月 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once
> 
> Ramachandran Krishnan wrote:
> I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
> In the future we can accomadate more fields with different type (not 
> List may be some other object) in the same modal 
> RangerUsersAndGroups if it is needed
> 
> Ramachandran Krishnan wrote:
> cc madhan
> 
> Ramachandran Krishnan wrote:
> if you use Map ,we need to validate the correct key whether user is 
> paased the correct key or not (users or groups) ?

if we need to accomadte more fields, emmm...that makes sense. Speaking of field 
validation, it would be convenient to use map.getOrDefault() instead of if-else.


- YiJi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On 三月 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated 三月 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>



[jira] [Updated] (RANGER-4085) Search filter hint is not available where you search for policy

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4085:

Attachment: 0001-RANGER-4085.patch

> Search filter hint is not available where you search for policy
> ---
>
> Key: RANGER-4085
> URL: https://issues.apache.org/jira/browse/RANGER-4085
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Attachments: 0001-RANGER-4085.patch, Screenshot 2023-02-15 at 4.34.33 
> PM.png
>
>
> Search filter hint is not available where you search for policy
> Verify with old ranger UI we had i icon had hints 
> eg below for hadoop sql
> {code:java}
> Search Filter HintsWildcard searches ( for example using * or ? ) are not 
> currently supported.Group Name : Name of Group.Policy Name : Enter name of 
> policy.Status : Status of Policy Enable/Disable.User Name : Name of User.Role 
> Name : Name of Role.Policy Label : Label of policyHive Database : Hive 
> database.URL : Hive url.Hive Service : Hive ServiceGlobal : GlobalStorage 
> Type : Storage TypeHive Table : Table NameHive UDF : Hive udf.Storage URL : 
> Storage URLHive Column : Column Name {code}
> Actual : Search filter Hint is missing 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4085) Search filter hint is not available where you search for policy

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4085:

Attachment: (was: 0001-RANGER-4085.patch)

> Search filter hint is not available where you search for policy
> ---
>
> Key: RANGER-4085
> URL: https://issues.apache.org/jira/browse/RANGER-4085
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Attachments: 0001-RANGER-4085.patch, Screenshot 2023-02-15 at 4.34.33 
> PM.png
>
>
> Search filter hint is not available where you search for policy
> Verify with old ranger UI we had i icon had hints 
> eg below for hadoop sql
> {code:java}
> Search Filter HintsWildcard searches ( for example using * or ? ) are not 
> currently supported.Group Name : Name of Group.Policy Name : Enter name of 
> policy.Status : Status of Policy Enable/Disable.User Name : Name of User.Role 
> Name : Name of Role.Policy Label : Label of policyHive Database : Hive 
> database.URL : Hive url.Hive Service : Hive ServiceGlobal : GlobalStorage 
> Type : Storage TypeHive Table : Table NameHive UDF : Hive udf.Storage URL : 
> Storage URLHive Column : Column Name {code}
> Actual : Search filter Hint is missing 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74355: RANGER-4085: Search filter hint is not available where you search for policy

2023-03-20 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74355/
---

Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, 
Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4085
https://issues.apache.org/jira/browse/RANGER-4085


Repository: ranger


Description
---

Search filter hint is not available where you search for policy

Verify with old ranger UI we had i icon had hints 

eg below for hadoop sql

Search Filter HintsWildcard searches ( for example using * or ? ) are not 
currently supported.Group Name : Name of Group.Policy Name : Enter name of 
policy.Status : Status of Policy Enable/Disable.User Name : Name of User.Role 
Name : Name of Role.Policy Label : Label of policyHive Database : Hive 
database.URL : Hive url.Hive Service : Hive ServiceGlobal : GlobalStorage Type 
: Storage TypeHive Table : Table NameHive UDF : Hive udf.Storage URL : Storage 
URLHive Column : Column Name 

Actual : Search filter Hint is missing


Diffs
-

  security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb441373 
  security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 63493c57b 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx
 987c3210e 


Diff: https://reviews.apache.org/r/74355/diff/1/


Testing
---

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
  -Policy listing page


Thanks,

Brijesh Bhalala



Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread Ramachandran Krishnan


> On March 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once
> 
> Ramachandran Krishnan wrote:
> I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
> In the future we can accomadate more fields with different type (not 
> List may be some other object) in the same modal 
> RangerUsersAndGroups if it is needed
> 
> Ramachandran Krishnan wrote:
> cc madhan

if you use Map ,we need to validate the correct key whether user is paased the 
correct key or not (users or groups) ?


- Ramachandran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On March 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated March 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>



Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread Ramachandran Krishnan


> On March 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once

I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
In the future we can accomadate more fields with different type (not 
List may be some other object) in the same modal RangerUsersAndGroups 
if it is needed


- Ramachandran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On March 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated March 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>



Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread Ramachandran Krishnan


> On March 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.
> 
> Ramachandran Krishnan wrote:
> Sure let me give a try and test it once
> 
> Ramachandran Krishnan wrote:
> I feel RangerUsersAndGroups (modal class ) will be a cleaner apporach 
> In the future we can accomadate more fields with different type (not 
> List may be some other object) in the same modal 
> RangerUsersAndGroups if it is needed

cc madhan


- Ramachandran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On March 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated March 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>



[jira] [Commented] (RANGER-4139) DOC SITE: ranger.apache.org - revamp site's look and feel

2023-03-20 Thread Ramachandran (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702716#comment-17702716
 ] 

Ramachandran commented on RANGER-4139:
--

[~sneethiraj] I guess the apache contributor and committer list needs to be 
updated 

Refer:

https://ranger.apache.org/team-list.html

> DOC SITE: ranger.apache.org - revamp site's look and feel 
> --
>
> Key: RANGER-4139
> URL: https://issues.apache.org/jira/browse/RANGER-4139
> Project: Ranger
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Selvamohan Neethiraj
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4096) [Ranger UI] [React JS] "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4096:

Attachment: 0003-RANGER-4096.patch

> [Ranger UI] [React JS] "show all users" button is not available in the show 
> users prompt of groups table even if the users list is longer than 100.
> ---
>
> Key: RANGER-4096
> URL: https://issues.apache.org/jira/browse/RANGER-4096
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Kundan Kumar Jha
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4096.patch, 0002-RANGER-4096.patch, 
> 0003-RANGER-4096.patch
>
>
> Behaviour in React UI:
> "Show all users" option is not available although if the no. of user added to 
> a group is more than 100 and they are clipped in the show user prompt.
> Behaviour in backbone JS UI:
> In the similar case in old UI the show all users option is available.
>  
> Steps to reproduce:
>  # create a group "\{random}_group".
>  # Add more than 100 users with "\{random}_group" as group and click on the 
> users column of "\{random}_group" group from group tables.
>  # Its clipping the users list after 100 but not showing the option to show 
> all users. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4096) [Ranger UI] [React JS] "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4096:

Attachment: (was: 0003-RANGER-4096.patch)

> [Ranger UI] [React JS] "show all users" button is not available in the show 
> users prompt of groups table even if the users list is longer than 100.
> ---
>
> Key: RANGER-4096
> URL: https://issues.apache.org/jira/browse/RANGER-4096
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Kundan Kumar Jha
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4096.patch, 0002-RANGER-4096.patch, 
> 0003-RANGER-4096.patch
>
>
> Behaviour in React UI:
> "Show all users" option is not available although if the no. of user added to 
> a group is more than 100 and they are clipped in the show user prompt.
> Behaviour in backbone JS UI:
> In the similar case in old UI the show all users option is available.
>  
> Steps to reproduce:
>  # create a group "\{random}_group".
>  # Add more than 100 users with "\{random}_group" as group and click on the 
> users column of "\{random}_group" group from group tables.
>  # Its clipping the users list after 100 but not showing the option to show 
> all users. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.

2023-03-20 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/
---

(Updated March 20, 2023, 1:47 p.m.)


Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, 
Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4096
https://issues.apache.org/jira/browse/RANGER-4096


Repository: ranger


Description
---

Behaviour in React UI:

"Show all users" option is not available although if the no. of user added to a 
group is more than 100 and they are clipped in the show user prompt.

Behaviour in backbone JS UI:

In the similar case in old UI the show all users option is available.

 

Steps to reproduce:
 # create a group "{random}_group".
 # Add more than 100 users with "{random}_group" as group and click on the 
users column of "{random}_group" group from group tables.
 # Its clipping the users list after 100 but not showing the option to show all 
users.


Diffs (updated)
-

  
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx
 3c253544f 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx
 62ec1d8ad 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx
 28e9a36bd 


Diff: https://reviews.apache.org/r/74326/diff/3/

Changes: https://reviews.apache.org/r/74326/diff/2-3/


Testing
---

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things :-
  - CRUD operation for Group Module
  - Group Associate User modal
  - Group Listing Table


Thanks,

Brijesh Bhalala



Re: Request to add as contributor to Apache Ranger

2023-03-20 Thread Selvamohan Neethiraj
Welcome to Ranger Community. I have added you as a Apache Ranger Contributor. 

Thanks,
Selva-

On 2023/03/07 07:47:54 Lei Yao wrote:
> Hi community, 
> I would like to contribute to the Apache Ranger project, please add me as a 
> contributor.My JIra User Id is yaolei
> 
> Thanks and Regards


[jira] [Updated] (RANGER-4091) Policy condition & Permission window should close by any click events

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4091:

Attachment: (was: 0002-RANGER-4091.patch)

> Policy condition  & Permission window should close by any click events
> --
>
> Key: RANGER-4091
> URL: https://issues.apache.org/jira/browse/RANGER-4091
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Critical
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4091.patch, 0002-RANGER-4091.patch, 
> Screenshot 2023-02-15 at 9.14.47 PM.png
>
>
> Policy condition window Overlaps with Policy permisions window as Policy 
> condition  & Permission window is not closing by any click events
> Steps to reproduce :
> 1. Try to create any tag based policy 
> 2. Click on Policy condition + icon
> 3. Click on permission + icon
> Actual :  Policy condition  & Permission window is not closing by any click 
> events
> Expected :   Policy condition  & Permission window should close by any click 
> events



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4091) Policy condition & Permission window should close by any click events

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4091:

Attachment: 0002-RANGER-4091.patch

> Policy condition  & Permission window should close by any click events
> --
>
> Key: RANGER-4091
> URL: https://issues.apache.org/jira/browse/RANGER-4091
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Critical
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4091.patch, 0002-RANGER-4091.patch, 
> Screenshot 2023-02-15 at 9.14.47 PM.png
>
>
> Policy condition window Overlaps with Policy permisions window as Policy 
> condition  & Permission window is not closing by any click events
> Steps to reproduce :
> 1. Try to create any tag based policy 
> 2. Click on Policy condition + icon
> 3. Click on permission + icon
> Actual :  Policy condition  & Permission window is not closing by any click 
> events
> Expected :   Policy condition  & Permission window should close by any click 
> events



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events

2023-03-20 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/
---

(Updated March 20, 2023, 1:31 p.m.)


Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, 
Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4091
https://issues.apache.org/jira/browse/RANGER-4091


Repository: ranger


Description
---

Policy condition window Overlaps with Policy permisions window as Policy 
condition  & Permission window is not closing by any click events

Steps to reproduce :

1. Try to create any tag based policy 
2. Click on Policy condition + icon
3. Click on permission + icon

Actual :  Policy condition  & Permission window is not closing by any click 
events

Expected :   Policy condition  & Permission window should close by any click 
events


Diffs (updated)
-

  security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx 
d2efcb679 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb441373 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx
 5d6ad75a1 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx
 e556e2546 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx
 863ae5e96 


Diff: https://reviews.apache.org/r/74323/diff/2/

Changes: https://reviews.apache.org/r/74323/diff/1-2/


Testing
---

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
  -CRUD Operation in Policy module.
  -Policy Items tables in Policy Form.
  -Permission and policy conditions window.


Thanks,

Brijesh Bhalala



[jira] [Created] (RANGER-4139) DOC SITE: ranger.apache.org - revamp site's look and feel

2023-03-20 Thread Selvamohan Neethiraj (Jira)
Selvamohan Neethiraj created RANGER-4139:


 Summary: DOC SITE: ranger.apache.org - revamp site's look and feel 
 Key: RANGER-4139
 URL: https://issues.apache.org/jira/browse/RANGER-4139
 Project: Ranger
  Issue Type: Improvement
  Components: documentation
Affects Versions: 3.0.0, 2.4.0
Reporter: Selvamohan Neethiraj






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74353: RANGER-4137: Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74353/
---

Review request for ranger, Dineshkumar Yadav, Mehul Parikh, and sanket shelar.


Bugs: RANGER-4137
https://issues.apache.org/jira/browse/RANGER-4137


Repository: ranger


Description
---

Currently, service users other than yarn and impala are included in audit 
filters to avoid logging of audits for solr access (query and update - for 
audits collection). This JIRA is filed to include yarn and impala users to the 
list of users


Diffs
-

  agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json 
4bbb6ffaa 


Diff: https://reviews.apache.org/r/74353/diff/1/


Testing
---

Tested and verified that yarn and impala users has been successfully added to 
audit filter for solr servicedef.


Thanks,

Rakesh Gupta



[jira] [Updated] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta updated RANGER-4137:
-
Attachment: 0001-RANGER-4137.patch

> Add yarn and impala users to audit filter for solr servicedef to avoid 
> logging of audits
> 
>
> Key: RANGER-4137
> URL: https://issues.apache.org/jira/browse/RANGER-4137
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Rakesh Gupta
>Assignee: Rakesh Gupta
>Priority: Major
> Attachments: 0001-RANGER-4137.patch, solr_auditfilter.png
>
>
> Currently, service users other than yarn and impala are included in audit 
> filters to avoid logging of audits for solr access (query and update - for 
> audits collection). This JIRA is filed to include yarn and impala users to 
> the list of users



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4138) Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar updated RANGER-4138:

Attachment: 0001-RANGER-4138.patch

> Build ranger-react UI and backbone UI code base in webapp
> -
>
> Key: RANGER-4138
> URL: https://issues.apache.org/jira/browse/RANGER-4138
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Mugdha Varadkar
>Priority: Major
> Attachments: 0001-RANGER-4138.patch, 
> screenshot-backbone-ranger-option.png
>
>
> This jira is tracking changes to build ranger-react and backbone code base 
> into webapp directory of Ranger Admin.
> With this change, by default Ranger Admin UI with react code base will get 
> loaded. If user want to view Ranger Admin UI with backbone code base, they 
> will get a option in the Top User Profile section as - "Backbone Classic UI".
>  !screenshot-backbone-ranger-option.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74352: RANGER-4138 Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74352/
---

Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, 
Mehul Parikh, Nikunj Pansuriya, and Velmurugan Periasamy.


Bugs: RANGER-4138
https://issues.apache.org/jira/browse/RANGER-4138


Repository: ranger


Description
---

This review is tracking changes to build ranger-react and backbone code base 
into webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".

Removing the profiles security-admin-react and security-admin-backbone used to 
build react and backbone respectively.

No need to pass -Psecurity-admin-react profile option to mvn command to build 
Ranger Admin code base with react.


Diffs
-

  security-admin/pom.xml 2e5e21950 
  security-admin/src/main/webapp/index.html  
  security-admin/src/main/webapp/react-webapp/src/views/Header.jsx 9d22d3a14 
  security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 87e4dca27 
  security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 
d8c2112f1 


Diff: https://reviews.apache.org/r/74352/diff/1/


Testing
---

Build ranger using below command and setup a local cluster,

mvn clean compile package -DskipTest


Thanks,

Mugdha Varadkar



[jira] [Updated] (RANGER-4085) Search filter hint is not available where you search for policy

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4085:

Attachment: (was: 0001-RANGER-4085.patch)

> Search filter hint is not available where you search for policy
> ---
>
> Key: RANGER-4085
> URL: https://issues.apache.org/jira/browse/RANGER-4085
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Attachments: 0001-RANGER-4085.patch, Screenshot 2023-02-15 at 4.34.33 
> PM.png
>
>
> Search filter hint is not available where you search for policy
> Verify with old ranger UI we had i icon had hints 
> eg below for hadoop sql
> {code:java}
> Search Filter HintsWildcard searches ( for example using * or ? ) are not 
> currently supported.Group Name : Name of Group.Policy Name : Enter name of 
> policy.Status : Status of Policy Enable/Disable.User Name : Name of User.Role 
> Name : Name of Role.Policy Label : Label of policyHive Database : Hive 
> database.URL : Hive url.Hive Service : Hive ServiceGlobal : GlobalStorage 
> Type : Storage TypeHive Table : Table NameHive UDF : Hive udf.Storage URL : 
> Storage URLHive Column : Column Name {code}
> Actual : Search filter Hint is missing 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4085) Search filter hint is not available where you search for policy

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4085:

Attachment: 0001-RANGER-4085.patch

> Search filter hint is not available where you search for policy
> ---
>
> Key: RANGER-4085
> URL: https://issues.apache.org/jira/browse/RANGER-4085
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anupam Rai
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Attachments: 0001-RANGER-4085.patch, Screenshot 2023-02-15 at 4.34.33 
> PM.png
>
>
> Search filter hint is not available where you search for policy
> Verify with old ranger UI we had i icon had hints 
> eg below for hadoop sql
> {code:java}
> Search Filter HintsWildcard searches ( for example using * or ? ) are not 
> currently supported.Group Name : Name of Group.Policy Name : Enter name of 
> policy.Status : Status of Policy Enable/Disable.User Name : Name of User.Role 
> Name : Name of Role.Policy Label : Label of policyHive Database : Hive 
> database.URL : Hive url.Hive Service : Hive ServiceGlobal : GlobalStorage 
> Type : Storage TypeHive Table : Table NameHive UDF : Hive udf.Storage URL : 
> Storage URLHive Column : Column Name {code}
> Actual : Search filter Hint is missing 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4138) Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar updated RANGER-4138:

Description: 
This jira is tracking changes to build ranger-react and backbone code base into 
webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".


 !screenshot-backbone-ranger-option.png! 


  was:
This jira is tracking changes to build ranger-react and backbone code base into 
webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".






> Build ranger-react UI and backbone UI code base in webapp
> -
>
> Key: RANGER-4138
> URL: https://issues.apache.org/jira/browse/RANGER-4138
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Mugdha Varadkar
>Priority: Major
> Attachments: screenshot-backbone-ranger-option.png
>
>
> This jira is tracking changes to build ranger-react and backbone code base 
> into webapp directory of Ranger Admin.
> With this change, by default Ranger Admin UI with react code base will get 
> loaded. If user want to view Ranger Admin UI with backbone code base, they 
> will get a option in the Top User Profile section as - "Backbone Classic UI".
>  !screenshot-backbone-ranger-option.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4138) Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar updated RANGER-4138:

Attachment: screenshot-backbone-ranger-option.png

> Build ranger-react UI and backbone UI code base in webapp
> -
>
> Key: RANGER-4138
> URL: https://issues.apache.org/jira/browse/RANGER-4138
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Mugdha Varadkar
>Priority: Major
> Attachments: screenshot-backbone-ranger-option.png
>
>
> This jira is tracking changes to build ranger-react and backbone code base 
> into webapp directory of Ranger Admin.
> With this change, by default Ranger Admin UI with react code base will get 
> loaded. If user want to view Ranger Admin UI with backbone code base, they 
> will get a option in the Top User Profile section as - "Backbone Classic UI".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4138) Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar updated RANGER-4138:

Description: 
This jira is tracking changes to build ranger-react and backbone code base into 
webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".





  was:
This jira is tracking changes to build ranger-react and backbone code base into 
webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".





> Build ranger-react UI and backbone UI code base in webapp
> -
>
> Key: RANGER-4138
> URL: https://issues.apache.org/jira/browse/RANGER-4138
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Mugdha Varadkar
>Priority: Major
>
> This jira is tracking changes to build ranger-react and backbone code base 
> into webapp directory of Ranger Admin.
> With this change, by default Ranger Admin UI with react code base will get 
> loaded. If user want to view Ranger Admin UI with backbone code base, they 
> will get a option in the Top User Profile section as - "Backbone Classic UI".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4138) Build ranger-react UI and backbone UI code base in webapp

2023-03-20 Thread Mugdha Varadkar (Jira)
Mugdha Varadkar created RANGER-4138:
---

 Summary: Build ranger-react UI and backbone UI code base in webapp
 Key: RANGER-4138
 URL: https://issues.apache.org/jira/browse/RANGER-4138
 Project: Ranger
  Issue Type: Task
  Components: Ranger
Reporter: Mugdha Varadkar
Assignee: Mugdha Varadkar


This jira is tracking changes to build ranger-react and backbone code base into 
webapp directory of Ranger Admin.

With this change, by default Ranger Admin UI with react code base will get 
loaded. If user want to view Ranger Admin UI with backbone code base, they will 
get a option in the Top User Profile section as - "Backbone Classic UI".






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4078) [Ranger UI] [React JS] Error displayed on page when navigating to audits tab and clicking on clear search button

2023-03-20 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4078:

Attachment: (was: 0002-RANGER-4078.patch)

> [Ranger UI] [React JS] Error displayed on page when navigating to audits tab 
> and clicking on clear search button
> 
>
> Key: RANGER-4078
> URL: https://issues.apache.org/jira/browse/RANGER-4078
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhishek
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4078.patch
>
>
> {color:#172b4d}On navigating to the audits page from any other page,{color}
> {color:#172b4d}first the search bar to filter audits loads and then the audit 
> entries are loaded.{color}
> {color:#172b4d}When the clear search bar button (X symbol) in the search bar 
> is clicked before the audit entries are loaded, an error is displayed on the 
> screen.{color}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta updated RANGER-4137:
-
External issue URL:   (was: https://jira.cloudera.com/browse/CDPD-49589)

> Add yarn and impala users to audit filter for solr servicedef to avoid 
> logging of audits
> 
>
> Key: RANGER-4137
> URL: https://issues.apache.org/jira/browse/RANGER-4137
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Rakesh Gupta
>Assignee: Rakesh Gupta
>Priority: Major
> Attachments: solr_auditfilter.png
>
>
> Currently, service users other than yarn and impala are included in audit 
> filters to avoid logging of audits for solr access (query and update - for 
> audits collection). This JIRA is filed to include yarn and impala users to 
> the list of users



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta reassigned RANGER-4137:


External issue URL: https://jira.cloudera.com/browse/CDPD-49589
  Assignee: Rakesh Gupta

> Add yarn and impala users to audit filter for solr servicedef to avoid 
> logging of audits
> 
>
> Key: RANGER-4137
> URL: https://issues.apache.org/jira/browse/RANGER-4137
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Rakesh Gupta
>Assignee: Rakesh Gupta
>Priority: Major
> Attachments: solr_auditfilter.png
>
>
> Currently, service users other than yarn and impala are included in audit 
> filters to avoid logging of audits for solr access (query and update - for 
> audits collection). This JIRA is filed to include yarn and impala users to 
> the list of users



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta updated RANGER-4137:
-
Attachment: solr_auditfilter.png

> Add yarn and impala users to audit filter for solr servicedef to avoid 
> logging of audits
> 
>
> Key: RANGER-4137
> URL: https://issues.apache.org/jira/browse/RANGER-4137
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Rakesh Gupta
>Priority: Major
> Attachments: solr_auditfilter.png
>
>
> Currently, service users other than yarn and impala are included in audit 
> filters to avoid logging of audits for solr access (query and update - for 
> audits collection). This JIRA is filed to include yarn and impala users to 
> the list of users



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta updated RANGER-4137:
-
Description: Currently, service users other than yarn and impala are 
included in audit filters to avoid logging of audits for solr access (query and 
update - for audits collection). This JIRA is filed to include yarn and impala 
users to the list of users

> Add yarn and impala users to audit filter for solr servicedef to avoid 
> logging of audits
> 
>
> Key: RANGER-4137
> URL: https://issues.apache.org/jira/browse/RANGER-4137
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Rakesh Gupta
>Priority: Major
> Attachments: solr_auditfilter.png
>
>
> Currently, service users other than yarn and impala are included in audit 
> filters to avoid logging of audits for solr access (query and update - for 
> audits collection). This JIRA is filed to include yarn and impala users to 
> the list of users



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4137) Add yarn and impala users to audit filter for solr servicedef to avoid logging of audits

2023-03-20 Thread Rakesh Gupta (Jira)
Rakesh Gupta created RANGER-4137:


 Summary: Add yarn and impala users to audit filter for solr 
servicedef to avoid logging of audits
 Key: RANGER-4137
 URL: https://issues.apache.org/jira/browse/RANGER-4137
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Rakesh Gupta






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

2023-03-20 Thread Ramachandran Krishnan


> On March 19, 2023, 5:03 p.m., YiJi Gao wrote:
> > Would it be more extensible to use map instead? In this case, there's no 
> > need for an extra modal class.
> > Here's an example.
> > ```java
> > @PutMapping("/example")
> > public ResponseEntity handlePutRequest(
> > @RequestBody Map> request,
> > @RequestParam("myBooleanParam") boolean myBooleanParam
> > ) {
> > List firstList = request.get("firstList");
> > List secondList = request.get("secondList");
> > 
> > // do something with the lists and the boolean parameter
> > 
> > return ResponseEntity.ok("Success");
> > }
> > 
> > ```
> 
> Ramachandran Krishnan wrote:
> Are you expecting something like this ? 
>  
>  @PutMapping("/example")
> public ResponseEntity handlePutRequest(
> MultiValueMap< String, List > rangerUsersAndGroupMap,
> @RequestParam("myBooleanParam") boolean myBooleanParam
> ) {
>List userList = request.get("users");
>   List groupList = request.get("groups");
> // do something with the lists and the boolean parameter
> 
> return ResponseEntity.ok("Success");
> }
> 
> YiJi Gao wrote:
> Exactly.

Sure let me give a try and test it once


- Ramachandran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/#review225274
---


On March 15, 2023, 3:24 p.m., Ramachandran Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74349/
> ---
> 
> (Updated March 15, 2023, 3:24 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4133
> https://issues.apache.org/jira/browse/RANGER-4133
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Apis:
> 
> API :addUsersAndGroups
> 
> URI:/roles/roles/{id}/addUsersAndGroups
> 
> In the API we mentioned a couple of fields (List users, List 
> groups, Boolean isAdmin). 
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups, Boolean 
> isAdmin –(RangerUsersAndGroups –Modal mentioned above to accommodate users, 
> groups, isAdmin)
> 
> 
> API :removeUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
> 
> API :removeAdminFromUsersAndGroups
> 
> URI:/roles/roles/{id}/removeUsersAndGroups
> 
> 
> In the API we mentioned a couple of fields (List users, List 
> groups)
> How the caller will pass the fields 
> Proposed Solution:
> Via query Parameter (Limitation: we can not pass more characters as part of 
> URI )
> Via Request payload of List users, List groups 
> (RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 85cd7dd67 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 
> 73a593e9f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 217c1bba3 
> 
> 
> Diff: https://reviews.apache.org/r/74349/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>