It would be great if you take a look at some of the Pull requests were raised by me if possible
Hi All,
Could you please take a look at the below-mentioned Pull requests if
possible
Bugs/Feature Review URL
RANGER-4195:Exposing the Ranger REST API is used to fetch the health check
status of
Ranger Admin https://reviews.apache.org/r/74405/
RANGER-4250 :Ranger throws BAD Request Error when we are not passing
exec user to the getRoles (/public/v2/api/roles/name/{name})
https://reviews.apache.org/r/74453/
RANGER-4133 Improvement in Ranger Roles Rest API's
https://reviews.apache.org/r/74349/
RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception
https://reviews.apache.org/r/74398/Regards,
Ram
[GitHub] [ranger] kumaab commented on a diff in pull request #253: RANGER-4230: Add REST APIs to force delete external users & groups
kumaab commented on code in PR #253:
URL: https://github.com/apache/ranger/pull/253#discussion_r1212601478
##
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java:
##
@@ -2400,6 +2426,31 @@ public synchronized void deleteXUser(Long id, boolean
force) {
}
}
+ public void forceDeleteUsers(List users){
+ long startTime = Time.now();
+ for(VXUser user: users){
+ Long userId = user.getId();
+ TransactionTemplate txTemplate = new
TransactionTemplate(txManager);
+
txTemplate.setPropagationBehavior(TransactionDefinition.PROPAGATION_REQUIRES_NEW);
+ try {
+ txTemplate.execute(new
TransactionCallback() {
+ @Override
+ public Object
doInTransaction(TransactionStatus status) {
+ deleteXUser(userId, true);
+ return null;
+ }
+ });
+ } catch (Throwable ex) {
+ logger.error("forceDeleteUsers(): Failed to
delete user id: " + userId + " ", ex);
+ throw new RuntimeException(ex);
Review Comment:
Sure, I'll revise the PR to continue with deletes despite failures.
I believe getting the usernames for all users deleted/failed deletes is an
overhead since this would result in another db call(with new jpa query), and
ignoring the rare occurrence of transaction exceptions(in which we might not
get the logs from deleteUser()), info regarding every user is already logged as
part of deleteUser() where we print the username of the user getting deleted.
For debugging purposes in case of transaction failures, username of the user is
still retrievable using the userid in the catch block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ranger] kumaab commented on a diff in pull request #253: RANGER-4230: Add REST APIs to force delete external users & groups
kumaab commented on code in PR #253:
URL: https://github.com/apache/ranger/pull/253#discussion_r1212180445
##
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java:
##
@@ -863,6 +864,61 @@ public void deleteXUserByUserName(@PathParam("userName")
String userName,
xUserMgr.deleteXUser(vxUser.getId(), forceDelete);
}
+
+ /**
+* Proceed with caution: Force deletes users from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/users")
+ @PreAuthorize("hasRole('ROLE_SYS_ADMIN')")
+ @Produces({ "application/json" })
+ public Response forceDeleteUsers(@Context HttpServletRequest request) {
+ SearchCriteria searchCriteria = new SearchCriteria();
+ searchUtil.extractString(
+ request, searchCriteria, "name", "User
name",null);
+ searchUtil.extractString(
+ request, searchCriteria, "emailAddress", "Email
Address", null);
+ searchUtil.extractInt(
+ request, searchCriteria, "userSource", "User
Source");
+ searchUtil.extractInt(
+ request, searchCriteria, "isVisible", "User
Visibility");
+ searchUtil.extractInt(
+ request, searchCriteria, "status", "User
Status");
+ searchUtil.extractString(
+ request, searchCriteria, "syncSource", "Sync
Source", null);
+ searchUtil.extractRoleString(
+ request, searchCriteria, "userRole", "Role",
null);
+
+ VXUserList userList = xUserMgr.searchXUsers(searchCriteria);
+ xUserMgr.forceDeleteUsers(userList.getList());
+ return Response.ok(userList.getListSize() + " users deleted
successfully").build();
+ }
+
+ /**
+* Proceed with caution: Force deletes groups from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/groups")
Review Comment:
The API is now specific to external groups, updated the PR sometime back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ranger] kumaab commented on a diff in pull request #253: RANGER-4230: Add REST APIs to force delete external users & groups
kumaab commented on code in PR #253:
URL: https://github.com/apache/ranger/pull/253#discussion_r1212180002
##
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java:
##
@@ -863,6 +864,61 @@ public void deleteXUserByUserName(@PathParam("userName")
String userName,
xUserMgr.deleteXUser(vxUser.getId(), forceDelete);
}
+
+ /**
+* Proceed with caution: Force deletes users from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/users")
Review Comment:
The API is now specific to external users, updated the PR sometime back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ranger] mneethiraj commented on a diff in pull request #253: RANGER-4230: Add REST APIs to force delete external users & groups
mneethiraj commented on code in PR #253:
URL: https://github.com/apache/ranger/pull/253#discussion_r1192692660
##
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java:
##
@@ -863,6 +864,61 @@ public void deleteXUserByUserName(@PathParam("userName")
String userName,
xUserMgr.deleteXUser(vxUser.getId(), forceDelete);
}
+
+ /**
+* Proceed with caution: Force deletes users from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/users")
Review Comment:
I suggest replacing `external` in the URI with `force', since this API is
not specific to external users i.e., userSource query-param.
##
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java:
##
@@ -863,6 +864,61 @@ public void deleteXUserByUserName(@PathParam("userName")
String userName,
xUserMgr.deleteXUser(vxUser.getId(), forceDelete);
}
+
+ /**
+* Proceed with caution: Force deletes users from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/users")
+ @PreAuthorize("hasRole('ROLE_SYS_ADMIN')")
+ @Produces({ "application/json" })
+ public Response forceDeleteUsers(@Context HttpServletRequest request) {
+ SearchCriteria searchCriteria = new SearchCriteria();
+ searchUtil.extractString(
+ request, searchCriteria, "name", "User
name",null);
+ searchUtil.extractString(
+ request, searchCriteria, "emailAddress", "Email
Address", null);
+ searchUtil.extractInt(
+ request, searchCriteria, "userSource", "User
Source");
+ searchUtil.extractInt(
+ request, searchCriteria, "isVisible", "User
Visibility");
+ searchUtil.extractInt(
+ request, searchCriteria, "status", "User
Status");
+ searchUtil.extractString(
+ request, searchCriteria, "syncSource", "Sync
Source", null);
+ searchUtil.extractRoleString(
+ request, searchCriteria, "userRole", "Role",
null);
+
+ VXUserList userList = xUserMgr.searchXUsers(searchCriteria);
+ xUserMgr.forceDeleteUsers(userList.getList());
+ return Response.ok(userList.getListSize() + " users deleted
successfully").build();
+ }
+
+ /**
+* Proceed with caution: Force deletes groups from the ranger
db,
+* Delete happens one at a time with immediate commit on the
transaction.
+*/
+ @DELETE
+ @Path("/delete/external/groups")
Review Comment:
I suggest replacing `external` in the URI with `force', since this API is
not specific to external group i.e., groupSource query-param.
##
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java:
##
@@ -2400,6 +2426,31 @@ public synchronized void deleteXUser(Long id, boolean
force) {
}
}
+ public void forceDeleteUsers(List users){
+ long startTime = Time.now();
+ for(VXUser user: users){
+ Long userId = user.getId();
+ TransactionTemplate txTemplate = new
TransactionTemplate(txManager);
+
txTemplate.setPropagationBehavior(TransactionDefinition.PROPAGATION_REQUIRES_NEW);
+ try {
+ txTemplate.execute(new
TransactionCallback() {
+ @Override
+ public Object
doInTransaction(TransactionStatus status) {
+ deleteXUser(userId, true);
+ return null;
+ }
+ });
+ } catch (Throwable ex) {
+ logger.error("forceDeleteUsers(): Failed to
delete user id: " + userId + " ", ex);
+ throw new RuntimeException(ex);
Review Comment:
This exception would cause delete operation to be aborted on the first
failure, right? The response to the client wouldn't show that few users have
been deleted. I would suggest the following changes:
- instead of aborting on the first failure, this method should attempt to
delete subsequent users as well
- the return from this method should include list of users successfully
deleted, and the list of users who couldn't be deleted
Similar updates in forceDeleteGroups() as well.
--
This is an automated message from the Apache Git Service.
To respond to the
Re: Review Request 74458: RANGER-4258: Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74458/#review225497 --- Ship it! Ship It! - Madhan Neethiraj On May 31, 2023, 9:06 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74458/ > --- > > (Updated May 31, 2023, 9:06 a.m.) > > > Review request for ranger, Ankita Sinha, Dhaval Rajpara, and madhan. > > > Bugs: RANGER-4258 > https://issues.apache.org/jira/browse/RANGER-4258 > > > Repository: ranger > > > Description > --- > > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum (at least 1000) service definitions, services, > and zones. > > > Diffs > - > > security-admin/src/main/webapp/scripts/controllers/Controller.js d984bac9d > security-admin/src/main/webapp/scripts/utils/XAGlobals.js 4b0c98e30 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js > e6c262235 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > 6d2d94589 > > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js > 94fa3135d > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > 4acebee98 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > 3b8d862a7 > > > Diff: https://reviews.apache.org/r/74458/diff/1/ > > > Testing > --- > > Verified > 1. Service, policy, listing page (Resource/Tag) > 2. Zone listing and create/update page. > 3. Audit access tab > 4. Reports > > > Thanks, > > Nitin Galave > >
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Description: h4. In trino service while creating policy add permission is rendering incorrectly. Actual : - !image-2023-05-31-14-45-34-388.png|width=669,height=304! Expected : - !image-2023-05-31-14-41-35-775.png|width=664,height=298! was: h4. In trino service while creating policy add permission is rendering incorrectly. Actual : - !image-2023-05-31-14-45-34-388.png|width=693,height=315! Expected : - !image-2023-05-31-14-41-35-775.png|width=684,height=307! > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: image-2023-05-31-14-41-35-775.png, > image-2023-05-31-14-45-34-388.png, scrnli_31_05_2023_14-39-04.webm > > > h4. In trino service while creating policy add permission is rendering > incorrectly. > Actual : - > !image-2023-05-31-14-45-34-388.png|width=669,height=304! > Expected : - > !image-2023-05-31-14-41-35-775.png|width=664,height=298! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Description: h4. In trino service while creating policy add permission is rendering incorrectly. Actual : - !image-2023-05-31-14-45-34-388.png|width=693,height=315! Expected : - !image-2023-05-31-14-41-35-775.png|width=684,height=307! was:h1. In trino service while creating policy add permission is rendering incorrectly. > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: image-2023-05-31-14-41-35-775.png, > image-2023-05-31-14-45-34-388.png, scrnli_31_05_2023_14-39-04.webm > > > h4. In trino service while creating policy add permission is rendering > incorrectly. > Actual : - > !image-2023-05-31-14-45-34-388.png|width=693,height=315! > Expected : - > !image-2023-05-31-14-41-35-775.png|width=684,height=307! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Attachment: image-2023-05-31-14-45-34-388.png > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: image-2023-05-31-14-41-35-775.png, > image-2023-05-31-14-45-34-388.png, scrnli_31_05_2023_14-39-04.webm > > > h1. In trino service while creating policy add permission is rendering > incorrectly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Attachment: image-2023-05-31-14-41-35-775.png > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: image-2023-05-31-14-41-35-775.png, > scrnli_31_05_2023_14-39-04.webm > > > h1. In trino service while creating policy add permission is rendering > incorrectly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4258) Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
[ https://issues.apache.org/jira/browse/RANGER-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitin Galave updated RANGER-4258: - Description: Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum (at least 1000) service definitions, services, and zones. cc: [~mad...@apache.org] was:Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum (at least 1000) service definitions, services, and zones. > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum service definitions, services, and zones. > --- > > Key: RANGER-4258 > URL: https://issues.apache.org/jira/browse/RANGER-4258 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Nitin Galave >Assignee: Nitin Galave >Priority: Minor > > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum (at least 1000) service definitions, services, > and zones. > cc: [~mad...@apache.org] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RANGER-4258) Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
[ https://issues.apache.org/jira/browse/RANGER-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727870#comment-17727870 ] Nitin Galave commented on RANGER-4258: -- [~Dhaval.Rajpara] Please review https://reviews.apache.org/r/74458/ > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum service definitions, services, and zones. > --- > > Key: RANGER-4258 > URL: https://issues.apache.org/jira/browse/RANGER-4258 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Nitin Galave >Assignee: Nitin Galave >Priority: Minor > > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum (at least 1000) service definitions, services, > and zones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (RANGER-4258) Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
[ https://issues.apache.org/jira/browse/RANGER-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727870#comment-17727870 ] Nitin Galave edited comment on RANGER-4258 at 5/31/23 9:11 AM: --- [~Dhaval.Rajpara] [~mad...@apache.org] Please review https://reviews.apache.org/r/74458/ was (Author: nitin.galave): [~Dhaval.Rajpara] Please review https://reviews.apache.org/r/74458/ > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum service definitions, services, and zones. > --- > > Key: RANGER-4258 > URL: https://issues.apache.org/jira/browse/RANGER-4258 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Nitin Galave >Assignee: Nitin Galave >Priority: Minor > > Ranger: Instead of limiting the listing to only 25, Ranger should provide a > comprehensive list of maximum (at least 1000) service definitions, services, > and zones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Description: h1. In trino service while creating policy add permission is rendering incorrectly. > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: scrnli_31_05_2023_14-39-04.webm > > > h1. In trino service while creating policy add permission is rendering > incorrectly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
[ https://issues.apache.org/jira/browse/RANGER-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhant Sontakke updated RANGER-4260: -- Attachment: scrnli_31_05_2023_14-39-04.webm > In trino service while creating policy add permission is rendering > incorrectly. > --- > > Key: RANGER-4260 > URL: https://issues.apache.org/jira/browse/RANGER-4260 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Siddhant Sontakke >Assignee: Stalin Nadar >Priority: Major > Attachments: scrnli_31_05_2023_14-39-04.webm > > > h1. In trino service while creating policy add permission is rendering > incorrectly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Review Request 74458: RANGER-4258: Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74458/ --- Review request for ranger, Ankita Sinha, Dhaval Rajpara, and madhan. Bugs: RANGER-4258 https://issues.apache.org/jira/browse/RANGER-4258 Repository: ranger Description --- Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum (at least 1000) service definitions, services, and zones. Diffs - security-admin/src/main/webapp/scripts/controllers/Controller.js d984bac9d security-admin/src/main/webapp/scripts/utils/XAGlobals.js 4b0c98e30 security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js e6c262235 security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 6d2d94589 security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js 94fa3135d security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 4acebee98 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 3b8d862a7 Diff: https://reviews.apache.org/r/74458/diff/1/ Testing --- Verified 1. Service, policy, listing page (Resource/Tag) 2. Zone listing and create/update page. 3. Audit access tab 4. Reports Thanks, Nitin Galave
[jira] [Created] (RANGER-4260) In trino service while creating policy add permission is rendering incorrectly.
Siddhant Sontakke created RANGER-4260: - Summary: In trino service while creating policy add permission is rendering incorrectly. Key: RANGER-4260 URL: https://issues.apache.org/jira/browse/RANGER-4260 Project: Ranger Issue Type: Bug Components: Ranger Reporter: Siddhant Sontakke Assignee: Stalin Nadar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RANGER-4259) Add flag based support for remote debugging dev-support containers
[ https://issues.apache.org/jira/browse/RANGER-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Ambalkar reassigned RANGER-4259: -- Assignee: Mohit Ambalkar > Add flag based support for remote debugging dev-support containers > -- > > Key: RANGER-4259 > URL: https://issues.apache.org/jira/browse/RANGER-4259 > Project: Ranger > Issue Type: Improvement > Components: build-infra >Reporter: Jai Patel >Assignee: Mohit Ambalkar >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4259) Add flag based support for remote debugging dev-support containers
Jai Patel created RANGER-4259: - Summary: Add flag based support for remote debugging dev-support containers Key: RANGER-4259 URL: https://issues.apache.org/jira/browse/RANGER-4259 Project: Ranger Issue Type: Improvement Components: build-infra Reporter: Jai Patel -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74292: RANGER-4025: Ranger improvement - Roles Import/export API for ranger admin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74292/
---
(Updated May 31, 2023, 8:14 a.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-4025
https://issues.apache.org/jira/browse/RANGER-4025
Repository: ranger
Description
---
Provide API for Roles import/export.
Diffs (updated)
-
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerRole.java
682bbd640
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java c19e3e1a1
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java
421b2312d
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
04aee289e
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
3447eb20e
security-admin/src/main/java/org/apache/ranger/view/RangerExportRoleList.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/view/RangerPolicyList.java
4799b3f03
security-admin/src/main/java/org/apache/ranger/view/RangerRoleList.java
adbe93db6
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
9d17553a4
Diff: https://reviews.apache.org/r/74292/diff/8/
Changes: https://reviews.apache.org/r/74292/diff/7-8/
Testing
---
Tested the below Rest API's for Roles import/export to make sure everything
works fine.
RoleREST Rest API :GET /roles/roles/exportJson
RoleREST Rest API :GET
/roles/roles/exportJson?roleName={rolename},{rolename},
RoleREST Rest API :GET /roles/roles/importRolesFromFile
RoleREST Rest API :GET /roles/roles/importRolesFromFile?updateIfExists=true
RoleREST Rest API :GET
/roles/roles/importRolesFromFile?createNonExistUserGroupRole=true
Thanks,
Rakesh Gupta
[jira] [Updated] (RANGER-4025) Ranger improvement - Roles Import/export API for ranger admin
[ https://issues.apache.org/jira/browse/RANGER-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4025: - Attachment: 0008-RANGER-4025.patch > Ranger improvement - Roles Import/export API for ranger admin > - > > Key: RANGER-4025 > URL: https://issues.apache.org/jira/browse/RANGER-4025 > Project: Ranger > Issue Type: New Feature > Components: Ranger >Reporter: Dineshkumar Yadav >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0008-RANGER-4025.patch > > > Provide API for Roles import/export. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4025) Ranger improvement - Roles Import/export API for ranger admin
[ https://issues.apache.org/jira/browse/RANGER-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4025: - Attachment: (was: 0007-RANGER-4025.patch) > Ranger improvement - Roles Import/export API for ranger admin > - > > Key: RANGER-4025 > URL: https://issues.apache.org/jira/browse/RANGER-4025 > Project: Ranger > Issue Type: New Feature > Components: Ranger >Reporter: Dineshkumar Yadav >Assignee: Rakesh Gupta >Priority: Major > > Provide API for Roles import/export. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (RANGER-4254) Allow metrics,roles, tagrest & xaudit Ranger Admin APIs via knox proxy
[ https://issues.apache.org/jira/browse/RANGER-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta resolved RANGER-4254. -- Resolution: Duplicate > Allow metrics,roles, tagrest & xaudit Ranger Admin APIs via knox proxy > -- > > Key: RANGER-4254 > URL: https://issues.apache.org/jira/browse/RANGER-4254 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Rakesh Gupta >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0001-RANGER-4254.patch > > > Adding Other List of APIs via knox > - Tagrest Api > - xAudit Api > [https://ranger.apache.org/apidocs/resource_XAuditREST.html#resource_XAuditREST_searchXAccessAudits_GET] > - Role Api > - Ranger metrics APIs as well > /service/metrics/status -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RANGER-4210) Use colors for allow/deny users in policy list
[ https://issues.apache.org/jira/browse/RANGER-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stalin Nadar reassigned RANGER-4210: Assignee: Stalin Nadar > Use colors for allow/deny users in policy list > -- > > Key: RANGER-4210 > URL: https://issues.apache.org/jira/browse/RANGER-4210 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Kai Voigt >Assignee: Stalin Nadar >Priority: Minor > Attachments: ranger.png > > > In the list of policies, the Users columns summarises all users affected by > each policy. It would be helpful to color code users with allow permissions > in green, and deny permissions in red. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4258) Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones.
Nitin Galave created RANGER-4258: Summary: Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum service definitions, services, and zones. Key: RANGER-4258 URL: https://issues.apache.org/jira/browse/RANGER-4258 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: Nitin Galave Assignee: Nitin Galave Ranger: Instead of limiting the listing to only 25, Ranger should provide a comprehensive list of maximum (at least 1000) service definitions, services, and zones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
