[jira] [Updated] (RANGER-4687) Updating the "Something went wrong" page in Ranger React UI

2024-02-25 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4687:

Attachment: 0004-RANGER-4687.patch

> Updating the "Something went wrong" page in Ranger React UI 
> 
>
> Key: RANGER-4687
> URL: https://issues.apache.org/jira/browse/RANGER-4687
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4687.patch, 0002-RANGER-4687.patch, 
> 0003-RANGER-4687.patch, 0004-RANGER-4687.patch
>
>
> Updating the "Something went wrong" page in Ranger React UI
> *Current behaviour:-*
>  * If there's an error or code break in Ranger react file, the "Something 
> went wrong" page appears.
>  * The error details, including stack traces, are only shown in UI, this 
> makes the RANGER UI not available.
> The error details, shouldn't be display in UI, instead of it add the buttons 
> for reloading and go to profile page.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74868: RANGER-4687: Updating the "Something went wrong" page in Ranger React UI

2024-02-25 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74868/
---

(Updated Feb. 26, 2024, 6:59 a.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4687
https://issues.apache.org/jira/browse/RANGER-4687


Repository: ranger


Description
---

Updating the "Something went wrong" page in Ranger React UI

Current behaviour:-

1)If there's an error or code break in Ranger react file, the "Something went 
wrong" page appears.
2)The error details, including stack traces, are only shown in UI, this makes 
the RANGER UI not available.

The error details, shouldn't be display in UI, instead of it add the buttons 
for reloading and go to profile page.


Diffs (updated)
-

  security-admin/src/main/webapp/react-webapp/src/styles/style.css f5caff0bb 
  security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx 
85ece434e 


Diff: https://reviews.apache.org/r/74868/diff/4/

Changes: https://reviews.apache.org/r/74868/diff/3-4/


Testing
---

Applied the patch on a cluster and tested the following UI scenarios :-
1)Tested the something went wrong page.


Thanks,

Brijesh Bhalala



[jira] [Updated] (RANGER-4699) Update the execution of setServiceDef call in App.jsx

2024-02-25 Thread Dhaval Rajpara (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhaval Rajpara updated RANGER-4699:
---
Attachment: 0001-RANGER-4699-Update-the-execution-of-setServiceDef-ca.patch

> Update the execution of setServiceDef call in App.jsx
> -
>
> Key: RANGER-4699
> URL: https://issues.apache.org/jira/browse/RANGER-4699
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Dhaval Rajpara
>Priority: Major
>  Labels: ranger-react
> Attachments: 
> 0001-RANGER-4699-Update-the-execution-of-setServiceDef-ca.patch
>
>
> Need minor code update in executing the setServiceDef() call in App.jsx



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RANGER-4699) Update the execution of setServiceDef call in App.jsx

2024-02-25 Thread Dhaval Rajpara (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhaval Rajpara updated RANGER-4699:
---
Attachment: (was: 0001-RANGER-4699.patch)

> Update the execution of setServiceDef call in App.jsx
> -
>
> Key: RANGER-4699
> URL: https://issues.apache.org/jira/browse/RANGER-4699
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Dhaval Rajpara
>Priority: Major
>  Labels: ranger-react
> Attachments: 
> 0001-RANGER-4699-Update-the-execution-of-setServiceDef-ca.patch
>
>
> Need minor code update in executing the setServiceDef() call in App.jsx



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RANGER-3646) LOG.debug print content error

2024-02-25 Thread wangzhongwei (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820554#comment-17820554
 ] 

wangzhongwei commented on RANGER-3646:
--

[~madhan] -ok,thanks.

> LOG.debug print content error
> -
>
> Key: RANGER-3646
> URL: https://issues.apache.org/jira/browse/RANGER-3646
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.2.0
>Reporter: wangzhongwei
>Assignee: wangzhongwei
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-RANGER-3646-LOG.debug-print-content-error.patch, 
> RANGER-3646.001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In RangerPolicyRepository.java 
> wrong log info :
> LOG.debug("rowFilter policy evaluation order: #" + (++order) + " - policy 
> id=" + policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());
> that should be :
> LOG.debug("audit policy evaluation order: #" + (++order) + " - policy id=" + 
> policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (RANGER-3646) LOG.debug print content error

2024-02-25 Thread wangzhongwei (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangzhongwei reassigned RANGER-3646:


Assignee: wangzhongwei

> LOG.debug print content error
> -
>
> Key: RANGER-3646
> URL: https://issues.apache.org/jira/browse/RANGER-3646
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.2.0
>Reporter: wangzhongwei
>Assignee: wangzhongwei
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-RANGER-3646-LOG.debug-print-content-error.patch, 
> RANGER-3646.001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In RangerPolicyRepository.java 
> wrong log info :
> LOG.debug("rowFilter policy evaluation order: #" + (++order) + " - policy 
> id=" + policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());
> that should be :
> LOG.debug("audit policy evaluation order: #" + (++order) + " - policy id=" + 
> policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RANGER-3646) LOG.debug print content error

2024-02-25 Thread Madhan Neethiraj (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820541#comment-17820541
 ] 

Madhan Neethiraj commented on RANGER-3646:
--

[~zhongwei11]  - thank you for the contribution. You now have contributor 
access in Apache Ranger; you can assign JIRAs to yourself.

> LOG.debug print content error
> -
>
> Key: RANGER-3646
> URL: https://issues.apache.org/jira/browse/RANGER-3646
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.2.0
>Reporter: wangzhongwei
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-RANGER-3646-LOG.debug-print-content-error.patch, 
> RANGER-3646.001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In RangerPolicyRepository.java 
> wrong log info :
> LOG.debug("rowFilter policy evaluation order: #" + (++order) + " - policy 
> id=" + policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());
> that should be :
> LOG.debug("audit policy evaluation order: #" + (++order) + " - policy id=" + 
> policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RANGER-4725) Admin audits are not generated for deletion of shared resources and datashare in dataset when a datashare is deleted

2024-02-25 Thread Madhan Neethiraj (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820538#comment-17820538
 ] 

Madhan Neethiraj commented on RANGER-4725:
--

{quote}However, there are no admin audits generated for the shared resources 
and the datashare in dataset deletion.
{quote}
[~abhishek.patil]  - since shared-resources are objects contained within the 
data-share being deleted, separate admin audits for each shared resource is not 
necessary. However, it will help to create an audit log for deletion of 
associated datashare-in-datasets.

 

> Admin audits are not generated for deletion of shared resources and datashare 
> in dataset when a datashare is deleted
> 
>
> Key: RANGER-4725
> URL: https://issues.apache.org/jira/browse/RANGER-4725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
>
> When a datashare is deleted, the associated datashare in datasets and the 
> shared resources in the datashares are also deleted. However, there are no 
> admin audits generated for the shared resources and the datashare in dataset 
> deletion.
> Ideally, admin audits must be generated for these operations as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (RANGER-3646) LOG.debug print content error

2024-02-25 Thread wangzhongwei (Jira)


[ https://issues.apache.org/jira/browse/RANGER-3646 ]


wangzhongwei deleted comment on RANGER-3646:
--

was (Author: JIRAUSER285670):
[~bpatel] could you please help me to set me as Assignee?thanks

> LOG.debug print content error
> -
>
> Key: RANGER-3646
> URL: https://issues.apache.org/jira/browse/RANGER-3646
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 2.2.0
>Reporter: wangzhongwei
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-RANGER-3646-LOG.debug-print-content-error.patch, 
> RANGER-3646.001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In RangerPolicyRepository.java 
> wrong log info :
> LOG.debug("rowFilter policy evaluation order: #" + (++order) + " - policy 
> id=" + policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());
> that should be :
> LOG.debug("audit policy evaluation order: #" + (++order) + " - policy id=" + 
> policy.getId() + "; name=" + policy.getName() + "; evalOrder=" + 
> policyEvaluator.getEvalOrder());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)